[PATCH v2 0/4] Enable TRNG support

[PATCH v2 0/4] Enable TRNG support

[Md Sadre Alam]

This patch series enables support for Truly Random Number
Generators (TRNG) across various targets, including IPQ95xx,
IPQ53xx, and IPQ54xx.

v2:
 * Revised the commit message.
 * Updated the cover letter to change IPQ32xx to IPQ53xx
 * Changed IPQ95xx to IPQ9574 in the commit message
 * Updated commit heading from "Add TRNG node" to "add TRNG node".
 * Changed "add TRNG" to "Add TRNG" in the commit message
 * Added changes to the device tree binding
 * Updated compatible string 

v1:
 * https://lore.kernel.org/linux-arm-msm/20241206072057.1508459-1-quic_mdalam@quicinc.com/
 * Submitted initial patches to activate TRNG


Md Sadre Alam (4):
  dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322
  arm64: dts: qcom: ipq5424: add TRNG node
  arm64: dts: qcom: ipq9574: update TRNG compatible
  arm64: dts: qcom: ipq5332: update TRNG compatible

 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 3 +++
 arch/arm64/boot/dts/qcom/ipq5332.dtsi                   | 2 +-
 arch/arm64/boot/dts/qcom/ipq5424.dtsi                   | 7 +++++++
 arch/arm64/boot/dts/qcom/ipq9574.dtsi                   | 2 +-
 4 files changed, 12 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322

[Md Sadre Alam]

Document ipq9574, ipq5424 and ipq5322 compatible for the True Random Number
Generator.

Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---

Change in [v2]

* Added device tree binding change

Change in [v1]

* This patch was not included in [v1]

 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 2c959162e428..7ca1db52bbc5 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -24,6 +24,9 @@ properties:
               - qcom,sm8450-trng
               - qcom,sm8550-trng
               - qcom,sm8650-trng
+              - qcom,ipq5332-trng
+              - qcom,ipq5424-trng
+              - qcom,ipq9574-trng
           - const: qcom,trng
 
   reg:
-- 
2.34.1

[PATCH v2 2/4] arm64: dts: qcom: ipq5424: add TRNG node

[Md Sadre Alam]

Add TRNG (Truly Random Number Generator) node for ipq5424

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---

Change in [v2]

* Included Reviewed-by tag
* Updated commit heading from "Add TRNG node" to "add TRNG node".
* Changed "add TRNG" to "Add TRNG" in the commit message
* updated compatible string

Change in [v1]

* Submitted initial patche to activate TRNG for IPQ5424

 arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
index 5e219f900412..aab1cf787863 100644
--- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
@@ -145,6 +145,13 @@ soc@0 {
 		#size-cells = <2>;
 		ranges = <0 0 0 0 0x10 0>;
 
+		rng: rng@4c3000 {
+			compatible = "qcom,ipq5424-trng", "qcom,trng";
+			reg = <0 0x004c3000 0 0x1000>;
+			clocks = <&gcc GCC_PRNG_AHB_CLK>;
+			clock-names = "core";
+		};
+
 		tlmm: pinctrl@1000000 {
 			compatible = "qcom,ipq5424-tlmm";
 			reg = <0 0x01000000 0 0x300000>;
-- 
2.34.1

[PATCH v2 3/4] arm64: dts: qcom: ipq9574: update TRNG compatible

[Md Sadre Alam]

RNG hardware versions greater than 3.0 are Truly Random Number
Generators (TRNG). In IPQ9574, the RNGblock is a TRNG.

This patch corrects the compatible property which correctly describes
the hardware without making any functional changes

Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---

Change in [v2]

* Revised the commit message
* Changed IPQ95xx to IPQ9574 in the commit message
* updated compatible string

Change in [v1]

* Submitted initial patche to activate TRNG

 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index d1fd35ebc4a2..453574c370f1 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -227,7 +227,7 @@ rpm_msg_ram: sram@60000 {
 		};
 
 		rng: rng@e3000 {
-			compatible = "qcom,prng-ee";
+			compatible = "qcom,ipq9574-trng", "qcom,trng";
 			reg = <0x000e3000 0x1000>;
 			clocks = <&gcc GCC_PRNG_AHB_CLK>;
 			clock-names = "core";
-- 
2.34.1

[PATCH v2 4/4] arm64: dts: qcom: ipq5332: update TRNG compatible

[Md Sadre Alam]

RNG hardware versions greater than 3.0 are Truly Random Number
Generators (TRNG). In IPQ5332, the RNGblock is a TRNG.

This patch corrects the compatible property which correctly describes
the hardware without making any functional changes

Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---

Change in [v2]

* Revised the commit message
* updated compatible string

Change in [v1]

* Submitted initial patche to activate TRNG

 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index d3c3e215a15c..ca3da95730bd 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -180,7 +180,7 @@ cpu_speed_bin: cpu-speed-bin@1d {
 		};
 
 		rng: rng@e3000 {
-			compatible = "qcom,prng-ee";
+			compatible = "qcom,ipq5332-trng", "qcom,trng";
 			reg = <0x000e3000 0x1000>;
 			clocks = <&gcc GCC_PRNG_AHB_CLK>;
 			clock-names = "core";
-- 
2.34.1

Re: [PATCH v2 3/4] arm64: dts: qcom: ipq9574: update TRNG compatible

[Konrad Dybcio]

On 20.12.2024 8:00 AM, Md Sadre Alam wrote:
> RNG hardware versions greater than 3.0 are Truly Random Number
> Generators (TRNG). In IPQ9574, the RNGblock is a TRNG.
> 
> This patch corrects the compatible property which correctly describes
> the hardware without making any functional changes
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2 4/4] arm64: dts: qcom: ipq5332: update TRNG compatible

[Konrad Dybcio]

On 20.12.2024 8:00 AM, Md Sadre Alam wrote:
> RNG hardware versions greater than 3.0 are Truly Random Number
> Generators (TRNG). In IPQ5332, the RNGblock is a TRNG.
> 
> This patch corrects the compatible property which correctly describes
> the hardware without making any functional changes
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322

[Krzysztof Kozlowski]

On Fri, Dec 20, 2024 at 12:30:33PM +0530, Md Sadre Alam wrote:
> Document ipq9574, ipq5424 and ipq5322 compatible for the True Random Number
> Generator.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
> 
> Change in [v2]
> 
> * Added device tree binding change
> 
> Change in [v1]
> 
> * This patch was not included in [v1]
> 
>  Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 2c959162e428..7ca1db52bbc5 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -24,6 +24,9 @@ properties:
>                - qcom,sm8450-trng
>                - qcom,sm8550-trng
>                - qcom,sm8650-trng
> +              - qcom,ipq5332-trng
> +              - qcom,ipq5424-trng
> +              - qcom,ipq9574-trng

Do not add new entries to the end of lists. Keep sorting.

Best regards,
Krzysztof

Re: [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322

[Md Sadre Alam]

On 12/24/2024 3:12 PM, Krzysztof Kozlowski wrote:
> On Fri, Dec 20, 2024 at 12:30:33PM +0530, Md Sadre Alam wrote:
>> Document ipq9574, ipq5424 and ipq5322 compatible for the True Random Number
>> Generator.
>>
>> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>> ---
>>
>> Change in [v2]
>>
>> * Added device tree binding change
>>
>> Change in [v1]
>>
>> * This patch was not included in [v1]
>>
>>   Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> index 2c959162e428..7ca1db52bbc5 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> @@ -24,6 +24,9 @@ properties:
>>                 - qcom,sm8450-trng
>>                 - qcom,sm8550-trng
>>                 - qcom,sm8650-trng
>> +              - qcom,ipq5332-trng
>> +              - qcom,ipq5424-trng
>> +              - qcom,ipq9574-trng
> 
> Do not add new entries to the end of lists. Keep sorting.
Sure, Will do in next revision.
> 
> Best regards,
> Krzysztof
>