From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112D127A139 for ; Mon, 16 Jun 2025 11:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750071718; cv=none; b=V/1ePViseaCerLrNYX5mTRDH2/OwTbVvTwlXi/nAZLGr24jghGoEGQH+b/pB/fFB1UlOmb0aT9MRCYB/3qloV8CqkFdLZdsMIDSF8h6xUwrjZ/LIUJLCoqNv+T7T4QY7Bs09tOFEidwXSdJICxsRJlaeqcqZXrbjF3/Fr4L7on4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750071718; c=relaxed/simple; bh=Blj7OdweNvMj6IcZFUrLUJTJlraPWT18QouClWkAzsU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aVZLjwbJWavksmuz6yNm8eIdjGrFtYD7aFlpkONzP5v+obeUpyyTvwHO8VY9cY4QXVcsPOtYzpEZ+TyG4xHtDnqHOX64lKwNsFKE6ENeig1GJJPd3C3bd9gPxMzuRHLL8RtAv26VjZpRp20jAlHjBS1r1Z8tk7tP15QcPXY+Ra8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uR7ap-0007WP-Qv; Mon, 16 Jun 2025 13:01:35 +0200 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uR7ao-003nBX-1X; Mon, 16 Jun 2025 13:01:34 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1uR7ao-000LXs-1C; Mon, 16 Jun 2025 13:01:34 +0200 Message-ID: <0444ceee9743a349bb7155dac6ca7ea25f5adb18.camel@pengutronix.de> Subject: Re: [PATCH v3 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support From: Philipp Zabel To: george.moussalem@outlook.com, Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Date: Mon, 16 Jun 2025 13:01:34 +0200 In-Reply-To: <20250602-ipq5018-ge-phy-v3-3-421337a031b2@outlook.com> References: <20250602-ipq5018-ge-phy-v3-0-421337a031b2@outlook.com> <20250602-ipq5018-ge-phy-v3-3-421337a031b2@outlook.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On Mo, 2025-06-02 at 13:53 +0400, George Moussalem via B4 Relay wrote: > From: George Moussalem >=20 > The IPQ5018 SoC contains a single internal Gigabit Ethernet PHY which > provides an MDI interface directly to an RJ45 connector or an external > switch over a PHY to PHY link. >=20 > The PHY supports 10/100/1000 mbps link modes, CDT, auto-negotiation and > 802.3az EEE. >=20 > Let's add support for this PHY in the at803x driver as it falls within > the Qualcomm Atheros OUI. >=20 > Signed-off-by: George Moussalem > --- > drivers/net/phy/qcom/Kconfig | 2 +- > drivers/net/phy/qcom/at803x.c | 185 ++++++++++++++++++++++++++++++++++++= ++++-- > 2 files changed, 178 insertions(+), 9 deletions(-) >=20 [...] > diff --git a/drivers/net/phy/qcom/at803x.c b/drivers/net/phy/qcom/at803x.= c > index 26350b962890b0321153d74758b13d817407d094..c148e245b5391c5da374ace86= 09dcdfd8284732d 100644 > --- a/drivers/net/phy/qcom/at803x.c > +++ b/drivers/net/phy/qcom/at803x.c > @@ -7,19 +7,24 @@ [...] > +static int ipq5018_probe(struct phy_device *phydev) > +{ > + struct device *dev =3D &phydev->mdio.dev; > + struct ipq5018_priv *priv; > + int ret; > + > + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->set_short_cable_dac =3D of_property_read_bool(dev->of_node, > + "qcom,dac-preset-short-cable"); > + > + priv->rst =3D devm_reset_control_array_get_exclusive(dev); Both dt-bindings and dts patch only show a single reset. Is there a reason this is a reset_control_array? regards Philipp