Re: [PATCH v6 2/5] arm64: dts: qcom: Add sdhc dll-presets

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/12/2025 13:41, Ram Prakash Gupta wrote:
> 
> On 12/15/2025 5:37 PM, Krzysztof Kozlowski wrote:
>> On 15/12/2025 13:05, Krzysztof Kozlowski wrote:
>>> On 15/12/2025 13:00, Ram Prakash Gupta wrote:
>>>> Add sdhc dll-presets for qdu1000 target.
>>>>
>>>> Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/qdu1000.dtsi | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>> Please use subject prefixes matching the subsystem. You can get them for
>>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>>> your patch is touching. For bindings, the preferred subjects are
>>> explained here:
>>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> sure I missed to add qdu1000:, will add in subject.
> 
>>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
>>>> index 846e5e5899aa..bc31504d5c8c 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
>>>> @@ -912,8 +912,8 @@ sdhc: mmc@8804000 {
>>>>  
>>>>  			bus-width = <8>;
>>>>  
>>>> -			qcom,dll-config = <0x0007642c>;
>>>> -			qcom,ddr-config = <0x80040868>;
>>>> +			qcom,dll-presets = <0x000F64EC 0x0 0x01	0x2C010800 0x80040868>,
>>>> +					   <0x0007642C 0x0 0x10 0x2C010800 0x80040868>;
>>>
>>> That's non-bisectable. You just broke the users of this DTS. Also, case
>>> change is not explained and your binding said nothing about deprecating
>>> other properties.
> 
> right I will update the sequence of dt as last change in the series.

This will fix nothing. Please read maintainer soc profile how DTS is
handled. It's still no go, shall I be explicit with NAK?

> 
> I couldn't get "case change is not explained" but I guess ask is for
> explanation why is this change needed. As the soc is using artanis

No, why are you making it upper case. What is the preferred style for DTS?


Best regards,
Krzysztof