From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CCF71A8F61; Sat, 29 Mar 2025 11:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743246402; cv=none; b=s6kaUtvr0XBbjPOpcjguUV/UhuEo+KpcRmCGRF05U6UsYIoTYcA84Fku/9nRA/BGyVtWDnBGAzMaHhJri80/JUY9pPaqGfi1gA5x1E8TX+dqZVbPoLSzmunqBaHr4nGL1EF2ltum153/4A36o9VE8FqTHh1VVy062Am9HtiUnrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743246402; c=relaxed/simple; bh=was+ytU0YEHXTnWHMcX45+zuLYr/5rHvcBsQlaBb66s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=apco/c4UCOcuR1Ui0B7WZjkmwSiCjwQ/8k2rHkTSEiwLa/lhq9kW12lsZ6BVWHRadfaAll/z/g8Ng/3zYpMahMT5HCVOoEUsKRmv82KFy8iOUQyshI57WW5IPGOqb8ZYcEksLlumx9ejBlKyXdMm8qJxEb+ad7voYyY6EvEqFhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cmHor07s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cmHor07s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FDA0C4CEE2; Sat, 29 Mar 2025 11:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743246401; bh=was+ytU0YEHXTnWHMcX45+zuLYr/5rHvcBsQlaBb66s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cmHor07su1qJnS29u0lPYMH6jjLWgGeTdGrtNtHfkcZlEF/kcvy0g/LaDqkmAi0dH 4kAxG/AQhzwDU0pC4AhQ2n6e0U2l05fvf/2YpAu5H9afMldDZUoMZFCceGyH9AAAEv uD2oS3MfasEYE7lYqIDeob+sabJRmwjrcdgf8mQGyBw84G6ATVOthuQEiJnstPHpmM i5KRCacq39xLbuy6gk8DBHRt3qmsJAqj0ts2COLBGLCfPqtQ1e8oRawKWDOVtBXfKF kd7b/TyTi18/puIy8qVUlDkED1D9iJZ/wyHBVmW1R3IN0mnHAuouwhPkn7XvXHu2f8 RCg9VG0g96LrA== Message-ID: <04945ad2-1372-4c73-beae-fc6449fb9a76@kernel.org> Date: Sat, 29 Mar 2025 12:06:34 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: i3c: Add Qualcomm I3C master controller To: Mukesh Kumar Savaliya , alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jarkko.nikula@linux.intel.com, linux-i3c@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org References: <20250326141641.3471906-1-quic_msavaliy@quicinc.com> <20250326141641.3471906-2-quic_msavaliy@quicinc.com> <991b0652-76f2-40d6-b49b-1e6f76e254ac@kernel.org> <661e1a21-0f3a-497a-9b3b-fab284e30d19@quicinc.com> <36b67f9c-5905-4fa6-8190-ab980850b3a2@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/03/2025 10:08, Mukesh Kumar Savaliya wrote: >>>>> + I3C in master mode supports up to 12.5MHz, SDR mode data transfer in mixed >>>>> + bus mode (I2C and I3C target devices on same i3c bus). It also supports >>>>> + hotjoin, IBI mechanism. >>>>> + >>>>> + I3C Controller nodes must be child of GENI based Qualcomm Universal >>>>> + Peripharal. Please refer GENI based QUP wrapper controller node bindings >>>>> + described in Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml. >>>>> + >>>>> +allOf: >>>>> + - $ref: i3c.yaml# >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + const: qcom,i3c-master >>>> >>>> And this got worse. It makes also no sense either: how can you claim >>>> that this covers all possible future I3C masters from Qualcomm? >>>> >>>> What was the resolution of previous discussion? >>>> >>> Below was my understanding and reply. >>> " >>> I think i should remove const. kept it for now as no other compatible to >>> be added as of now. >>> let me remove const. >>> SoC name is not required, as this compatible is generic to all the SOCs. >> >> I don't see any talks about const, what are you referring to? >> > +properties: > + compatible: > + : qcom,i3c-geni > will this be fine ? Yes, I think that was also suggested by Rob. Or rather follow existing style so qcom,geni-i3c for the compatible and filename. Best regards, Krzysztof