From: Eric Woudstra <ericwouds@gmail.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Frank Wunderlich <frank-w@public-files.de>,
Lucien Jheng <lucien.jheng@airoha.com>,
Zhi-Jun You <hujy652@protonmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 net-next 2/2] net: phy: air_en8811h: Add the Airoha EN8811H PHY driver
Date: Sun, 3 Mar 2024 15:22:32 +0100 [thread overview]
Message-ID: <049689b5-2b36-4dbe-b910-5e570618ce05@gmail.com> (raw)
In-Reply-To: <ZePicFOrsr5wTE_n@makrotopia.org>
On 3/3/24 03:37, Daniel Golle wrote:
>> +
>> + /* BUG in PHY firmware: MDIO_AN_10GBT_STAT_LP2_5G does not get set.
>
> EN8811H completely lacks MDIO_AN_10GBT_STAT, hence referencing
> MDIO_AN_10GBT_STAT_LP2_5G here is confusing.
>
> Suggestion:
> /* BUG in PHY firmware: EN8811H_2P5G_LPA_2P5G does not get set.
>
> Or just skip that line entirely as the following two lines already
> perfectly explain the situation.
>
Thanks
I also have a reply from kernel test robot, so I'll need to fix some more.
Better to see if I can only send to the test robot first.
next prev parent reply other threads:[~2024-03-03 14:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 18:38 [PATCH v2 net-next 0/2] Add en8811h phy driver and devicetree binding doc Eric Woudstra
2024-03-02 18:38 ` [PATCH v2 net-next 1/2] dt-bindings: net: airoha,en8811h: Add en8811h Eric Woudstra
2024-03-04 8:09 ` Krzysztof Kozlowski
2024-03-02 18:38 ` [PATCH v2 net-next 2/2] net: phy: air_en8811h: Add the Airoha EN8811H PHY driver Eric Woudstra
2024-03-03 2:37 ` Daniel Golle
2024-03-03 14:22 ` Eric Woudstra [this message]
2024-03-03 16:47 ` Andrew Lunn
2024-03-03 17:03 ` Daniel Golle
2024-03-03 17:08 ` Andrew Lunn
2024-03-05 8:24 ` Eric Woudstra
2024-03-03 17:29 ` Andrew Lunn
2024-03-05 8:13 ` Eric Woudstra
2024-03-05 13:54 ` Andrew Lunn
2024-03-07 16:48 ` Eric Woudstra
2024-03-07 17:40 ` Daniel Golle
2024-03-07 18:47 ` Andrew Lunn
2024-03-03 17:51 ` Andrew Lunn
2024-03-05 8:19 ` Eric Woudstra
2024-03-05 9:03 ` Russell King (Oracle)
2024-03-05 14:06 ` Andrew Lunn
2024-03-05 14:24 ` Russell King (Oracle)
2024-03-05 15:59 ` Andrew Lunn
2024-03-07 16:50 ` Eric Woudstra
2024-03-04 18:05 ` Simon Horman
2024-03-05 8:39 ` Eric Woudstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=049689b5-2b36-4dbe-b910-5e570618ce05@gmail.com \
--to=ericwouds@gmail.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=hujy652@protonmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lucien.jheng@airoha.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).