devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jayesh Choudhary <j-choudhary@ti.com>,
	nm@ti.com, vigneshr@ti.com, devicetree@vger.kernel.org
Cc: kristo@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, s-vadapalli@ti.com, rogerq@kernel.org,
	afd@ti.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"
Date: Wed, 2 Jul 2025 22:30:37 +0200	[thread overview]
Message-ID: <04a0d550-3fb4-4cf9-8adf-4ed54e3af7ba@kernel.org> (raw)
In-Reply-To: <d8a8293d-2759-4408-b1a7-a2689383b043@ti.com>

On 01/07/2025 12:23, Jayesh Choudhary wrote:
> Hello Krzysztof,
> 
> On 04/06/25 15:18, Jayesh Choudhary wrote:
>> Hello Krzysztof,
>>
>> On 03/06/25 16:32, Krzysztof Kozlowski wrote:
>>> On 03/06/2025 11:56, Jayesh Choudhary wrote:
>>>> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
>>>> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
>>>> "scm_conf" node to "simple-bus".
>>>> Also remove "reg" property as it is not needed by "simple-bus".
>>>
>>> This (possibly) affects all other users of DTS which were expecting this
>>> ABI. It's not only about forward-compatibility, but other projects.
>>>
>>> Maybe this doe snot matter for you, so explain that in commit msg and
>>> provide rationale why you are affecting other users.
>>>
>>>
>>
>> This should not affect other users of DTS. J784S4 already has this
>> change and it serves as a validation that DT nodes are compatible
>> with other projects (for example uboot driver handles it).
>> Other SoCs are being modified with taking J784S4 as a working reference.
>>
>> Considering this, do I still need to add something? Or is it okay
>> since I am not exactly affecting other projects?
>> Should I add something along the lines of "similar to j784s4...."?
>>
> 
> Gentle ping on the above comment.
> 
> I have checked other projects like Barebox. That supports TI K3 SoC
> but only AM62x and AM62L. Nothing in this series affects it.

Your answer is really not sufficient, just something to reply so I will
bug off, so I decided to ignore it.

This affects other projects - it is clearly visible in the diff. You
removed a compatible and you cannot do that.

Best regards,
Krzysztof

  reply	other threads:[~2025-07-02 20:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-03  9:56 [PATCH 0/4] "scm_conf" node cleanup for TI's Jacinto SoC family Jayesh Choudhary
2025-06-03  9:56 ` [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus" Jayesh Choudhary
2025-06-03 10:07   ` Siddharth Vadapalli
2025-06-03 11:02   ` Krzysztof Kozlowski
2025-06-04  9:48     ` Jayesh Choudhary
2025-07-01 10:23       ` Jayesh Choudhary
2025-07-02 20:30         ` Krzysztof Kozlowski [this message]
2025-06-03  9:56 ` [PATCH 2/4] arm64: dts: ti: k3-j7200-main: " Jayesh Choudhary
2025-06-03 10:07   ` Siddharth Vadapalli
2025-06-03  9:56 ` [PATCH 3/4] arm64: dts: ti: k3-j721s2-main: " Jayesh Choudhary
2025-06-03 10:07   ` Siddharth Vadapalli
2025-06-03  9:56 ` [PATCH 4/4] arm64: dts: ti: k3-j784s4-j742s2-main-common: Remove "reg" from "scm_conf" Jayesh Choudhary
2025-06-03 10:07   ` Siddharth Vadapalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04a0d550-3fb4-4cf9-8adf-4ed54e3af7ba@kernel.org \
    --to=krzk@kernel.org \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).