From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Philippe Brucker Subject: Re: [PATCH 17/37] iommu/arm-smmu-v3: Move context descriptor code Date: Wed, 14 Mar 2018 13:08:15 +0000 Message-ID: <04ae7f27-08b3-47c1-3d62-6dcc1fe79c1f@arm.com> References: <20180212183352.22730-1-jean-philippe.brucker@arm.com> <20180212183352.22730-18-jean-philippe.brucker@arm.com> <20180309124445.00005e08@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180309124445.00005e08-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jonathan Cameron Cc: Mark Rutland , "ilias.apalodimas-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "xuzaibo-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , Will Deacon , "okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "bharatku-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" , "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Catalin Marinas , "rfranz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org" , "lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , rjw@rjwyso List-Id: devicetree@vger.kernel.org On 09/03/18 11:44, Jonathan Cameron wrote: > On Mon, 12 Feb 2018 18:33:32 +0000 > Jean-Philippe Brucker wrote: > >> In order to add support for substream ID, move the context descriptor code >> into a separate library. At the moment it only manages context descriptor >> 0, which is used for non-PASID translations. >> >> One important behavior change is the ASID allocator, which is now global >> instead of per-SMMU. If we end up needing per-SMMU ASIDs after all, it >> would be relatively simple to move back to per-device allocator instead >> of a global one. Sharing ASIDs will require an IDR, so implement the >> ASID allocator with an IDA instead of porting the bitmap, to ease the >> transition. >> >> Signed-off-by: Jean-Philippe Brucker > Hi Jean-Philippe, > > This would have been easier to review if split into a 'move' and additional > patches actually making the changes described. > > Superficially it looks like there may be more going on in here than the > above description suggests. I'm unsure why we are gaining > the CFGI_CD_ALL and similar in this patch as there is just to much going on. Ok I'll try to split this Thanks, Jean