Re: [PATCH 1/2] dt-bindings: clock: Update identifiers for VIIF on Toshiba Visconti TMPV770x SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/10/2025 03:33, Yuji Ishikawa wrote:
> Update identifiers for the clocks and the resets of Video Input Interface
> in order to reflect the actual architecture of TMPV770x SoC.
> 
> Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
> ---
>  include/dt-bindings/clock/toshiba,tmpv770x.h | 33 +++++++++++++-------
>  include/dt-bindings/reset/toshiba,tmpv770x.h | 10 +++++-
>  2 files changed, 31 insertions(+), 12 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/toshiba,tmpv770x.h b/include/dt-bindings/clock/toshiba,tmpv770x.h
> index 5fce713001..2dbd5885c0 100644
> --- a/include/dt-bindings/clock/toshiba,tmpv770x.h
> +++ b/include/dt-bindings/clock/toshiba,tmpv770x.h
> @@ -94,10 +94,10 @@
>  #define TMPV770X_CLK_DSP2_PBCLK		77
>  #define TMPV770X_CLK_DSP3_PBCLK		78
>  #define TMPV770X_CLK_DSVIIF0_APBCLK	79
> -#define TMPV770X_CLK_VIIF0_APBCLK	80
> -#define TMPV770X_CLK_VIIF0_CFGCLK	81
> -#define TMPV770X_CLK_VIIF1_APBCLK	82
> -#define TMPV770X_CLK_VIIF1_CFGCLK	83
> +#define TMPV770X_CLK_VIIFBS0_APB	80

Nope, that's ABI break. These values do not reflect actual architecture,
that's some non-sense. These are abstract numbers.

NAK



Best regards,
Krzysztof