* [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node
2023-09-11 14:25 [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible Andrew Davis
@ 2023-09-11 14:25 ` Andrew Davis
2023-09-13 14:49 ` Aradhya Bhatia
2023-09-11 15:44 ` [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Andrew Davis @ 2023-09-11 14:25 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Aradhya Bhatia
Cc: devicetree, linux-arm-kernel, linux-kernel, Andrew Davis
This matches the binding for this register region which fixes a couple
DTS check warnings.
While here trim the leading 0s from the "reg" definition.
Signed-off-by: Andrew Davis <afd@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index bc460033a37a8..d5f217427893d 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -498,8 +498,8 @@ serdes_mux: mux-controller {
};
dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
- compatible = "syscon";
- reg = <0x000041e0 0x14>;
+ compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
+ reg = <0x41e0 0x14>;
};
ehrpwm_tbclk: clock-controller@4140 {
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node
2023-09-11 14:25 ` [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node Andrew Davis
@ 2023-09-13 14:49 ` Aradhya Bhatia
2023-09-14 9:43 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Aradhya Bhatia @ 2023-09-13 14:49 UTC (permalink / raw)
To: Andrew Davis, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Nishanth Menon, Vignesh Raghavendra, Tero Kristo
Cc: devicetree, linux-arm-kernel, linux-kernel
On 11/09/23 09:25, Andrew Davis wrote:
> This matches the binding for this register region which fixes a couple
> DTS check warnings.
>
> While here trim the leading 0s from the "reg" definition.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
For both the patches, 1/2 and 2/2,
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index bc460033a37a8..d5f217427893d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -498,8 +498,8 @@ serdes_mux: mux-controller {
> };
>
> dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
> - compatible = "syscon";
> - reg = <0x000041e0 0x14>;
> + compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
> + reg = <0x41e0 0x14>;
> };
>
> ehrpwm_tbclk: clock-controller@4140 {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node
2023-09-13 14:49 ` Aradhya Bhatia
@ 2023-09-14 9:43 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2023-09-14 9:43 UTC (permalink / raw)
To: Aradhya Bhatia
Cc: Andrew Davis, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nishanth Menon, Vignesh Raghavendra, Tero Kristo, devicetree,
linux-arm-kernel, linux-kernel
On Wed, 13 Sep 2023, Aradhya Bhatia wrote:
>
>
> On 11/09/23 09:25, Andrew Davis wrote:
> > This matches the binding for this register region which fixes a couple
> > DTS check warnings.
> >
> > While here trim the leading 0s from the "reg" definition.
> >
> > Signed-off-by: Andrew Davis <afd@ti.com>
>
> For both the patches, 1/2 and 2/2,
If you want to Ack both patches, you have to Ack both patches.
> Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
>
> > ---
> > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > index bc460033a37a8..d5f217427893d 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > @@ -498,8 +498,8 @@ serdes_mux: mux-controller {
> > };
> >
> > dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
> > - compatible = "syscon";
> > - reg = <0x000041e0 0x14>;
> > + compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
> > + reg = <0x41e0 0x14>;
> > };
> >
> > ehrpwm_tbclk: clock-controller@4140 {
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible
2023-09-11 14:25 [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible Andrew Davis
2023-09-11 14:25 ` [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node Andrew Davis
@ 2023-09-11 15:44 ` Krzysztof Kozlowski
2023-09-14 13:47 ` Aradhya Bhatia
2023-09-20 13:06 ` (subset) " Lee Jones
3 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-11 15:44 UTC (permalink / raw)
To: Andrew Davis, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
Aradhya Bhatia
Cc: devicetree, linux-arm-kernel, linux-kernel
On 11/09/2023 16:25, Andrew Davis wrote:
> Add TI DSS OLDI-IO control registers compatible. This is a region of 5
> 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They
> are used to control the characteristics of the OLDI DATA/CLK IO as needed
> by the DSS display controller node.
>
> [0] https://www.ti.com/lit/pdf/spruid7
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible
2023-09-11 14:25 [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible Andrew Davis
2023-09-11 14:25 ` [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node Andrew Davis
2023-09-11 15:44 ` [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible Krzysztof Kozlowski
@ 2023-09-14 13:47 ` Aradhya Bhatia
2023-09-20 13:06 ` (subset) " Lee Jones
3 siblings, 0 replies; 7+ messages in thread
From: Aradhya Bhatia @ 2023-09-14 13:47 UTC (permalink / raw)
To: Andrew Davis, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Nishanth Menon, Vignesh Raghavendra, Tero Kristo
Cc: devicetree, linux-arm-kernel, linux-kernel
On 11/09/23 09:25, Andrew Davis wrote:
> Add TI DSS OLDI-IO control registers compatible. This is a region of 5
> 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They
> are used to control the characteristics of the OLDI DATA/CLK IO as needed
> by the DSS display controller node.
>
> [0] https://www.ti.com/lit/pdf/spruid7
>
> Signed-off-by: Andrew Davis <afd@ti.com>
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
>
> Changes for v2:
> - Use device specific compatible string
>
> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 8103154bbb529..ab7e26c3469af 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -69,6 +69,7 @@ properties:
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
> - starfive,jh7100-sysmain
> + - ti,am654-dss-oldi-io-ctrl
>
> - const: syscon
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible
2023-09-11 14:25 [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible Andrew Davis
` (2 preceding siblings ...)
2023-09-14 13:47 ` Aradhya Bhatia
@ 2023-09-20 13:06 ` Lee Jones
3 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2023-09-20 13:06 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Aradhya Bhatia,
Andrew Davis
Cc: devicetree, linux-arm-kernel, linux-kernel
On Mon, 11 Sep 2023 09:25:55 -0500, Andrew Davis wrote:
> Add TI DSS OLDI-IO control registers compatible. This is a region of 5
> 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They
> are used to control the characteristics of the OLDI DATA/CLK IO as needed
> by the DSS display controller node.
>
> [0] https://www.ti.com/lit/pdf/spruid7
>
> [...]
Applied, thanks!
[1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible
commit: 9cfffe6a730feea95e7bc827537f5b0a2931171c
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 7+ messages in thread