Re: [PATCH RFT 6/6] arm64: dts: qcom: sc7180: Add support for camss subsys

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/06/2024 11:40, George Chan via B4 Relay wrote:
> From: George Chan <gchan9527@gmail.com>
> 
> Introduce camss subsys support to sc7180 family soc.
> 
> Signed-off-by: George Chan <gchan9527@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 134 +++++++++++++++++++++++++++++++++++
>  1 file changed, 134 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index b5ebf8980325..6ed4caafbe98 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -5,6 +5,7 @@
>   * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved.
>   */
>  
> +#include <dt-bindings/clock/qcom,camcc-sc7180.h>
>  #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
>  #include <dt-bindings/clock/qcom,gcc-sc7180.h>
>  #include <dt-bindings/clock/qcom,gpucc-sc7180.h>
> @@ -3150,6 +3151,139 @@ camnoc_virt: interconnect@ac00000 {
>  			qcom,bcm-voters = <&apps_bcm_voter>;
>  		};
>  
> +		camss: camss@acb3000 {
> +			compatible = "qcom,sc7180-camss";
> +
> +			reg = <0 0x0acb3000 0 0x1000>,
> +				<0 0x0acba000 0 0x1000>,

All this looks misaligned.



Best regards,
Krzysztof