From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED4F5344D8B; Tue, 8 Sep 2026 07:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788850875; cv=none; b=a5e4lAFGHOZqz2Pjnu1x4vnba58tSdnTJis5kzjHGWGOIhTESA8TaN63PoC+F2r5MjfW6pQzkH9PMX7Gul1wTP/v00BE4xzMDOtd6ScNxFzzHnuhlK9PQKRHYW9cdL/tGYMDNqb+n4QCqTV4rfb1OD+UpbcBI3VrjaabZnGLOmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788850875; c=relaxed/simple; bh=HWjbQo5zlhO13u55bbJAZDvviqnOCqacnSO0CJjRVfk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IFANEJL5IwGJ+sFvBHtGWtA7GPyZQ85tgaedpBgXRbvfcynDu50Zhi8NFZaqV3KMoiQvj1Fv2zmlgPw2ZObAn2l/wW8zLQp1fFJiFqe+y1hlzf3ouFV7CUB0bCjfrNndHlYSNu9SgQYenj37WTmdQMGIcpEtQqPiKXwugS5CRPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=O8c9EkGg; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="O8c9EkGg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1788850871; bh=HWjbQo5zlhO13u55bbJAZDvviqnOCqacnSO0CJjRVfk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O8c9EkGgt2iwa6KoH+ylDYXlyStOBc6o5crFO8lp7bwdTe9h/O4zrO9GmvyogrLgi UVbG+XwQrXs7Mzrxq+QzP2s0IFVqObF1EKB4nWlN05yjfE2sEB0KhmqmnitSDSaQ6D 2rD2G5mpmY1pmo+a9mr9HxNTvSI9zvpbjsiFJsHJxM4H689oeQ/+GMjRLBduOILXUd RJ6wZdiZEGEwKzZFmKg4uA/2dEwJhCtvIoaV+bodSCkxdymTWYfyBSDw5GA3wluzpL KT4teytQYunCA+t4Ze/c5kuoRhwftyPhDYWTpjH5XFxnWrgKPagO1DMnBjyBR9fosU PYDsoc3SqXvqw== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 71F6917E03B6; Tue, 08 Sep 2026 09:01:11 +0200 (CEST) Message-ID: <04cf83db-7914-47fa-8d37-baf5e925d86d@collabora.com> Date: Tue, 8 Sep 2026 09:01:10 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] MediaTek mt6572 GCE support To: rva333@protonmail.com, Jassi Brar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Houlong Wei Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20260907-6572-gce-v2-0-412a5b037290@protonmail.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260907-6572-gce-v2-0-412a5b037290@protonmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/7/26 20:03, Roman Vivchar via B4 Relay wrote: > This patch series adds support for the Global Command Engine found in > the mt6572 SoC. > > Notably, the patch 2 introduces legacy ISA format, which is used on > mt6572, 6582 and 6592 SoCs. mt6577 doesn't have the GCE at all and > mt6595 is much more close to 6795/8173. > Patch 3 adds mt6572 platform data and legacy_isa forwarding to the > instruction JIT. > > This format was reverse engineered from the Android HAL and uses 22-bit > offset with 2-bit subsystem ID, unlike the newer 16-bit offset and 8-bit > subsystem ID. > The mt6572 HAL includes workarounds for WFE and EOC instructions, emitting > another WFE as barrier at WFE, and JUMP +8 at EOC. > mt6582 and 6592 HAL dropped WFE barrier, but still have JUMP +8. > > This sounds very much like some kind of software mitigations for hardware > bugs, but during testing on 6572 nothing bad happened so far. These > additional instructions are not included in the patches. > > Note that while GCE can be used for e.g. mt6592 UFOE (which is at > 0x14013000, so outside of the u16 range), currently the driver still uses > u16 for the offset, because I don't have any 6592 device. > > Signed-off-by: Roman Vivchar Series is Reviewed-by: AngeloGioacchino Del Regno > --- > Changes in v2: > - Move dt-bindings to mailbox directory from gce (Krzysztof) > - Clarify that only v2 and v3 GCEs support PA writes > - Link to v1: https://patch.msgid.link/20260728-6572-gce-v1-0-750bba32689e@protonmail.com > > --- > Roman Vivchar (3): > dt-bindings: mailbox: mediatek,gce-mailbox: add mt6572 > soc: mediatek: cmdq-helper: add legacy GCE ISA support > mailbox: mtk-cmdq: add mt6572 support > > .../bindings/mailbox/mediatek,gce-mailbox.yaml | 1 + > drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++++ > drivers/soc/mediatek/mtk-cmdq-helper.c | 57 +++++++++++++++------- > include/dt-bindings/mailbox/mediatek,mt6572-gce.h | 52 ++++++++++++++++++++ > include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + > 5 files changed, 104 insertions(+), 18 deletions(-) > --- > base-commit: 8cd9520d35a6c38db6567e97dd93b1f11f185dc6 > change-id: 20260727-6572-gce-6a571ef4af09 > > Best regards, > -- > Roman Vivchar