public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nandor Han <nandor.han@gehealthcare.com>
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-watchdog@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: watchdog: fsl-imx: document continue in low power mode
Date: Wed, 7 Jan 2026 11:48:42 +0100	[thread overview]
Message-ID: <04d8766f-0f79-409b-9290-3170e99e9750@kernel.org> (raw)
In-Reply-To: <e24ec822-4d13-4136-8fb6-1bc6cbaf8e20@gehealthcare.com>

On 07/01/2026 10:12, Nandor Han wrote:
> 
> On 12/30/25 14:34, Krzysztof Kozlowski wrote:
>> CAUTION: This email originated from outside of GE HealthCare. Only open links or attachments if you trust the sender. Report suspicious emails using Outlook’s “Report” button.
>>
>> On Mon, Dec 29, 2025 at 04:50:00PM +0200, Nandor Han wrote:
>>> Property "fsl,wdt-continue-in-low-power" allows the watchdog to continue
>>> running in low power modes (STOP and DOZE). By default, the watchdog is
>>> suspended in these modes. This property provides the option to keep the
>>> watchdog active during low power states when needed.
>> And why exactly would that be a DT property? If system is sleeping
>> (assuming this is what you meant by low power), no one will pet the dog,
>> thus watchdog makes no sense.
> 
> Thanks for the feedback Krzysztof and Guenter.
> 
> In our case, low-power mode is disabled. However, we have identified that under certain conditions,

If your system has low power mode disabled, then you do not need this
property - you already know that watchdog must continue (or whatever you
want to achieve here).

> specifically during simulated high-load scenarios, the device becomes unresponsive because it enters
> one of these power states.

Device as watchdog? I really do not understand your explanations, but
for sure system load is not relevant to DT property.

> 
>> Otherwise I fail to see how this is a hardware property and we do not
>> accept SW properties (see writing bindings, numerous presentations).
> 
> Our system is based on the i.MX7D CPU and the watchdog peripheral supports the configuration:
> 
> (From i.MX 7Dual Applications Processor Reference Manual, Rev. 1, 01/2018, page: 1174)
> ---
> WDZST
> Watchdog Low Power. Determines the operation of the WDOG during low-power modes. This bit is write
> once-only.
> ---
> Given that our system does not support low-power modes, we intend to enable the watchdog across all power
> states to ensure the device can recover properly under these conditions.

That's not what your property said. Your property said watchdog should
continue in low power modes. So when system enters low power mode, how
the watchdog petting would work?

Now you claim you want to enable it in low power mode but you do not
have low power mode? Does not make sense to me at all.

Best regards,
Krzysztof

  reply	other threads:[~2026-01-07 10:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29 14:49 [PATCH 0/2] watchdog: imx2_wdt: Allow to run in low power mode Nandor Han
2025-12-29 14:49 ` [PATCH 1/2] watchdog: imx2_wdt: Allow to continue " Nandor Han
2025-12-30 12:35   ` Krzysztof Kozlowski
2026-01-07  9:04     ` Nandor Han
2026-01-12 13:08     ` [PATCH v2 0/2] watchdog: imx2_wdt: Allow to run " Nandor Han
2026-01-12 13:08     ` [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document continue " Nandor Han
2026-01-12 13:55       ` Krzysztof Kozlowski
2026-01-14 13:22         ` Nandor Han
2026-01-14 15:58           ` Krzysztof Kozlowski
2026-01-12 13:08     ` [PATCH v2 2/2] watchdog: imx2_wdt: Allow to " Nandor Han
2025-12-31 23:41   ` [PATCH 1/2] " Guenter Roeck
2025-12-29 14:50 ` [PATCH 2/2] dt-bindings: watchdog: fsl-imx: document " Nandor Han
2025-12-30 12:34   ` Krzysztof Kozlowski
2026-01-07  9:12     ` Nandor Han
2026-01-07 10:48       ` Krzysztof Kozlowski [this message]
2026-01-08  7:58         ` Nandor Han
2026-01-12 13:56           ` Krzysztof Kozlowski
2026-01-06 11:51   ` Peng Fan
2026-01-07 10:29     ` Nandor Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04d8766f-0f79-409b-9290-3170e99e9750@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nandor.han@gehealthcare.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox