From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA9F21E0AD for ; Tue, 14 Oct 2025 04:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760416547; cv=none; b=kjLH4EpbCvnNni5LAKFDiirBNU0apKhZQyc69OsUf5XjlIW3UxRC9mnqGkb8mwK9/40E7rkK9IF0jRFllIloPPkbtc2uQ19jsnwapJdPTKss/gPcS8jXkVDZSp6vj3v2/adJIh4NCzK+p8E+OVCYrgvxKYEh/VuwuNVgM3jN520= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760416547; c=relaxed/simple; bh=c+ge+c+ebDs8I/q16pyAoCo5NQkEU4qR0hOyR1QFOLs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dWv5ahU/b6/xPxLLB7U97/KimeruRJdhew3RQEIwWk7w74v/gcO6l8n43+cKJqVltYbJXmxgW5h6y0sOwpPZyDWr9P8B4XwbeTJ/1e78JasczPplDMDqi4iW4+LlcV9geQeklGjRX7UgjpCjlonTSOFY0ynUZzrpJR4jD1lKjs4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cjEjbffy; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cjEjbffy" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-339e71ccf48so6919177a91.3 for ; Mon, 13 Oct 2025 21:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760416545; x=1761021345; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=7JQUsZzfMdSbr2YfhigERer1vfyxYhaVTqb/kc0tYoo=; b=cjEjbffymUOzTsSvVcJLwfIo9vqj3sn2LqtlY+CtmWMhQ6O1ng8uQrc8tm9RbDyobo OS9RY/hj7zHe8DARO9kCQseRJSYSVTj1uIMiitgzmdygnV44jqlzWV7ac/b5d6LqgnvX 0sFNhXSbkeQJyQcNPVskfUama/AYzxvCBD94XP9ceSCEEYEzNS3Dj8JwrYQ5rMKLGR2E kYDyyGsFw1lEIbT41E2ymTOAe9vnacUoe3AtCK8rNmi33a4SKbMprICwhk13kXbts795 BV9Tf7CSB6BowVo3QTyHFCTz+ETYXmUoG998uSOowJ6k8UErHfqLBoWIbiJABPDF1HJ8 9nkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760416545; x=1761021345; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7JQUsZzfMdSbr2YfhigERer1vfyxYhaVTqb/kc0tYoo=; b=wr5qoNw8+tlQe/TflqjIpodsmiov55KUPJtj5pGqWsLiP4/GcYhVbjZJfJzv6BRbgC UjpK8a9QNjftD+/Zt+4kESZVx4voI1cO1Lc4IVSu3BtLk6uTZtaRjXqJENdH1pf6MZVN pWB0mf+AvrfG7/3IOZn4DVO2Bj9XU+X7iLndVV4qimHGQNcPTa19NKU/Kvb4qRz8yWpZ MRvNGOfO2oLEfNLBdiIaPc7IEIlGG4bYg/LAKcgB7zU6TJXUzJgfmMMr1TsX9surSfYE 1SJeBKdZIK6Ef2h+gWlBFXrdpG4e9Y1gjBiaF9bxpEfI1TuuOUNsuI+8jhwmrExX2+TF DnpQ== X-Forwarded-Encrypted: i=1; AJvYcCWEtsbi1NrRaB+ivhNrUeO8b+VVruqgTR5LnWqN7+GPoARtl6l+9DgHxxdo7CnWLEbmHQXMHjsOH4I/@vger.kernel.org X-Gm-Message-State: AOJu0YxaYDO0UbnQ/CHxWmeBNFWYfTS6chCaM3sU9jyUrkcs0LJ/LRHq 97+MFyuITddsvE4Ikt1ta/IvDcncKtd0IH6ZtiKdFDVYZ+k90uzRa/IW X-Gm-Gg: ASbGncvqbUn3JVcRC11uwgEVlX5ikfdAIj7vGYSb9IjVtdedEVHjO+V/nWkQNySMglj DBiLpKh1hzXspz6t8dIi1KFyFbR58hnpYxc6kInQipwnRAI6SnvBdiWz8u5bpY0U7DBWHZvCKFH QTA1TCx+P7FdmkHJQreSJzwFSqKjjI/4BZKkd/nNzgS5MojYUW54Okk384U4wIdquMymcMXA9XW THHApww777kGR+YyhID8cjcwTRRoecuobZDDiVN3rep3dviRQV7oX+gCzjytaUn+X5d0AtqVN0+ 9YOd4PCGhSzIr+CsRZhtbMw9NMQ+a1s4KsI07I5hBSxlzVrS0fi6LjDRVyo4iVmloz8zy06YBq5 Spsq+qJLXymSckJPN26Gu1CawI3emvNhtzzkXmbJ0qrQ4roG8q5f1UQ505vNhWXmECqJnDadikb WwZirb9dYiX9YwyDC4vqPdHc/W X-Google-Smtp-Source: AGHT+IGhDHawC3MkQ4YAyLlsEm3b6W7BIxoNI2FhDwZZJHSH2UowbYagb3+VKa1PMADrFu16wiqV9A== X-Received: by 2002:a17:90b:1d09:b0:330:6f16:c4d8 with SMTP id 98e67ed59e1d1-33b510f9064mr36496258a91.7.1760416545365; Mon, 13 Oct 2025 21:35:45 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7992d09aa20sm13439262b3a.39.2025.10.13.21.35.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Oct 2025 21:35:44 -0700 (PDT) Sender: Guenter Roeck Message-ID: <04dbdd20-69c1-48fe-9bc7-7e9ffaedbe9a@roeck-us.net> Date: Mon, 13 Oct 2025 21:35:43 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts To: Tao Ren Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Andrew Lunn , Tao Ren References: <20250728055618.61616-1-rentao.bupt@gmail.com> <20250728055618.61616-12-rentao.bupt@gmail.com> <79ddc7b9-ef26-4959-9a16-aa4e006eb145@roeck-us.net> <054cf209-61af-4d21-9a3b-d0f6dd24ee3b@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/13/25 21:09, Tao Ren wrote: > Hi Guenter, > > On Mon, Oct 13, 2025 at 08:44:17PM -0700, Guenter Roeck wrote: >> On 10/13/25 20:20, Guenter Roeck wrote: >>> On 10/13/25 18:15, Tao Ren wrote: >>>> Hi Guenter, >>>> >>>> On Mon, Oct 13, 2025 at 05:20:57PM -0700, Guenter Roeck wrote: >>>>> Hi, >>>>> >>>>> On Sun, Jul 27, 2025 at 10:56:13PM -0700, rentao.bupt@gmail.com wrote: >>>>>> From: Tao Ren >>>>>> >>>>>> Include "facebook-fuji-data64.dts" in facebook-fuji dts to avoid >>>>>> duplicated code. >>>>>> >>>>>> Fuji-data64 and Fuji are identical except the BMC flash layout. >>>>>> >>>>>> Signed-off-by: Tao Ren >>>>> >>>>> With this patch in the mainline kernel, the Ethernet interface I use for >>>>> testing does not come online when loading fuji-bmc in qemu. >>>>> >>>>> Reverting this patch fixes the problem. >>>>> >>>>> Looking into this patch, >>>>> >>>>>> - >>>>>> -#include >>>>>> -#include "ast2600-facebook-netbmc-common.dtsi" >>>>>> +#include "aspeed-bmc-facebook-fuji-data64.dts" >>>>> ... >>>>>> -&mac3 { >>>>>> -    status = "okay"; >>>>>> -    phy-mode = "rgmii"; >>>>>> -    phy-handle = <ðphy3>; >>>>>> -    pinctrl-names = "default"; >>>>>> -    pinctrl-0 = <&pinctrl_rgmii4_default>; >>>>>> -}; >>>>> >>>>> I don't see this in aspeed-bmc-facebook-fuji-data64.dts, meaning that >>>>> interface is now disabled. Adding it back in fixes the problem. >>>>> Also, MAC3 is explicitly enabled for fuji-bmc in qemu. >>>>> >>>>> Was the interface disabled on purpose ? >>>>> >>>>> Thanks, >>>>> Guenter >>>> >>>> The mac3 interface was removed in the latest patch (v4) per Andrew Lunn's >>>> feedback, because the rgmii setting is incorrect. >>>> >>>> I was planning to add mac3 back as soon as rgmii support is properly >>>> handled in aspeed mac driver, but kindly let me know if you have other >>>> suggestions. >>>> >>> >>> All I can say is that it worked just fine with the qemu emulation, >>> and that it is broken now. Since it was broken on purpose I guess I'll >>> have to find a workaround or stop testing network interfaces with >>> that emulation entirely. >>> >> >> Ah, I see that mac3 was the only enabled Ethernet interface on that system, >> so you effectively disabled networking on it. >> >> I don't claim to understand the logic (how can anyone continue to use this bmc >> without network interface ?) but I guess it is what it is. I'll stop testing it. >> >> Guenter > > Sorry for the inconvenience.. I have to take a local patch to enable > mac3 in my environment, because as you said, it's not useful without > network interface. > > Meanwhile, I will need to work with ASPEED to enable rgmii delay support > in the ASPEED MAC driver so I can add mac3 back to the dts. If you are > looking for a similar platform for testing, you could consider elbert. > AFAICS aspeed-bmc-facebook-elbert.dtb does not work with the fuji-bmc machine. The console interface or wiring seems to be different. As I said, I'll stop testing the network interface on fuji-bmc. That reduces test coverage, but there is nothing I can do about that. I already made the necessary changes in my testbed, so from my perspective the issue is closed. Guenter