devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Erez <erezgeva2@gmail.com>, Esben Haabendal <esben@geanix.com>
Cc: Erez Geva <erezgeva@nwtime.org>,
	linux-mtd@lists.infradead.org,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <mwalle@kernel.org>,
	linux-kernel@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: mtd: macronix,mx25l12833f: add SPI-NOR chip
Date: Mon, 1 Jul 2024 11:23:08 +0100	[thread overview]
Message-ID: <04f5162d-8a95-45ce-a891-3f711b27a469@linaro.org> (raw)
In-Reply-To: <1d56c3b2-7adf-45b9-a509-956340f3f17b@linaro.org>



On 7/1/24 11:15 AM, Tudor Ambarus wrote:
> 
> 
> On 7/1/24 10:46 AM, Erez wrote:
>> When using mx25l12805d, we do not read SFDP.
>> As it uses the no-SFDP flags.
>> When using mx25l12833f hardware with mx25l12805d driver, it did not
>> try to read the SFDP.
>> Yet mx25l12833f does have SFDP, when I remove the no-SFDP flags, the
>> driver fetch the SFDP.
>>
>> Secondly SFDP does not contain OTP information.
>>
>> mx25l12805d has two OTP regions of 128 KiB and 384 KiB (yes asymmetric).
>> While mx25l12833f has two OTP regions of 512 KiB.
>>
>> How do we handle it?
> 
> You would first try to parse SFDP and initialize the flash based on
> SFDP. If there's no SFDP then you fallback to the flags declared at
> flash declaration. Esben had a try recently, see [1]. I don't know if
> there's any progress in that direction.
> 

And you can then decide which OTP org to use based on whether SFDP is
present or not.

> Also, you haven't mentioned anything about the testing. Do you have the
> flash?
> 
> [1]
> https://lore.kernel.org/linux-mtd/20240603-macronix-mx25l3205d-fixups-v2-0-ff98da26835c@geanix.com/

  reply	other threads:[~2024-07-01 10:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-29 10:39 [PATCH v2 0/4] Add support for SPI-NOR Macronix OTP Erez Geva
2024-06-29 10:39 ` [PATCH v2 1/4] Add generic functions for accessing the SPI-NOR chip Erez Geva
2024-07-01  5:28   ` Tudor Ambarus
2024-06-29 10:39 ` [PATCH v2 2/4] Add support for SPI-NOR Macronix OTP Erez Geva
2024-06-29 10:39 ` [PATCH v2 3/4] dt-bindings: mtd: macronix,mx25l12833f: add SPI-NOR chip Erez Geva
2024-07-01  5:23   ` Tudor Ambarus
     [not found]     ` <CANeKEMOODBNZA6efh0E0Ga_KaVs5Y3WLcUftRhNwYHhnXO=GNw@mail.gmail.com>
2024-07-01  9:46       ` Erez
2024-07-01 10:15         ` Tudor Ambarus
2024-07-01 10:23           ` Tudor Ambarus [this message]
2024-07-01 11:03             ` Erez
2024-07-01 12:53               ` Tudor Ambarus
2024-07-01 16:12                 ` Erez
2024-07-01 10:55           ` Erez
2024-07-01 17:08           ` Erez
2024-07-02  5:00             ` Tudor Ambarus
2024-07-02 23:16               ` Erez
2024-07-03  7:12                 ` Tudor Ambarus
2024-07-03  8:23                   ` Erez
2024-07-10 14:34                     ` Esben Haabendal
2024-07-11 18:57                       ` Erez
2024-07-11 19:57                         ` Michael Walle
2024-07-11 22:09                           ` Erez
2024-07-11 22:13                             ` Michael Walle
2024-07-12  5:13                               ` Erez
2024-07-12  8:20                             ` Esben Haabendal
     [not found]                               ` <CANeKEMPD=nLnor8-oF0t9D8f5D+mLU4XqZ-07avX55BF3TJ8_Q@mail.gmail.com>
2024-08-16 11:29                                 ` Erez
2024-06-29 10:39 ` [PATCH v2 4/4] Add Macronix SPI-NOR mx25l12833f with OTP Erez Geva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04f5162d-8a95-45ce-a891-3f711b27a469@linaro.org \
    --to=tudor.ambarus@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=erezgeva2@gmail.com \
    --cc=erezgeva@nwtime.org \
    --cc=esben@geanix.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).