From: Inki Dae <inki.dae@samsung.com>
To: 'Sylwester Nawrocki' <sylvester.nawrocki@gmail.com>
Cc: 'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
devicetree-discuss@lists.ozlabs.org, patches@linaro.org,
s.nawrocki@samsung.com
Subject: RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D
Date: Thu, 31 Jan 2013 10:30:14 +0900 [thread overview]
Message-ID: <050101cdff52$86df3a70$949daf50$%dae@samsung.com> (raw)
In-Reply-To: <510987B5.6090509@gmail.com>
> -----Original Message-----
> From: Sylwester Nawrocki [mailto:sylvester.nawrocki@gmail.com]
> Sent: Thursday, January 31, 2013 5:51 AM
> To: Inki Dae
> Cc: Sachin Kamat; linux-media@vger.kernel.org; dri-
> devel@lists.freedesktop.org; devicetree-discuss@lists.ozlabs.org;
> patches@linaro.org; s.nawrocki@samsung.com
> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery
> support for G2D
>
> On 01/30/2013 09:50 AM, Inki Dae wrote:
> >> +static const struct of_device_id exynos_g2d_match[] = {
> >> + { .compatible = "samsung,g2d-v41" },
> >
> > not only Exynos5 and also Exyno4 has the g2d gpu and drm-based g2d
> > driver shoud support for all Exynos SoCs. How about using
> > "samsung,exynos5-g2d" instead and adding a new property 'version' to
> > identify ip version more surely? With this, we could know which SoC
> > and its g2d ip version. The version property could have '0x14' or
> > others. And please add descriptions to dt document.
>
> Err no. Are you suggesting using "samsung,exynos5-g2d" compatible string
> for Exynos4 specific IPs ? This would not be correct, and you still can
I assumed the version 'v41' is the ip for Exynos5 SoC. So if this version
means Exynos4 SoC then it should be "samsung,exynos4-g2d".
> match the driver with multiple different revisions of the IP and associate
> any required driver's private data with each corresponding compatible
> property.
>
Right, and for why I prefer to use version property instead of embedded
version string, you can refer to the my comment I replied already to the
"drm/exynos: Get HDMI version from device tree" email thread.
> Perhaps it would make more sense to include the SoCs name in the
> compatible
> string, e.g. "samsung,exynos-g2d-v41", but appending revision of the IP
> seems acceptable to me. The revisions appear to be well documented and
> it's
> more or less clear which one corresponds to which SoC.
>
> --
>
> Thanks,
> Sylwester
next prev parent reply other threads:[~2013-01-31 1:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 9:55 [PATCH 1/2] [media] s5p-g2d: Add DT based discovery support Sachin Kamat
2013-01-25 9:55 ` [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D Sachin Kamat
2013-01-30 8:50 ` Inki Dae
2013-01-30 20:51 ` Sylwester Nawrocki
2013-01-31 1:30 ` Inki Dae [this message]
2013-01-31 23:47 ` Sylwester Nawrocki
2013-02-01 0:15 ` Kukjin Kim
2013-02-01 1:27 ` Inki Dae
2013-02-01 2:26 ` Stephen Warren
2013-02-01 8:33 ` Sachin Kamat
[not found] ` <CAK9yfHxqqumg-oqH_Ku8Zkf8biWVknF91Su0VkWJJXjvWQ3Jhw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-01 10:54 ` Sylwester Nawrocki
2013-02-01 11:12 ` Sachin Kamat
2013-02-01 11:32 ` Inki Dae
2013-02-01 11:40 ` Sachin Kamat
2013-02-01 11:52 ` Inki Dae
2013-02-01 12:58 ` Inki Dae
[not found] ` <E382E0B5-2695-4293-B264-FB4C54FE4F9D-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-04 12:04 ` Sachin Kamat
2013-02-05 3:03 ` Inki Dae
2013-02-05 4:21 ` Kyungmin Park
2013-02-05 7:56 ` 김승우
2013-02-05 8:32 ` Joonyoung Shim
2013-02-05 9:33 ` Sylwester Nawrocki
2013-02-06 4:14 ` Sachin Kamat
2013-02-01 17:35 ` Kukjin Kim
2013-02-01 18:06 ` Kukjin Kim
2013-01-30 21:38 ` [PATCH 1/2] [media] s5p-g2d: Add DT based discovery support Sylwester Nawrocki
2013-01-31 6:29 ` Sachin Kamat
-- strict thread matches above, loose matches on Subject: below --
2013-02-06 5:29 [PATCH v2 " Sachin Kamat
2013-02-06 5:29 ` [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D Sachin Kamat
2013-02-12 13:17 ` Inki Dae
[not found] ` <CAAQKjZNmUVZnDcy3fbWkairnneOK7dooJT2gn=9++tzS=uhhzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-12 17:22 ` [PATCH " Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='050101cdff52$86df3a70$949daf50$%dae@samsung.com' \
--to=inki.dae@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-media@vger.kernel.org \
--cc=patches@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).