From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34040C433E6 for ; Fri, 28 Aug 2020 17:09:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 001E420848 for ; Fri, 28 Aug 2020 17:09:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="CbRzY0Ca" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbgH1RJJ (ORCPT ); Fri, 28 Aug 2020 13:09:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbgH1RJI (ORCPT ); Fri, 28 Aug 2020 13:09:08 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5C0C061264 for ; Fri, 28 Aug 2020 10:09:08 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id i10so739867pgk.1 for ; Fri, 28 Aug 2020 10:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fvMiQMV52wKOEkTpGVSpB7X3SeoYo75JG5xPWkqYPi4=; b=CbRzY0Ca9hAnhGk6G1j7ey29t2XvK1sOOy2Rcmz7dHBdKIc4c3Dvd2fWXjb0Khc7jV uRubCZ0L9ewUygrw1nKYy3PPkXxRQ529G8wAeoJpB1pM5hNBfT7W7h+3T5Tybm73nr/2 5jpFJSM7e+y+Cqvk1sel99tJ0Cq9drgZPRzvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fvMiQMV52wKOEkTpGVSpB7X3SeoYo75JG5xPWkqYPi4=; b=ZV0RADMmlwkwvNejrUEqCn9lu5IFYXlLGrCojIVdBxA1fov+OJmImPO6Q++3ByfHdP 02hYJ8bVbVTpdOHKcSHDP6XaqcufnbyGJgQFC+cB7pridRJJ8kVZzMHqRDgNTeovUZyN Va0/dYngSKS3Zh2R31Dm+8Bki/y12xYnY4WS72YXG5MqlUMTDpASBfHJQ667ztW8x04e S/R9iprG+kG+uH1NWPIep+8ZhI8zr1yB2bVredeq17EeheUpVRRJIdjPLaLCPXHr0GgK 7/7EN4O/EywalNRcCiw04fgWg48VzlJahO0/TZ6KNg9F0Zb7OL2yp6IqN9ji3yaNn4y/ EbwA== X-Gm-Message-State: AOAM532MhlzbNlUYGVzRtGwEX8GrM23L73eNvFmG0/3Rz1PMORIlvwzr tWmuJ848/Hjgbybt2rAV4YDqtQ== X-Google-Smtp-Source: ABdhPJwxPSoNbou2DAEM+RiHTsFFGyTTNhIxXlmLEPikNxiq1HWpxuzAkInPzqbu3rd5ZyqN8tpg5A== X-Received: by 2002:a62:3583:: with SMTP id c125mr2028913pfa.1.1598634547231; Fri, 28 Aug 2020 10:09:07 -0700 (PDT) Received: from [10.136.8.253] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id f18sm25318pgv.84.2020.08.28.10.09.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2020 10:09:06 -0700 (PDT) Subject: Re: [PATCH 08/10] ARM: dts: Cygnus: Fix SP805 clocks To: Andre Przywara , Rob Herring , devicetree@vger.kernel.org Cc: Guenter Roeck , Wim Van Sebroeck , Viresh Kumar , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com References: <20200828130602.42203-1-andre.przywara@arm.com> <20200828130602.42203-9-andre.przywara@arm.com> From: Ray Jui Message-ID: <0525ead5-ae53-e047-97fa-ac245846d605@broadcom.com> Date: Fri, 28 Aug 2020 10:09:04 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200828130602.42203-9-andre.przywara@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8/28/2020 6:06 AM, Andre Przywara wrote: > The SP805 DT binding requires two clocks to be specified, but the > Broadcom Cygnus DT currently only specifies one clock. > > In practice, Linux would pick a clock named "apb_pclk" for the bus > clock, and the Linux and U-Boot SP805 driver would use the first clock > to derive the actual watchdog counter frequency. > > Since currently both are the very same clock, we can just double the > clock reference, and add the correct clock-names, to match the binding. > > Signed-off-by: Andre Przywara > --- > arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi > index 35bdd0969f0a..dacaef2c14ca 100644 > --- a/arch/arm/boot/dts/bcm-cygnus.dtsi > +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi > @@ -234,8 +234,8 @@ > compatible = "arm,sp805" , "arm,primecell"; > reg = <0x18009000 0x1000>; > interrupts = ; > - clocks = <&axi81_clk>; > - clock-names = "apb_pclk"; > + clocks = <&axi81_clk>, <&axi81_clk>; > + clock-names = "wdog_clk", "apb_pclk"; > }; > > gpio_ccm: gpio@1800a000 { > Reviewed-by: Ray Jui