From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 947683AEF35 for ; Fri, 27 Mar 2026 10:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607214; cv=none; b=Tyvb13cbcBoQ05v231lLSgvfourmm49zaOttpn5APCW8uuARukeWPfuQPiIWoVCvZScyLFoRNp0IxgYy3PPD9GJoI5wGKT4VE6MZg5XgsBuPKgSExBH1QJCkDLdGcWPQjAdPvS4Xq4sUyLtHNBlGMJrzUFZo5BT+/JaqY+3zWCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607214; c=relaxed/simple; bh=IWKb5OexAcsxmRLl9pMO7VYfbb0SZHY3SM7T2P1bhJ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R+C3/bG+16PFegJSwwyZVsqMczAmUUmnHbUfrSJSjEbwtc45ivr/NRbExASNdDMR1O4F8DfoGqperyCxlBRrd//w4MxAg0h18+xOtGDhLpuR+CnWOGpIH3Uwt6yEoICqc594HhzoEDCPd5WDY1pKpAkobaBPHmop6XxhWV2Wt7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fnk6Vnm+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bH0x9ZR8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fnk6Vnm+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bH0x9ZR8" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6w3ei1860227 for ; Fri, 27 Mar 2026 10:26:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9oWiAxBv4NcjBqIF5PRiowTv/QQhNKo2rE3bYQ4pF+A=; b=Fnk6Vnm+3iNSneB2 pmonCmrwENxcCA757p3i2inFw8tGTJ+jP6ELaKZzU9YmdOjwrpdvZeo7wLcXfEvr XzPdqD4Am9CKJN31h5cL97SJ5eriXn9rdK3WHL7J0eRQwba3BktcUebmaLqf2EPd g8HoZzaRXLxrFwkvqNP8U3TDgvWqnvp9gKTrXr9gdHBf0UKT85U4/CR+hpxVSsCr tYeU93r5pcU5LiLFd/uFmP/zwM5eG8nxTyLcvEeByZikii6hJ2sIvqsK/iIAozwI adniaWXdpjAvY2Jy5V4quoV+bjjW02BDpNSVhMu+mlb2tCQARCUvcTNdQJxiJTbP +6nMVQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5bxv2m1f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 10:26:51 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89ccf10567dso8401586d6.3 for ; Fri, 27 Mar 2026 03:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774607211; x=1775212011; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9oWiAxBv4NcjBqIF5PRiowTv/QQhNKo2rE3bYQ4pF+A=; b=bH0x9ZR8PZj2oTzCpgrYg+fHz/pSqPvGD/0QVoNhBYILYIp0q83z4nx30bY+j8w4rH Cc1KgFEbsdjrbbHqg03iQ3iaGk5DJWJJqI/JBt95iGMXRGacjSGtKmZSiqEvabynzlsH P/jz3Cdm4rBduZ1tydnMG2OMcZbxa5dklfKjPpQb9K/IOOmrr5ahplcfqxLBFd6EBbbB azTGB38xb4uEw68fUJra1IaM3SiVnu9vlMceaiBMCSZHH49cQ6OyZGmcDoa1RIi03i0T Gb673HgIFRvt3Spbmfk5dHpX/Q8SKmTsZYn9894UAHseEl1ZkQiVNr0RDx6yKDbdhnyR BMSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774607211; x=1775212011; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9oWiAxBv4NcjBqIF5PRiowTv/QQhNKo2rE3bYQ4pF+A=; b=PKgDaZW29bXsoiuARmKhJ1wxYDyW2SW3lHJg8XVH2OX5F66i5DmGmIBINbRBq/ntGe jd4T9VL2VlWg8hJhDlvUzg3uV8jogWyxgj/YO36WAiPgA2HRpBu3qOYiILOnqCyX5zP4 DtJdj3Scv8VtwTKPiPjGas60PNWJt3pgV0LcSHZHuSIeCZW5viPUBAwH9ghHNnnN8OZ1 UGL7oip2X0XcQ2gMxv98pA4GTSC0sPoW0G1NOGwcjtltBlaMO4vOWznMohsXmf5FD7oD EgchJUTwrmexTslrZk4hUI2KBJQs9t0Av6+PZUxZsimnWuqeVdumJ2vcrPGinnQxuUCb Y/hQ== X-Forwarded-Encrypted: i=1; AJvYcCUczpRmvTSwmbn92iUOP+JZwfYpl6Q5f/vV7Rglt0quvRte4oye2RgMIB/cPlyvm2efFglgFqUDdOB2@vger.kernel.org X-Gm-Message-State: AOJu0YzDYdJOhUXnYp6LXqb9SeZnmXnMGZnwwz9eOjZYaSrV0GpWnb90 P9k7R7rj/Tqoc3PwYqnBhfcsZx689X1EXDJNOaGrn2SGiQBGXAKbrpLSOgdmdFQCYSt99/erCXh mdH/uicBWhItUiatNLPs4wsXjbp0hQFYg4fxgIYOrOT43eGw3MaYhAZ8K3BBYOr5u X-Gm-Gg: ATEYQzwy82GwKD4C4M4/YUrMYwzDLELjQ6mkSD03la+TnaG+DAOEFMi8xVz6Tr8nCzn 0/1vMh3RiubsyHSGzcxHCRgEjuSytJ7h0dJwTU/ydIYzK1/IQnziXhln8uu/APvGD5EOxAhU0IM RmPcmjvcJD/CEyB1MkYOOEXintrrBBcEzNcaB0cCXOT2pn2WIeiImq7lHfilU2de2BQ1sZBAPYI gwsOMpvff9hNoqDlW/o4fVs/ldNpWF1EH0UvEe5uhpfx9gsHYCb7NQuJAJaALTyMe4mz3vIe2dh Z/xFqqHhEkU8fMOdHZaHs3McyfzWN6zO0LoKSBVVYqCnogYwFV94p5fEaqhLaOqnKybaNwFaEjj QoQplZY4/v3yjPsZRF+65o3Xxvl1P2682v5oF7QMHZVqat4Szu5n5OFHIEdMWL45dta7z6fCVXR Lneog= X-Received: by 2002:a05:622a:1982:b0:509:1b76:e9ba with SMTP id d75a77b69052e-50ba3994ea3mr17776481cf.8.1774607210726; Fri, 27 Mar 2026 03:26:50 -0700 (PDT) X-Received: by 2002:a05:622a:1982:b0:509:1b76:e9ba with SMTP id d75a77b69052e-50ba3994ea3mr17776131cf.8.1774607210167; Fri, 27 Mar 2026 03:26:50 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b202663c6sm240584466b.23.2026.03.27.03.26.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 03:26:49 -0700 (PDT) Message-ID: <0526dbcf-0f4a-4ff7-ba43-705448c989e8@oss.qualcomm.com> Date: Fri, 27 Mar 2026 11:26:46 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 2/7] dt-bindings: media: qcom,x1e80100-camss: Add support for combo-mode endpoints To: Bryan O'Donoghue , Vladimir Zapolskiy , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski , Christopher Obbard References: <20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-0-5b93415be6dd@linaro.org> <20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-2-5b93415be6dd@linaro.org> <17ab70a4-1ab8-4384-8537-44dbfe31889a@linaro.org> <540c2a97-00ec-4358-855a-b238aab53860@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <540c2a97-00ec-4358-855a-b238aab53860@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=A99h/qWG c=1 sm=1 tr=0 ts=69c65b6b cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=0v9nonJskobKTEXhuRwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: _1kex8EPlKBp-1C-1M9rjMsoNodbqmJs X-Proofpoint-GUID: _1kex8EPlKBp-1C-1M9rjMsoNodbqmJs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA3NSBTYWx0ZWRfX09SmqxrAtfYD ZC7PXpEMrD6hii7tcLxEoQzCdmWNFJ6pUwBAcptctvuJmR/VJ6RCrHXSqB3Pxu0h3NRnnTd+cDH I5LRIRhZtqfC5ZQ6lJecENHxKilFa/oL5oKqdGIkepnyOk6BntedEr5ciP4rbIZMrg5Rp9KCprl UGac5MtMIojQZeBRGFYbuHvky8FdfW4ikA5+fS0z9sN6sNxLkHll6UJYJ/NMrzw75ipr9zIav+a 8mL+wv86P8K717tDK9VeB3FgsNcnlRxcful1BxSDAdEzjTYTHLAeEHd5ZPu0NnI3td5u38vAlcd dAGVwA85AAm+c+dO4dEOBJliPt8P6no4mdTeCvM69WVoupM3BeMoo0RZDYspNTWsKfZOnjFaU25 0MH3YOu9+wfhazHk696BvimpOJv90YsZ5nwqtfW4ypNYrz42Qnl9QTPREtN9JoDtkmgF7y1vP0M gATcaAYwTzOMVEnLFkw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270075 On 3/26/26 3:08 AM, Bryan O'Donoghue wrote: > On 26/03/2026 01:51, Vladimir Zapolskiy wrote: >> On 3/26/26 03:28, Bryan O'Donoghue wrote: >>> Qualcomm CSI2 PHYs support a mode where two sensors may be attached to the >>> one CSIPHY. >>> >>> When we have one endpoint we may have >>> - DPHY 1, 2 or 4 data lanes + 1 clock lane >>> - CPHY 3 wire data lane >>> >>> When we have two endpoints this indicates the special fixed combo-mode. >>> - DPHY endpoint0 => 2+1 and endpoint1 => 1+1 data-lane/clock-lane combination. >>> >>> Reviewed-by: Christopher Obbard >>> Signed-off-by: Bryan O'Donoghue >>> --- [...] >>> +              bus-type: >>> +                const: 4 # Combo is D-PHY specific >>> + >> >> It's unclear why both 'bus-type' and 'phys' cell argument are needed >> at the same time, they are equal and thus one of two is redundant. >> > > bus-type lives on the CAMSS controller endpoint. It tells the V4L2 fwnode parser (v4l2_fwnode_endpoint_parse) how to interpret the endpoint properties — DPHY has data-lanes + clock-lanes, CPHY has trios. > > PHY phandle cell lives on the phys reference. It tells the PHY driver which electrical mode to configure But we don't need that second part, no? If it's strictly required that we keep the bus-type in DT, we already store that information once and can translate MEDIA_BUS_TYPE_CSI2_DPHY to PHY_MODE_MIPI_CSI or whatever before we power on the PHY (which we wouldn't do without first setting up other bits of the topology anyway) Konrad