Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65

[Vignesh Raghavendra <vigneshr@ti.com>]

On 31/08/22 10:35, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [220830 07:09]:
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> @@ -271,6 +271,138 @@ main_spi4: spi@2140000 {
>>  		#size-cells = <0>;
>>  	};
>>  
>> +	main_timer0: timer@2400000 {
>> +		compatible = "ti,am654-timer";
>> +		reg = <0x00 0x2400000 0x00 0x400>;
>> +		interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&k3_clks 23 0>;
>> +		clock-names = "fck";
>> +		assigned-clocks = <&k3_clks 23 0>;
>> +		assigned-clock-parents = <&k3_clks 23 1>;
>> +		ti,timer-pwm;
>> +	};
> 
> Oops the power-domains are missing for the timers. This should
> have power-domains = <&k3_pds 23 TI_SCI_PD_EXCLUSIVE>.
> 
> Can we tag all the timers with TI_SCI_PD_EXCLUSIVE, or do some
> always need to be TI_SCI_PD_SHARED?
> 

Please tag TI_SCI_PD_EXCLUSIVE for main domain timers. Individual boards
can override based on need basis

-- 
Regards
Vignesh