From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7908EB64DC for ; Tue, 11 Jul 2023 09:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232023AbjGKJ7Z (ORCPT ); Tue, 11 Jul 2023 05:59:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232137AbjGKJ7H (ORCPT ); Tue, 11 Jul 2023 05:59:07 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79AF9172E for ; Tue, 11 Jul 2023 02:57:38 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-991f956fb5aso634882766b.0 for ; Tue, 11 Jul 2023 02:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689069456; x=1691661456; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pWka34Gw82nr/cFSWzXWk0N4X377rpeIdKu/sRdqI3w=; b=E1S24mQwOCmHBBy4DRz23P23yqDhq4uQrWy8X+IpX1HgWvgkeoZGsrBB2i8xYNJHHM xlurGXGi5+SjP8v3G/hEvZe0C+M+f66ThjHsH4P+pX9c/3M8Fci/ZNBvMek7IyA4HTOJ MPMOXUu1nCzSWFL+cFpgZFhVMg5sftDhY0mCg11oRSjMlEK4wlQlhOuHPb19J12NtjU5 1kVvl4of2Hl53/F0KLI/r7bxd+x3RAmU3+D3Adf/AvZZxcXSaFO1plhemYa++54LP1bY XjL25qbN6DhcAUZ0tjQ4rFYbrxcgRjqztmb0BYCyRB/+W7zvT4v7c25HXZYcgzLcsrTL Sp+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689069456; x=1691661456; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pWka34Gw82nr/cFSWzXWk0N4X377rpeIdKu/sRdqI3w=; b=l3JziapEQwY3+iaSNvUH0TmbjGVQeI/crz3DoGCBWhH10GkN7cWCHldxkrIuBR1fIT 27jIaN1tkb/0Ajl2BAKdNoY43MnyGaOTFvnbAxEFdramSkdyePT82BUVJf9CGNhp5FWC 3A5caEeIPb09DhYE7w8hx35huizDNAaFbM6JAsU0IIPfnJuXlQIK6qa1LZSpVb42FVUf /UcjuzjQB+OrF2WMFqfPnN3Pa/MlX01G4ocvqyjrek1D84JUxd7qpoUdlZW4c3kibdDk Mj5J0GXLsMUQIIaOBU9W6VNRH90Wtq3Mav7EidRgIdlAAnDuK69t6hA7w/OCCM8B7qMO T31A== X-Gm-Message-State: ABy/qLaDjWZzp5uRNt9YM+iTzLkfPvY4tm8TvMkmakWYqN5oN+zurElF PnEx6bRQ5Z4YvLYpJHiDRbozOg== X-Google-Smtp-Source: APBJJlGrct9CF3NdgozgtT88PsYl+iuo0rr8yPDlmRTaY5g+azPTKOqK7kxmUAT7dEu+Y7gYM6DatA== X-Received: by 2002:a17:907:12ce:b0:983:cb6c:8aa3 with SMTP id vp14-20020a17090712ce00b00983cb6c8aa3mr13056484ejb.59.1689069456550; Tue, 11 Jul 2023 02:57:36 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id s10-20020a170906354a00b00982be08a9besm926457eja.172.2023.07.11.02.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 02:57:36 -0700 (PDT) Message-ID: <05554015-6b08-c194-9d27-af5539e3ce46@linaro.org> Date: Tue, 11 Jul 2023 11:57:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/6] arm64: dts: qcom: ipq9574: Add support for nsscc node Content-Language: en-US To: Devi Priya , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, richardcochran@gmail.com, arnd@arndb.de, geert+renesas@glider.be, neil.armstrong@linaro.org, nfraprado@collabora.com, rafal@milecki.pl, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Cc: quic_saahtoma@quicinc.com References: <20230711093529.18355-1-quic_devipriy@quicinc.com> <20230711093529.18355-6-quic_devipriy@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230711093529.18355-6-quic_devipriy@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/07/2023 11:35, Devi Priya wrote: > Add a node for the nss clock controller found on ipq9574 based devices. > > Signed-off-by: Devi Priya > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 44 +++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index f120c7c52351..257ce4a5bfd5 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -10,6 +10,8 @@ > #include > #include > #include > +#include > +#include > > / { > interrupt-parent = <&intc>; > @@ -17,6 +19,30 @@ > #size-cells = <2>; > > clocks { > + bias_pll_cc_clk: bias-pll-cc-clk { > + compatible = "fixed-clock"; > + clock-frequency = <1200000000>; > + #clock-cells = <0>; > + }; > + > + bias_pll_nss_noc_clk: bias-pll-nss-noc-clk { > + compatible = "fixed-clock"; > + clock-frequency = <461500000>; > + #clock-cells = <0>; > + }; > + > + bias_pll_ubi_nc_clk: bias-pll-ubi-nc-clk { > + compatible = "fixed-clock"; > + clock-frequency = <353000000>; > + #clock-cells = <0>; > + }; > + > + gcc_gpll0_out_aux: gcc-gpll0-out-aux { > + compatible = "fixed-clock"; > + clock-frequency = <800000000>; > + #clock-cells = <0>; > + }; Isn't this GCC clock? > + > sleep_clk: sleep-clk { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -620,6 +646,24 @@ > status = "disabled"; > }; > }; > + > + nsscc: nsscc@39b00000 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof