From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A5DC433F5 for ; Tue, 19 Apr 2022 21:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358093AbiDSVzR (ORCPT ); Tue, 19 Apr 2022 17:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350809AbiDSVzP (ORCPT ); Tue, 19 Apr 2022 17:55:15 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B9C93DA70 for ; Tue, 19 Apr 2022 14:52:31 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id e21so24187281wrc.8 for ; Tue, 19 Apr 2022 14:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gLtsy0Dnuy7K64jx69SEe4Ua3fGdznWFY7ZIp1FollY=; b=a1pyI/puus6HMt+kjyQ296US4qUURUnDNuM49j+V3zIzyZgYOrSPhxuWD9eNMq6zGn aIjCQcxVItq5SGudKBWrtuqVbLQAUJfOWzL+reIpEY+HjBX9GHHB7maqXWD7MdnwHCqh yaskzmQjsVWDhJ0a2br2CFPLcO51kTG/WQ5T+krXhoprDM3KVOlojTSlbu/zfsYKloHZ slgWnf0L7d/vsg8gT+ofSLzWIjnQQxyQ7HWWFE9Krfzxp0HNpvHusuk01pvg8QahInGM n42I6PDCtJOgMHDD9IqkaNTdCQAz/Yy8qFjZdTy7XYaDpqyhNeN9YsNM95GD76qhmgHx GR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gLtsy0Dnuy7K64jx69SEe4Ua3fGdznWFY7ZIp1FollY=; b=nkv7zbLzHpt68uLUi1xchJITDDweCl/toowDlXZknv+LuiD+RDzngGxyhT5aU6lSHE /w/f6CgZDM7FrFZVvHCOAE2o5YC5621g1SZsKZ84CwgHdmakb42sOJ+JOFUCON0EGiK8 y9CnsrFi6mHgyv6cc1XA3C8TnNciUND2qVtyh6Wi4z+2HyHBgXqiZnJ4lUtHcCKlRSyg PCeyec2ZsjPa5IW8YM4CfOqwyZ3gnX5w2B122pQB4lZ9t4IfKO0CnXTpusiqHubfVYDl uVoGj1Mb38SdUChlKJ7ma34rEdCkh2r58R+IkD8KtiCkGtsLtcn2KF/GL5GQmu4mLaoe wnhw== X-Gm-Message-State: AOAM530m5blKBABGOh5dXAFvnjnfk5EE07TDb7KEJoxM+how5mbcNrkt CSbBksmUaTdu3JpfXIeexjPGjA== X-Google-Smtp-Source: ABdhPJx/qcsME7Oq5vBEl72U8V+HeEjZ4gzko2awR0eo0KSBp2FUHwrayljTehUN4irkITsOZWewHg== X-Received: by 2002:a5d:6b82:0:b0:207:b4c9:2293 with SMTP id n2-20020a5d6b82000000b00207b4c92293mr13209532wrx.33.1650405149890; Tue, 19 Apr 2022 14:52:29 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id g13-20020a5d64ed000000b0020a9e488976sm4841589wri.25.2022.04.19.14.52.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 14:52:29 -0700 (PDT) Message-ID: <0574491c-1b32-a6c8-d8ad-7c4c5c4662b2@linaro.org> Date: Tue, 19 Apr 2022 22:52:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v1 3/4] arm64: dts: Add aqp8039-t2 board Content-Language: en-US To: Bjorn Andersson Cc: agross@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, shawn.guo@linaro.org, jun.nie@linaro.org, benl@squareup.com, jwillcox@squareup.com, jgates@squareup.com, mchen@squareup.com, zac@squareup.com, Leo Yan References: <20220419010903.3109514-1-bryan.odonoghue@linaro.org> <20220419010903.3109514-4-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/04/2022 22:39, Bjorn Andersson wrote: > On Mon 18 Apr 20:09 CDT 2022, Bryan O'Donoghue wrote: >> + wcnss_pin_antennae: wcnss_pin_antennae { >> + pinmux { >> + pins = "gpio1", "gpio2"; >> + }; >> + pinconf { >> + pins = "gpio1", "gpio2"; >> + function = PMIC_GPIO_FUNC_NORMAL; >> + output-high; > > Could it be that gpio1 and 2 control two power supplies for two antennas > and that this should have been represented as regulators instead? Those are the GPIOs responsible for switching between antenna Off-topic: When doing antenna diversity switching the WCNSS firmware owns these two GPIOs. The rough algorithm is for (i = 0; i < 2; i++) - Switch GPIO[i] - Send a probe to the WiFi AP - Wait for a response - Measure the RSSI Then decide which antenna has the better signal strength. So actually WCNSS owns these two pins. I have an evil plan to implement ieee80211_ops::get_antenna() in the future. In theory all we have to do is read the GPIOs inside the callback. >> + pm8916_l6: l6 { >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; /* copy from v3.10 */ > > Can you do better than "copy from v3.10"? Sure. I'll put in a comment why. --- bod