From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 026F1C433DF for ; Thu, 15 Oct 2020 06:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F0C122210 for ; Thu, 15 Oct 2020 06:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729172AbgJOGwj (ORCPT ); Thu, 15 Oct 2020 02:52:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729131AbgJOGwj (ORCPT ); Thu, 15 Oct 2020 02:52:39 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81A8DC061755 for ; Wed, 14 Oct 2020 23:52:39 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id C53391F45850 Message-ID: <0578a7e56430da42daee95aabc05850da3dcc294.camel@collabora.com> Subject: Re: [PATCH v2 3/3] mfd: google,cros-ec: add missing properties From: Ricardo =?ISO-8859-1?Q?Ca=F1uelo?= To: Tzung-Bi Shih Cc: Rob Herring , Collabora Kernel ML , Enric Balletbo i Serra , Benson Leung , Guenter Roeck , Simon Glass , Doug Anderson , devicetree@vger.kernel.org, Dmitry Torokhov , Cheng-Yi Chiang Date: Thu, 15 Oct 2020 08:52:29 +0200 In-Reply-To: References: <20201008102825.3812-1-ricardo.canuelo@collabora.com> <20201008102825.3812-4-ricardo.canuelo@collabora.com> <20201008183818.GB2395464@bogus> <20201009054819.di4dlfljadsfs6cw@rcn-XPS-13-9360> <20201013064609.udss7hbdek2of4sw@rcn-XPS-13-9360> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2020-10-14 at 10:18 +0800, Tzung-Bi Shih wrote: > The intermediate layer (i.e. codecs { ... }) breaks current code as > you already discussed about that in previous threads: > - of_platform_populate only creates immediate child devices. > - the codec driver expects its parent is EC node. Thanks for your input, I'll try to address these issues in the drivers in v3. Cheers, Ricardo