From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1873AE19B for ; Fri, 7 Aug 2026 20:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786134505; cv=none; b=aimmF+rWAgSA/9R0kT6v9bDQTblVdCg7+TrrNoqyWAG2NKvD9uNIg1vVs2B3L0eOOYF4ORH/1VKG9gL91wA1igi3jmGM18zgLwCB1PKpQLfzbXbETSqW8btbDvNaMFnmh3iWrjI+wZf9bSQw5QTuQruiNFC7wcmui90hFQ6mo7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786134505; c=relaxed/simple; bh=z8tuJw/2y8S5S/LwSCjwic0uw+zShe6nspN74OWp+SE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L4YJ1U7SNdDQIh+peE38q1/inzWJaSyTLYt9LdVfL7w53TCZGb8mi55+I8zGvw5b5VZopolnPPJFOk1D1t4TCpLiKiCIlecl15ui1q8G5hnOEml84zwwRdqLH3kZDt3sFOXLTnah/QPeHChpaYYjdiiz7dPV7xkEHfJnlRJsqS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=HvT0/Nk8; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="HvT0/Nk8" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-4af81963f35so1492952b6e.0 for ; Fri, 07 Aug 2026 13:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786134501; x=1786739301; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B17hNVNz2mTOaFga/vR1xcCKv5sx22R9oiNPrYVzrPE=; b=HvT0/Nk8xWh8uq+ao/VJfilHQ+7r0pbEoOm4TCU88nntbKlfO1E4H9iWk1+NWLAJPO xZktLCbpOvIH5a+Jq/MUho+6Wp1eyKO58XwZk/SyETt4XF+l0QJaar+ISrNX9EoEiu5y lacDKagntI8crWAEaATyuCXKV1zFWgv0Onp0QN5PvPeQsB1ttDryrV1eMib06yfNHUAz SwHcp1TdzSMpC0SW1e7DCe4hqWljzfMjDVtzfAGojLiuqRvKBEbGFtB+a0zW1HdePHft 1jcoyYDxm+G97Kbn/oquZWfUgQOfCnESjZhjFatNh0gPKb6ZHHV2fRbHgf+gyU1P1x/r zJDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786134501; x=1786739301; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B17hNVNz2mTOaFga/vR1xcCKv5sx22R9oiNPrYVzrPE=; b=HxCGAvNe8ot3de6tjm8x6q24AH0KcFPNzjk1/idc1HMabVya4icSqO5tTYNUYgaplb 15wG0pOWeGKmdwIXrzYfG8stuaXszZOMoI4ZKdKo8jVWcHHiVn9PQJr/CnPRai/p3MNH PVPUGuwANkPlquyGcxViqX3bhGTh0C5R2NJplDC5ebs+3amis5YI1FtPgg0TEW2shSp1 dBHpJJ3v5SKRsENYxEhYC1OhGwdBEItFQrl0ILB+B+BqR6vgKF81jDI1GN14YumO3AbZ 16/PMpMXIJINCwEWmDsk6DIp+iYlZ6gvc5MnxL+vmwdZv10OYsWwaY6tYZEXUGh6n9Tx pAZQ== X-Forwarded-Encrypted: i=1; AHgh+Rq5oQi55WLvo4KBREpdDL+q54pZaJyvbKNfYzA8Ov4nEb1En0rIOhMQe84S/P28Bbgq3/KfRkYoWaef@vger.kernel.org X-Gm-Message-State: AOJu0YzaQ+niB7XP2m/OLK2yIUsxvDq1TKXrgqU+6QVPFee2hzaxRCYi yCF5sd3uFUhk5RONRtmKb2cZtuut//zKEXBbnxOIRAvfak5kYf0dFvoa33TmCQfiY6U= X-Gm-Gg: AR+sD12gdyMQ9mNqmiP+T4xGIZc01Tp31du10IAUMz1xvcXahT1ZKPHINOzdLCuy771 Zr4OX5K++nTN2Yk42ixjg1hPSYurRsHwpP26dR13cFIciYjy6+ZRsPUUWbJuEmK2KfIi1wSyRIb eZXbgryTXQsrXS5RDuW2XW5je8kxyV74e1UWI6el7YwMBBU7MvHAV8uZllEamJyhJ4rIfF4lSft MB8U4mVFDEKukH3LbUtrr7bN7w71qbX8SsB5q3k1P9hBL6oM7BwJRSeiGz3zeE+iNiYQbufnVXx lL7RGUQqVhEyLQhb/r3ajazus3mQ51swM2C69gzWnV61ZS6duKmVDLehNYwjAo4UNb/E7ElPK5X PekmguMzebC/xn/qrharOPEeUh67CxmZ/HYNdWQZfmYQ7aOWqPNehya6gFxQL5kQ/hGp6tPXQF8 bYIzcIudUJ2iry7rjsoLKhkKd0tVQt7qaV5VCebDGyAXuJp/jBubQEcUnaz64Su0iSimkthfnGl RFfwxDhWSqQ7pSbESXsTIA+ubdB6BK9i9lg X-Received: by 2002:a05:6808:3194:b0:497:e7e2:756e with SMTP id 5614622812f47-4afae0690f5mr13069938b6e.13.1786134501439; Fri, 07 Aug 2026 13:28:21 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:b714:88c:313d:dee2? ([2600:8803:e7e4:500:b714:88c:313d:dee2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b1af5e4fc0sm435744b6e.11.2026.08.07.13.28.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 13:28:20 -0700 (PDT) Message-ID: <05956c9e-7852-424b-bd40-fa61f699151d@baylibre.com> Date: Fri, 7 Aug 2026 15:28:20 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] iio: adc: Add support for Texas Instruments ADS112C04 To: Kyle Hsieh , Krzysztof Kozlowski Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260805-ti-ads112c04-driver-v3-0-49f436829e01@gmail.com> <4841976e-ca36-45c0-a853-75c647bf8a79@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/5/26 2:44 AM, Kyle Hsieh wrote: > On Wed, Aug 5, 2026 at 2:46 PM Krzysztof Kozlowski wrote: >> >> On 05/08/2026 08:43, Krzysztof Kozlowski wrote: >>> On 05/08/2026 07:38, Kyle Hsieh wrote: >>>> This patch series introduces support for the Texas Instruments ADS112C04 >>>> Analog-to-Digital Converters. >>>> >>>> The ADS112C04 (16-bit) is precision, low-power, delta-sigma ADCs with >>>> an I2C interface. They feature a flexible input multiplexer supporting >>>> single-ended and differential measurements, a programmable gain amplifier, >>>> and an internal voltage reference. >>>> >>>> Note: While this chip shares similarities with the ADS112C14 (currently >>>> being upstreamed by David Lechner), the register maps and feature sets >>>> are sufficiently different to warrant a separate driver. However, the >>>> DT bindings and channel parsing logic have been aligned with the >>>> ADS112C14 conventions. >>>> >>>> This initial submission provides a minimal feature set (single-shot >>>> conversions and basic DRDY interrupt) covering current use cases. >>>> >>>> Signed-off-by: Kyle Hsieh >>>> --- >>>> Changes in v3: >>>> - dt-bindings: iio: adc: ti,ads112c04: >>>> - Resolved dt_binding_check errors by removing redundant $ref for >>>> standard unit suffixes and fixing YAML array syntax. >>> Yet you still decided NOT TO TEST it before sending. >> >> Although after further looking this could be using properties added in >> iio tree, thus bot's report about failure. >> >> Well, if that is the case, that's unfortunate because if previous >> versions were not tested by you, this one cannot be tested by the bot, >> thus I look at this one as also untested. >> >> Best regards, >> Krzysztof > Hi Krzysztof, > > Thank you for the review and for following up in your second email. > I would like to clarify that I did indeed test v3 locally with `make > dt_binding_check` > before submitting, and it passed without any warnings on my end. > > As you accurately pointed out in your follow-up, the CI bot failure > appears to be > a cross-tree dependency issue. I apologize for not explicitly noting > this IIO tree > dependency in the cover letter to prevent the bot's confusion. > > I have also just updated my local `dtschema` tool directly from the > devicetree-org > GitHub master branch, and running `make dt_binding_check` on my tree still > completes silently with zero errors. > > Best regards, > Kyle Hsieh I already replied to the bot message before I saw this thread. The problem is the base-commit: in the cover letter. I'm guessing that you did `b4 prep --edit-deps` at some point and pointed it to something other than the actual tree you are working from. That would explain why the test passes locally but not with the bot.