From: Markuss Broks <markuss.broks@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: regulator: Add bindings for Silicon Mitus SM5703 regulators
Date: Tue, 19 Apr 2022 20:45:07 +0300 [thread overview]
Message-ID: <0599e7ac-bd06-8d56-b510-0f27f4cc6790@gmail.com> (raw)
In-Reply-To: <Yl7pqgjza/ZfajyM@sirena.org.uk>
Hi Mark,
On 4/19/22 19:56, Mark Brown wrote:
> On Tue, Apr 19, 2022 at 07:00:54PM +0300, Markuss Broks wrote:
>
>> +description: |
>> + SM5703 regulators node should be a sub node of the SM5703 MFD node. See SM5703 MFD
>> + bindings at Documentation/devicetree/bindings/mfd/siliconmitus,sm5703.yaml
> Why is this a separate binding with a compatible rather than just being
> part of the main MFD binding? Alternatively, why aren't the regulators
> described individually in the DT (ie, one node/compatible per regulator)?
I took an example from the rohm,bd71847-pmic.yaml MFD binding, they have
regulators at a separate regulators { } node, with a separate dt-binding
for it. I'm not sure what should I do, I'd be more than happy to follow
a better example if you can show me it.
- Markuss
next prev parent reply other threads:[~2022-04-19 17:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 16:00 [PATCH v4 0/4] Add support for Silicon Mitus SM5703 MFD Markuss Broks
2022-04-19 16:00 ` [PATCH v4 1/4] dt-bindings: regulator: Add bindings for Silicon Mitus SM5703 regulators Markuss Broks
2022-04-19 16:56 ` Mark Brown
2022-04-19 17:45 ` Markuss Broks [this message]
2022-04-19 19:12 ` Mark Brown
2022-04-22 18:37 ` Matti Vaittinen
2022-04-22 18:33 ` Matti Vaittinen
2022-04-19 16:00 ` [PATCH v4 2/4] dt-bindings: mfd: Add bindings for Silicon Mitus SM5703 MFD Markuss Broks
2022-04-20 1:19 ` Rob Herring
2022-04-19 16:00 ` [PATCH v4 3/4] mfd: sm5703: Add support for " Markuss Broks
2022-04-19 16:00 ` [PATCH v4 4/4] regulator: sm5703-regulator: Add regulators " Markuss Broks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0599e7ac-bd06-8d56-b510-0f27f4cc6790@gmail.com \
--to=markuss.broks@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).