From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B35931662EF; Fri, 7 Feb 2025 08:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.34.216 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738917108; cv=none; b=rPVUt8hTFP6sGHL58hAh1FihbxvhpxSFcXQPPeNTHPMACjgOUvZ96e3RmthwQiLZ+lzS+lMN+F93XSvDNFw6I7gLynBRiuHhZTfrGv137zb/5dDqJ+9Hlri9B3g5ciIwVxKyNj7K7z3sga6l8FvExhWF0okEwh3/1S5sHcW/dLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738917108; c=relaxed/simple; bh=3T+4D4OZYxnH92h9beC7wrRjiY+wNoBy2B/wrWJ5ihk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XjA59UvIbn8rS8093AGUHKU/r1fjdRqbhJWygC+IqSPxWbS41tPM8RC739UCaRdNnEOhssXXNWJxtXKa6YqbiloKhHwid0ao+a9ybJ41RIVKKkhC6kR8j6jxqWh4STgOPNZBSa69WaIkp1nN7TzpDURLTbFH7GEPwRSOdumrVfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.starfivetech.com; spf=none smtp.mailfrom=linux.starfivetech.com; arc=none smtp.client-ip=54.206.34.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.starfivetech.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.starfivetech.com X-QQ-mid: bizesmtpsz4t1738917093t6p35lw X-QQ-Originating-IP: F3vYl0ctFhV2QVNdxoiZ+gl2R3+YyxEuwE/J1iVBRD0= Received: from [192.168.60.235] ( [183.27.97.113]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 07 Feb 2025 16:31:30 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 5179800746963532279 Message-ID: <05B9953079BA21AF+fffef577-a880-4ed6-a71b-14ec82aeea97@linux.starfivetech.com> Date: Fri, 7 Feb 2025 16:31:29 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] riscv: dts: starfive: jh7110-common: replace syscrg clock assignments To: E Shattow , Emil Renner Berthing , Conor Dooley , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Hal Feng References: <20250203013730.269558-1-e@freeshell.de> <20250203013730.269558-2-e@freeshell.de> <981a3f30-c646-423a-a2dd-e19fef5c69e5@freeshell.de> Content-Language: en-US From: Hal Feng In-Reply-To: <981a3f30-c646-423a-a2dd-e19fef5c69e5@freeshell.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:linux.starfivetech.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-QQ-XMAILINFO: N7uEtCzC8wDSU5GgdvpIOvHsIwEu6cw1nHKJAHljI71wJqFJ4DB1Nzd1 1DgeW5Y0jB3YypTHFBHcwRVXmhLXjoeu69SKmNFwjvfc46Vt2DV0lG2J5ZNSXPm0L6aWaJ1 HKVwzb2F8ZNf3W+bYE1yfFGdAGiRoB8W3155WkELds2X1rcPIja1xIAEou8LTHodFDK+XNu vcGqNHfi36mRb9o6QoXu6Q10d+VgNemyT8+xvtpy7TS2zXyHqHhkopgVWuHhT01GxFFhpN8 0CRhg4wPKH6PFlxeyyMf1dMWExbtMO3amwko2kCz9OTKlM7D1HdBE1169gjzhWt7F7HZd4S w9kCiK8G+sHEsgUYpnlQmW0dYYPqYTTFRVrOse3B6VRZd3NqjTUSsif/qqDT6dGB7FFKTMV CDkUnvIBMQMu9ECJTgbMogTTz/9gk4BoFOa//c2cQz6KV3oFRytO9Nl4mo0cI87UhyaJS8X pi1vIAp5i8ZBl9CZnCuff/EwJNl9qg2UptfPF8i9b7qdjcn2E7/I1tULt+r76aZC/fkEwro bQygAsm9KK38uzB3GCngRsqG9Wpa52YKF/HQQS2o8T5pFTA3oTmRZugTfwtUjJPgnJQFd0p 6sYMWOp6Or9e31le44fndCSKNPrx6sP/MOXTKG2Y8BRczb1f5WJ0p2d+OcwgVxMSm2TxYPS SYWwEalk2vkoUm311gT0/amZa9JOsReFMbCnB8BoiavOQxdG6GWSVXhlJr31M70cBX2T6zv 5Ur1XePOctuFByD38ms+W2mmRpULp2xNJ9DgM/9dGclZkoq0luSUbiFDO2aClMHQ5cVgIJb WA9nUbSDxvkHxZcMZYS3MGaXAYjgUtRwIOx2N7R+4mYSA0hf9Qdv8lCsOfH2HVS2fRn03AX tTIdTt3Bxyl8faHqluZxT4HmR3T2r7WS8r59nHXLTNqDtsSOFPXqav4zn77Li4s+FZEiRiD DVj7S34QgWra6TShSpP5s3Rn6m6pnG0sc4CM= X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= X-QQ-RECHKSPAM: 0 On 2/5/2025 8:52 PM, E Shattow wrote: > > > On 2/5/25 02:16, Emil Renner Berthing wrote: >> E Shattow wrote: >>> Replace syscrg assignments of clocks, clock parents, and rates with >>> default settings for compatibility with downstream boot loader SPL >>> secondary program loader. >>> >>> Signed-off-by: E Shattow >>> --- >>> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 11 ++++++++--- >>> 1 file changed, 8 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi >>> index 48fb5091b817..a5661b677687 100644 >>> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi >>> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi >>> @@ -359,9 +359,14 @@ spi_dev0: spi@0 { >>> }; >>> >>> &syscrg { >>> - assigned-clocks = <&syscrg JH7110_SYSCLK_CPU_CORE>, >>> - <&pllclk JH7110_PLLCLK_PLL0_OUT>; >>> - assigned-clock-rates = <500000000>, <1500000000>; >>> + assigned-clocks = <&syscrg JH7110_SYSCLK_CPU_ROOT>, >>> + <&syscrg JH7110_SYSCLK_BUS_ROOT>, >>> + <&syscrg JH7110_SYSCLK_PERH_ROOT>, >>> + <&syscrg JH7110_SYSCLK_QSPI_REF>; >>> + assigned-clock-parents = <&pllclk JH7110_PLLCLK_PLL0_OUT>, >>> + <&pllclk JH7110_PLLCLK_PLL2_OUT>, >>> + <&pllclk JH7110_PLLCLK_PLL2_OUT>, >>> + <&syscrg JH7110_SYSCLK_QSPI_REF_SRC>; >> >> I think Conor asked about this too, but you still don't write why it's ok to >> drop the 500MHz and 1,5GHz assignments to the cpu-core and pll0 clocks >> respectively. You should add this to the commit message itself. >> >> /Emil > > Is this a remedy for a bug in the JH7110 CPU? I'm not clear why tweaking > the frequencies and increasing core voltage was ever needed. > > This goes back to series "clk: starfive: jh7110-sys: Fix lower rate of > CPUfreq by setting PLL0 rate to 1.5GHz" [1]. > > Since [1] I have had problems with several passively cooled Milk-V Mars > CM Lite systems powering off due to thermal limits. My experience then > is that the specialized 1.5GHz operation is not appropriate for all > JH7110 CPU board layouts and applications. > > Hal says I failed to get these assignments in Linux to work in U-Boot > because U-Boot doesn't have driver support to increase CPU voltage, and > Hal offering to add this to a driver in U-Boot... but that's the wrong > way around in my opinion, unless there's some defect in the JH7110 CPU > that it won't run reliably with hardware defaults. > > 1: > https://lore.kernel.org/all/20240603020607.25122-1-xingyu.wu@starfivetech.com/ > > What is the correct thing to do here? > > -E > > From mboxrd@z Thu Jan 1 00:00:00 1970 > Return-Path: > X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on > aws-us-west-2-korg-lkml-1.web.codeaurora.org > Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) > (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) > (No client certificate requested) > by smtp.lore.kernel.org (Postfix) with ESMTPS id B9A24C02192 > for ; Wed, 5 Feb 2025 13:10:59 +0000 (UTC) > DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; > d=lists.infradead.org; s=bombadil.20210309; h=Sender: > Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: > List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: > Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: > Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: > List-Owner; bh=GY86gaXkDRjEBAUNvogHkHuyO230wjLSabDM8v7zKQQ=; b=Un7uhhDTAT8/9N > FxyCZTIeuEf9Tz2EWguoSASPTIRzVsA8OD+zansoq7n0Em+ejnESLoVicWRdNflaSCojelA6mxlZr > 79fy10oRgiIKMOAb1fwJcsq+rGF8jSdXwi0a2zKjGYb4u4ZNy/uLBiIynsSH/VCYysTKQK6p7wAiC > 7RYsK3WfvbZKMTBmH2vKxA7ERtfZGfNAJqRjHzBM06+ZfEDf9V2UQ3pGUdGPoTZYkQoS8smFEx47Z > U3KclAiQD6NRzOmPD/VXwUGXQEpLonSaLk7kbAdo3cWww6Wyou3w4XqxHQpym6FyLsKAWWSk7d4vx > ZbYQckPNKc65NmLst1TA==; > Received: from localhost ([::1] helo=bombadil.infradead.org) > by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) > id 1tffB9-00000003Lk1-2ly8; > Wed, 05 Feb 2025 13:10:55 +0000 > Received: from freeshell.de ([2a01:4f8:231:482b::2]) > by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) > id 1tfetw-00000003I2R-42Et > for linux-riscv@lists.infradead.org; > Wed, 05 Feb 2025 12:53:10 +0000 > Received: from [192.168.2.35] (unknown [98.97.25.24]) > (Authenticated sender: e) > by freeshell.de (Postfix) with ESMTPSA id 7ADA8B4C01E1; > Wed, 5 Feb 2025 13:53:01 +0100 (CET) > Message-ID: <981a3f30-c646-423a-a2dd-e19fef5c69e5@freeshell.de> > Date: Wed, 5 Feb 2025 04:52:59 -0800 > MIME-Version: 1.0 > User-Agent: Mozilla Thunderbird > Subject: Re: [PATCH v2 1/5] riscv: dts: starfive: jh7110-common: replace > syscrg clock assignments > To: Emil Renner Berthing , > Conor Dooley , Emil Renner Berthing , > Rob Herring , Krzysztof Kozlowski , > Paul Walmsley , Palmer Dabbelt > , Albert Ou > Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, > linux-riscv@lists.infradead.org > References: <20250203013730.269558-1-e@freeshell.de> > <20250203013730.269558-2-e@freeshell.de> > > Content-Language: en-US > From: E Shattow > In-Reply-To: > X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 > X-CRM114-CacheID: sfid-20250205_045309_156119_468548BF > X-CRM114-Status: GOOD ( 16.14 ) > X-BeenThere: linux-riscv@lists.infradead.org > X-Mailman-Version: 2.1.34 > Precedence: list > List-Id: > List-Unsubscribe: , > > List-Archive: > List-Post: > List-Help: > List-Subscribe: , > > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > Sender: "linux-riscv" > Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > > > > On 2/5/25 02:16, Emil Renner Berthing wrote: >> E Shattow wrote: >>> Replace syscrg assignments of clocks, clock parents, and rates with >>> default settings for compatibility with downstream boot loader SPL >>> secondary program loader. >>> >>> Signed-off-by: E Shattow >>> --- >>> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 11 ++++++++--- >>> 1 file changed, 8 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi >>> index 48fb5091b817..a5661b677687 100644 >>> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi >>> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi >>> @@ -359,9 +359,14 @@ spi_dev0: spi@0 { >>> }; >>> >>> &syscrg { >>> - assigned-clocks = <&syscrg JH7110_SYSCLK_CPU_CORE>, >>> - <&pllclk JH7110_PLLCLK_PLL0_OUT>; >>> - assigned-clock-rates = <500000000>, <1500000000>; >>> + assigned-clocks = <&syscrg JH7110_SYSCLK_CPU_ROOT>, >>> + <&syscrg JH7110_SYSCLK_BUS_ROOT>, >>> + <&syscrg JH7110_SYSCLK_PERH_ROOT>, >>> + <&syscrg JH7110_SYSCLK_QSPI_REF>; >>> + assigned-clock-parents = <&pllclk JH7110_PLLCLK_PLL0_OUT>, >>> + <&pllclk JH7110_PLLCLK_PLL2_OUT>, >>> + <&pllclk JH7110_PLLCLK_PLL2_OUT>, >>> + <&syscrg JH7110_SYSCLK_QSPI_REF_SRC>; >> >> I think Conor asked about this too, but you still don't write why it's ok to >> drop the 500MHz and 1,5GHz assignments to the cpu-core and pll0 clocks >> respectively. You should add this to the commit message itself. >> >> /Emil > > Is this a remedy for a bug in the JH7110 CPU? I'm not clear why tweaking > the frequencies and increasing core voltage was ever needed. > > This goes back to series "clk: starfive: jh7110-sys: Fix lower rate of > CPUfreq by setting PLL0 rate to 1.5GHz" [1]. > > Since [1] I have had problems with several passively cooled Milk-V Mars > CM Lite systems powering off due to thermal limits. My experience then > is that the specialized 1.5GHz operation is not appropriate for all > JH7110 CPU board layouts and applications. > > Hal says I failed to get these assignments in Linux to work in U-Boot > because U-Boot doesn't have driver support to increase CPU voltage, and > Hal offering to add this to a driver in U-Boot... but that's the wrong > way around in my opinion, unless there's some defect in the JH7110 CPU > that it won't run reliably with hardware defaults. > > 1: > https://lore.kernel.org/all/20240603020607.25122-1-xingyu.wu@starfivetech.com/ > > What is the correct thing to do here? Please see my reply in https://lore.kernel.org/all/ZQ2PR01MB130736F5C893337606FD6937E6F1A@ZQ2PR01MB1307.CHNPR01.prod.partner.outlook.cn/ Thanks. Best regards, Hal