From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver Date: Thu, 10 Oct 2013 13:18:05 +0900 Message-ID: <05c701cec56f$b79eea50$26dcbef0$%dae@samsung.com> References: <1380670860-17621-1-git-send-email-seanpaul@chromium.org> <1380670860-17621-4-git-send-email-seanpaul@chromium.org> <20131009182905.GY21581@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20131009182905.GY21581@sirena.org.uk> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org To: 'Mark Brown' Cc: 'Olof Johansson' , 'Sean Paul' , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, 'DRI mailing list' , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: Thursday, October 10, 2013 3:29 AM > To: Inki Dae > Cc: Olof Johansson; Sean Paul; devicetree@vger.kernel.org; linux-samsung- > soc@vger.kernel.org; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; DRI mailing list; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver > > On Fri, Oct 04, 2013 at 11:05:48AM +0900, Inki Dae wrote: > > 2013/10/4 Olof Johansson : > > > > "If PD_N is LOW, then the device is in Deep power-down completely, > > > even if supply rail is ON; for the device to be able to operate, the > > > PD_N pin must be HIGH." > > > I still think the pin could be replaced with a regulator. But > > lvds-bridge node has "powerdown-gpio" property - it say this board > > will use gpio pin - specific to board. So it seems no problem. > > No, don't model things that aren't regulators as regulators - it's just > confusing from a usability standpoint and causes breakage when the pins > don't behave like regulators. It seems that there was your missing point. That _is not_ what I mentioned. I mean that other boards can use a regulator instead of gpio pin.