From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B2333D996 for ; Mon, 12 Feb 2024 17:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707758790; cv=none; b=h/wpl9iyH+GBFKA8tfkNc/x9LaLF73iofOYGV/kCBH3rBJjfu0XCFRzoouylDCNB4ytROl+RudLQ1Rn+azq2Mg1wHmQyHPaB1eB/xP75eXrxl/PBDhtK0/KWIyuqnIFlh45n4dmW2H2CrOEGwomsusvIuLa+V1X/BlEP7y3+Z+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707758790; c=relaxed/simple; bh=zBRQ2L3YSqKZCX6QoGtUVNjjBN/0fESkwN55NmvyBrc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=epT0fQkmoe2Mr/UURJsdlDjN0N6InbUbulUIAbu+xTUMID+fPykCl82s45CWZVGl0BJ95Fgj9nPE7wwFQeRHgbES8BjnjyID4IZwz7EXoz7BFGcgk9Jo8CcF0mi44qJtvJiDmf7foOTDMPZN2y1Wg4BCWhEFC2cWArilH98y5zk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KW9yYVlc; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KW9yYVlc" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-410c1ebf5e4so11537325e9.2 for ; Mon, 12 Feb 2024 09:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707758786; x=1708363586; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=5qTYop8QJp36+jtIGblbi7k/WDzukfUFb0T7VOK2lcU=; b=KW9yYVlciCU4sAD+p+Z47yEQ0QmsOldtnq2DpSRyY9pkV40IfmEBmy/L5u7agnP0PN Qi1ja4Tzwdp1AwS+PgkQmYYDpRc9uZd5KH2BWFdpahjWwukZTrWplT7Np/pYQ5X4KJ1g ynflWJ0/mM7qRSN9fDIwFVfblvIZxkj03XaUHd8HJtVSGhZ5m6jbUmxrO7RMTI1A8pTX ZGghWeRij179YUd7GW1RexbSd6U7/45Y18zFr9vZbF0l2nPYp8hGkV+PAJisc7jFRUG9 7AQ3yf3NaAu9WIEIjmOCd7FhalMVfmoYzrwCG6vw42Mv35auRZLNiTkGNIPvcrE8FNeD Sx3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707758786; x=1708363586; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5qTYop8QJp36+jtIGblbi7k/WDzukfUFb0T7VOK2lcU=; b=ZNHM3on5hwpu2OB60jurtHABa5hjBs66TxuAOPxgdE2BNtP9bbAEn+QX0WP8M1s9YK Tf8YZx+s40NOY8WADGGNu4czP0tSsIJQsaBKh5C2B0rD124I7Ry8y3FZdfBGEME3ZKPq 9vTqvv+hFaSJbN8wCby0laFCfYJlAmN68hdZKSCAM2hi1T5cAvgvzjKYapenAon6ynwR axVtA13LDb37671B9js0LzOQanQ+0mLZ4KaCTeVti2uD2KMMsdfF0oOBBX96CY0GtRWo Acza1uulE5tDdiEZjlTQfZiUZyyzJo6j/eh0iwe901AIf3FCySOPtcJP2WLhfIAAZTYV ixGQ== X-Gm-Message-State: AOJu0YwmFXd0TnMn4juSY+uyd+n03OxeRFzWyN2QLlo/eMxB1DqOhIrv EDQOzT0raJAhbg2U6gnYEFABJpIsA4KRqCgKxzZkoibZ3EoJwUN3fqbgaICus9w= X-Google-Smtp-Source: AGHT+IFg0NVPNFM5l0rC92f6lBNwnb2GJ+wbCi1upTvwnBA2YxnXHVtsK9iZZAP6HRMoOFnFFV1yyw== X-Received: by 2002:adf:f709:0:b0:33b:640c:a7d2 with SMTP id r9-20020adff709000000b0033b640ca7d2mr5390324wrp.24.1707758786633; Mon, 12 Feb 2024 09:26:26 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVvbjdJf7EnWY5OfIXA6faJ7b6TknrkFAmcqH3a7ILu+FC3dnOIKbNffShVRrSxo8p0tugA49APOWnKdJ/7kBIkftUwKsdYD7+LsGYVwgkE/ook6qdruSBqCLj1NuccDmWDxfAWMHycjuYDHy9+saDE3rkq5Z1xywcvXr0hbJqnqe/yPhTgrIGz/BhG8guIp5q14zoAAstrUiTE86b01ZxOKheJGdFn/aGzWZmvB/P/zQQchFi1Tppl/FE+Hg4oyTWNb9usojjxcHl0aMbtJJbR3c+quFStM2LGX511kwhKIk9IGyXQsq/gyhv62POQJmfd/nZjLNNLWVgwmfp9q3U9NLaneyNxFLFYpLCQhy/u2wY7g2MdxPY3iTMlMa5IGKSqaPVjP5nFHZhlVCfYpA/5XXaan/Hqpj/G1Kn+0d0xCMb96mrc0AY8gRTVsEipnawPS9mhnU/moFved7XtHZincYEZHw4OFmibBljFK/8IjJdN4PZoSNTlIYXqGHeoHpJjvvn9F7SSSW3cy0KsKa/z+K6L+lVlUpF6RWDvikyTTqzTwUHEPIovkBjZVT7rSdH5/bNFeVfA/j3OvuVGVC8xZUq74iZw/koEyH+Rlx6SfNLbHQe/LVfhVqwcFzG3Wf0C5wrQULE6hzgflcICX+YPheKN/HHcdGlXIQdWW1EqSXMMKdccdBlI5dkKcwPxnpPhDndstWTqgffNL27Kjz9yPEYrL1blUOOkYHQAcpFSYtEd02ZPmWTXQWE8evboKOZ3EgLPufzr9eoO2K0c2bds0Jfhsk4NuH75n1YHpg9BYvRt3j72DZFjAA== Received: from ?IPV6:2a01:e0a:982:cbb0:fcee:f026:296d:135f? ([2a01:e0a:982:cbb0:fcee:f026:296d:135f]) by smtp.gmail.com with ESMTPSA id k14-20020a056000004e00b0033afc81fc00sm7266685wrx.41.2024.02.12.09.26.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 09:26:26 -0800 (PST) Message-ID: <05e6f92c-388c-4bc6-a4cd-e9d981166d1c@linaro.org> Date: Mon, 12 Feb 2024 18:26:24 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 7/7] arm64: dts: qcom: Add SM8550 Xperia 1 V Content-Language: en-US, fr To: Konrad Dybcio , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ricardo Rivera-Matos , Bjorn Andersson , Abel Vesa , Sai Prakash Ranjan , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: Marijn Suijten , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org References: <20240210-topic-1v-v1-0-fda0db38e29b@linaro.org> <20240210-topic-1v-v1-7-fda0db38e29b@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20240210-topic-1v-v1-7-fda0db38e29b@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/02/2024 14:10, Konrad Dybcio wrote: > Add support for Sony Xperia 1 V, a.k.a PDX234. This device is a part > of the SoMC SM8550 Yodo platform. > > This commit brings support for: > * Remoteprocs (sans modem for now) > * Flash LED (the notification LED is gone :((((() > * SD Card > * USB (*including SuperSpeed*) + PMIC_GLINK (it's funky, requires a replug > with an cable flip sometimes..) > * Most regulators > * Part of I2C-connected peripherals (notably no touch due to a > driver bug) > * PCIe0 (PCIe1 is unused) > > Do note display via simplefb is not supported, as the display is blanked > upon exiting XBL. > > To create a working boot image, you need to run: > cat arch/arm64/boot/Image.gz arch/arm64/boot/dts/qcom/sm8550-sony-xperia-\ > yodo-pdx234.dtb > .Image.gz-dtb > > mkbootimg \ > --kernel .Image.gz-dtb \ > --ramdisk some_initrd.img \ > --pagesize 4096 \ > --base 0x0 \ > --kernel_offset 0x8000 \ > --ramdisk_offset 0x1000000 \ > --tags_offset 0x100 \ > --cmdline "SOME_CMDLINE" \ > --dtb_offset 0x1f00000 \ > --header_version 2 \ > -o boot.img-sony-xperia-pdx234 > > Then, you need to flash it on the device and get rid of all the > vendor_boot/dtbo mess: > > // You have to either pull vbmeta{"","_system"} from > // /dev/block/bootdevice/by-name/ or build one as a part of AOSP build process > fastboot --disable-verity --disable-verification flash vbmeta vbmeta.img > fastboot --disable-verity --disable-verification flash vbmeta_system \ > vbmeta_system.img > > fastboot flash boot boot.img-sony-xperia-pdx234 > fastboot erase vendor_boot > fastboot erase recovery > fastboot flash dtbo emptydtbo.img > fastboot erase init_boot // ? I don't remember if it's necessary, sorry > fastboot continue > > Where emptydtbo.img is a tiny file that consists of 2 bytes (all zeroes), doing > a "fastboot erase" won't cut it, the bootloader will go crazy and things will > fall apart when it tries to overlay random bytes from an empty partition onto a > perfectly good appended DTB. DTBc check reports: arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dtb: pcie-1-phy-aux-clk: 'clock-frequency' is a required property from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# So you'll probably need: &pcie_1_phy_aux_clk { status = "disabled"; }; > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 779 +++++++++++++++++++++ > 2 files changed, 780 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index f7c5662213e4..9bbea531660d 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -237,6 +237,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm8550-sony-xperia-yodo-pdx234.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb > diff --git a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > new file mode 100644 > index 000000000000..85e0d3d66e16 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > @@ -0,0 +1,779 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Linaro Limited > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include > +#include > +#include > +#include "sm8550.dtsi" > +#include "pm8010.dtsi" > +#include "pm8550.dtsi" > +#include "pm8550b.dtsi" > +#define PMK8550VE_SID 5 > +#include "pm8550ve.dtsi" > +#include "pm8550vs.dtsi" > +#include "pmk8550.dtsi" > +/* TODO: Only one SID of PMR735D seems accessible? */ What's reported by the cpuinfo pmic array ? With the pcie thing fixed: Reviewed-by: Neil Armstrong