From: Stefan Agner <stefan@agner.ch>
To: Meng Yi <meng.yi@nxp.com>
Cc: jianwei.wang.chn@gmail.com, devicetree@vger.kernel.org,
emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, shawnguo@kernel.org,
alexander.stein@systec-electronic.com
Subject: Re: [PATCH v2 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding
Date: Wed, 13 Jul 2016 23:36:23 -0700 [thread overview]
Message-ID: <05f71a73e885c0c64029ff8f8bb23d87@agner.ch> (raw)
In-Reply-To: <1467188278-10978-2-git-send-email-meng.yi@nxp.com>
On 2016-06-29 01:17, Meng Yi wrote:
> add of_graph dt binding for panel, and "fsl,panel" property
Nit: "binding" typically describes the requirement, the specification
and hence is under Documentation/devicetree/bindings/.
What you add here is the dt nodes according to the bindings...
Hence I would say something like
Add of_graph dt nodes to describe the panel and remove the "fsl,panel"
property.
> is deprecated
>
> Signed-off-by: Meng Yi <meng.yi@nxp.com>
> ---
> Changes in V2:
> -dropp the unit address of port
> ---
> arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ls1021a-twr.dts
> b/arch/arm/boot/dts/ls1021a-twr.dts
> index 75ecaed..cbd92c8 100644
> --- a/arch/arm/boot/dts/ls1021a-twr.dts
> +++ b/arch/arm/boot/dts/ls1021a-twr.dts
> @@ -108,12 +108,22 @@
>
> panel: panel {
> compatible = "nec,nl4827hc19-05b";
Nit: We typically add a new line before adding a subnode.
> + port {
> + panel_out: endpoint {
> + remote-endpoint = <&dcu_out>;
> + };
> + };
> };
> };
>
> &dcu {
> - fsl,panel = <&panel>;
> status = "okay";
> +
> + port: port {
Same as in bindings, port does not need a label too.
> + dcu_out: endpoint {
> + remote-endpoint = <&panel_out>;
> + };
> + };
> };
>
> &dspi1 {
There is still a patch for vf-colibri-eval-v3.dtsi missing which does
the same.
--
Stefan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-14 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 8:17 [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Meng Yi
[not found] ` <1467188278-10978-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
2016-06-29 8:17 ` [PATCH v2 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding Meng Yi
2016-07-14 6:36 ` Stefan Agner [this message]
2016-07-01 1:37 ` [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Rob Herring
2016-07-14 6:30 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f71a73e885c0c64029ff8f8bb23d87@agner.ch \
--to=stefan@agner.ch \
--cc=alexander.stein@systec-electronic.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jianwei.wang.chn@gmail.com \
--cc=meng.yi@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).