From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C4AC2D0D1 for ; Mon, 30 Dec 2019 05:00:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C02DC20663 for ; Mon, 30 Dec 2019 05:00:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="WoaLppb7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbfL3FAY (ORCPT ); Mon, 30 Dec 2019 00:00:24 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:36890 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbfL3FAY (ORCPT ); Mon, 30 Dec 2019 00:00:24 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1577682023; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=bq9GBo1exy5H5niGUOPp3ceZeVp8DhBy57oRJt6GY54=; b=WoaLppb7fiR1d09b7Cbw5cFizvq0j/YwirkaHTWFM4Y+ukxP4BRcOCMjhz30PjIawTEyVtVn jwS1lYB+7J7/fNDn33I4D97nrOeiXJSMnaVOH7QNOzogeJEdcC0VwDnMP782Eo7xKVLQa2Ok njehf1rd2qjxALhBKIKL5bmQ2a4= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e09845e.7f4dc71b9f80-smtp-out-n02; Mon, 30 Dec 2019 05:00:14 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1EE03C433A2; Mon, 30 Dec 2019 05:00:14 +0000 (UTC) Received: from Pillair (unknown [183.83.68.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id 53172C433CB; Mon, 30 Dec 2019 05:00:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 53172C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Bjorn Andersson'" Cc: , , , References: <1577181575-25788-1-git-send-email-pillair@codeaurora.org> <20191229031416.GK3755841@builder> In-Reply-To: <20191229031416.GK3755841@builder> Subject: RE: [PATCH v3] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Mon, 30 Dec 2019 10:29:56 +0530 Message-ID: <061701d5bece$044b6cd0$0ce24670$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIRwFJlApFoTZl1gTtUmtjwT7YanQH7LU55p0pBkhA= Content-Language: en-us Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bjorn, Thanks for the comments. I will post an updated patchset v4 after the patch bringing-in "qcom,msa-fixed-perm" is merged/approved. I will address all the comments together. Thanks, Rakesh Pillai. > -----Original Message----- > From: Bjorn Andersson > Sent: Sunday, December 29, 2019 8:44 AM > To: Rakesh Pillai > Cc: devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v3] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node > > On Tue 24 Dec 01:59 PST 2019, Rakesh Pillai wrote: > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai > > --- > > This change is dependent on the below set of changes > > arm64: dts: sc7180: Add qupv3_0 and qupv3_1 > (https://lore.kernel.org/patchwork/patch/1150367/) > > It would be clearer if you linked to the series instead, but it doesn't > matter at this point, this is merged already. > > What doesn't seem to be merged is the addition of the > qcom,msa_fixed_perm property, so I presume I need to hold off on merging > this? > > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 > ++++++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 189254f..b2ca143f 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -248,6 +248,11 @@ > > status = "okay"; > > }; > > > > +&wifi { > > + status = "okay"; > > + qcom,msa_fixed_perm; > > As remarked by Rob, properties should be using - instead of _. > > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qup_i2c2_default { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 666e9b9..7efb97f 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -42,6 +42,12 @@ > > compatible = "qcom,cmd-db"; > > no-map; > > }; > > + > > + wlan_fw_mem: memory@93900000 { > > + compatible = "removed-dma-pool"; > > + no-map; > > + reg = <0 0x93900000 0 0x200000>; > > + }; > > }; > > > > cpus { > > @@ -1119,6 +1125,28 @@ > > #clock-cells = <1>; > > }; > > }; > > + > > + wifi: wifi@18800000 { > > + compatible = "qcom,wcn3990-wifi"; > > + reg = <0 0x18800000 0 0x800000>; > > + reg-names = "membase"; > > + iommus = <&apps_smmu 0xC0 0x1>; > > Lowercase 'c' please. > > Regards, > Bjorn > > > + interrupts = > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */>, > > + */>; > > + memory-region = <&wlan_fw_mem>; > > + status = "disabled"; > > + }; > > }; > > > > timer { > > -- > > 2.7.4 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel