From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jyan Chou [周芷安]" <jyanchou@realtek.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"jh80.chung@samsung.com" <jh80.chung@samsung.com>,
"riteshh@codeaurora.org" <riteshh@codeaurora.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>
Cc: "conor+dt@kernel.org" <conor+dt@kernel.org>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"briannorris@chromium.org" <briannorris@chromium.org>,
"doug@schmorgal.com" <doug@schmorgal.com>,
"tonyhuang.sunplus@gmail.com" <tonyhuang.sunplus@gmail.com>,
"abel.vesa@linaro.org" <abel.vesa@linaro.org>,
"william.qiu@starfivetech.com" <william.qiu@starfivetech.com>
Subject: Re: [PATCH V6][4/4] dt-bindings: mmc: Add dt-bindings for realtek mmc driver
Date: Mon, 20 Nov 2023 13:41:28 +0100 [thread overview]
Message-ID: <062c2a9f-238c-440e-86d3-8a2ed3b4b7c1@linaro.org> (raw)
In-Reply-To: <f471b7e2d1b54e05a92d70f6479305e2@realtek.com>
On 20/11/2023 11:50, Jyan Chou [周芷安] wrote:
>>> +
>>> + resets:
>>> + maxItems: 1
>>> +
>>> + reset-names:
>>> + const: reset
>
>> And here you describe the item? The only place when it is not needed?
>> Drop entierly.
>
> does it means we need to drop it? But we need this to determine whether to
>
> setup a reset control or not, if we didn't add it in our bindings, check patch will
>
> show error. Did I misunderstand your meaning? Thanks.
Please drop entirely reset-names. From the bindings, so obviously from
the DTS and driver code as well. I do not ask to drop resets, just
reset-names.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-20 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 8:20 [PATCH V6][0/4] Add DesignWare Mobile mmc driver Jyan Chou
2023-11-09 8:20 ` [PATCH V6][1/4] mmc: solve DMA boundary limitation of CQHCI driver Jyan Chou
2023-11-09 15:22 ` kernel test robot
2023-11-10 9:16 ` kernel test robot
2023-11-09 8:20 ` [PATCH V6][2/4] mmc: Add Synopsys DesignWare mmc cmdq host driver Jyan Chou
2023-11-09 8:20 ` [PATCH V6][3/4] mmc: Add dw mobile mmc cmdq rtk driver Jyan Chou
2023-11-09 8:20 ` [PATCH V6][4/4] dt-bindings: mmc: Add dt-bindings for realtek mmc driver Jyan Chou
2023-11-09 16:22 ` Krzysztof Kozlowski
2023-11-20 10:50 ` Jyan Chou [周芷安]
2023-11-20 12:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=062c2a9f-238c-440e-86d3-8a2ed3b4b7c1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=asutoshd@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=doug@schmorgal.com \
--cc=jh80.chung@samsung.com \
--cc=jyanchou@realtek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=riteshh@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=tonyhuang.sunplus@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).