From: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: shikra: Correct QCE node configuration
Date: Tue, 8 Sep 2026 10:51:18 +0800 [thread overview]
Message-ID: <062ea84e-07ee-41be-82a5-20600693a219@oss.qualcomm.com> (raw)
In-Reply-To: <20260907-b4-shikra_crypto_changse-v6-2-0676f61894b3@oss.qualcomm.com>
On 9/7/2026 8:03 PM, Kuldeep Singh wrote:
> Shikra is derived from Agatti and uses the same QCE integration.
> Update the QCE node to match the underlying hardware implementation by
> adjusting the fallback compatible and related properties, including
> clocks and clock-names.
>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra.dtsi | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index c1f06f692f66..30c7cabc058a 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -1075,10 +1075,12 @@ cryptobam: dma-controller@1b04000 {
> qcom,controlled-remotely;
> num-channels = <16>;
> qcom,num-ees = <4>;
> + clocks = <&rpmcc RPM_SMD_CE1_CLK>;
> + clock-names = "bam_clk";
> };
>
> crypto: crypto@1b3a000 {
> - compatible = "qcom,shikra-qce", "qcom,sm8150-qce", "qcom,qce";
> + compatible = "qcom,shikra-qce", "qcom,ipq4019-qce", "qcom,qce";
> reg = <0x0 0x01b3a000 0x0 0x6000>;
> dmas = <&cryptobam 4>, <&cryptobam 5>;
> dma-names = "rx", "tx";
> @@ -1089,9 +1091,8 @@ crypto: crypto@1b3a000 {
> <&apps_smmu 0x96 0x0011>,
> <&apps_smmu 0x98 0x0001>,
> <&apps_smmu 0x9f 0x0>;
> - interconnects = <&system_noc MASTER_CRYPTO_CORE0 0
> - &mc_virt SLAVE_EBI_CH0 0>;
> - interconnect-names = "memory";
> + clocks = <&rpmcc RPM_SMD_CE1_CLK>;
> + clock-names = "core";
> };
>
> qfprom: efuse@1b44000 {
Tested-by: Wanjia Zhang <wenjia.zhang@oss.qualcomm.com> #on shikra device
next prev parent reply other threads:[~2026-09-08 2:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:03 [PATCH v6 0/2] Shikra: Support for QCE Kuldeep Singh
2026-09-07 12:03 ` [PATCH v6 1/2] dt-bindings: crypto: Adjust Shikra compatible hierarchy Kuldeep Singh
2026-09-07 13:45 ` Bartosz Golaszewski
2026-09-07 12:03 ` [PATCH v6 2/2] arm64: dts: qcom: shikra: Correct QCE node configuration Kuldeep Singh
2026-09-07 13:31 ` Abel Vesa
2026-09-07 13:39 ` Kuldeep Singh
2026-09-07 13:44 ` Bartosz Golaszewski
2026-09-07 13:51 ` Kuldeep Singh
2026-09-08 2:51 ` Wenjia Zhang [this message]
2026-09-07 13:46 ` [PATCH v6 0/2] Shikra: Support for QCE Bartosz Golaszewski
2026-09-08 5:39 ` Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=062ea84e-07ee-41be-82a5-20600693a219@oss.qualcomm.com \
--to=wenjia.zhang@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).