From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Sam Protsenko" <semen.protsenko@linaro.org>
Cc: peter.griffin@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
willmcvicker@google.com, alim.akhtar@samsung.com,
s.nawrocki@samsung.com, tomasz.figa@gmail.com,
cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical
Date: Tue, 30 Jan 2024 09:39:56 +0000 [thread overview]
Message-ID: <06356847-edfe-4073-a370-90f57feaf64a@linaro.org> (raw)
In-Reply-To: <bbaab3addf958bc1f484a20ee0bdb65af05cf5da.camel@linaro.org>
On 1/30/24 09:31, André Draszik wrote:
> On Mon, 2024-01-29 at 13:16 -0600, Sam Protsenko wrote:
>> That sounds reasonable. But I wonder if that bit (about making this
>> clock CLK_IS_CRITICAL to make earlycon functional) can be documented
>> somewhere. Perhaps in the serial driver (earlycon function), or
>> somewhere in device tree bindings? Because otherwise it might remain
>> an arcane knowledge and people won't be able to use earlycon later.
>> Anyways, for this patch:
>>
>> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>>
>> and if you think it makes sense to document the bit above, please do.
>
> Will do on top of
> https://lore.kernel.org/all/20240119104526.1221243-6-tudor.ambarus@linaro.org/
> once that is in.
>
It was applied, it's in linux-next. I like the dt bindings idea, it's
the first thing I check when dealing with new hardware. No idea though
how to add comments just for a specific compatible. Shall be a
description somewhere...
next prev parent reply other threads:[~2024-01-30 9:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 0:35 gs101 oriole: peripheral block 0 (peric0) fixes André Draszik
2024-01-27 0:35 ` [PATCH 1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on André Draszik
2024-01-27 3:06 ` Sam Protsenko
2024-01-27 3:51 ` Tudor Ambarus
2024-01-29 12:54 ` Peter Griffin
2024-01-27 0:35 ` [PATCH 2/5] arm64: dts: exynos: gs101: fix usi8 default mode André Draszik
2024-01-27 3:05 ` Sam Protsenko
2024-01-27 3:48 ` Tudor Ambarus
2024-01-29 9:48 ` Peter Griffin
2024-01-27 0:35 ` [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8 André Draszik
2024-01-27 3:22 ` Sam Protsenko
2024-01-27 4:00 ` Tudor Ambarus
2024-01-29 16:33 ` Tudor Ambarus
2024-01-29 14:01 ` André Draszik
2024-01-27 0:35 ` [PATCH 4/5] arm64: dts: exynos: gs101: use correct clocks for usi_uart André Draszik
2024-01-27 1:37 ` André Draszik
2024-01-27 3:23 ` Sam Protsenko
2024-01-27 4:03 ` Tudor Ambarus
2024-01-29 16:39 ` Tudor Ambarus
2024-01-27 0:35 ` [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical André Draszik
2024-01-27 1:38 ` André Draszik
2024-01-27 3:30 ` Sam Protsenko
2024-01-29 14:37 ` André Draszik
2024-01-29 19:16 ` Sam Protsenko
2024-01-30 9:31 ` André Draszik
2024-01-30 9:39 ` Tudor Ambarus [this message]
2024-01-29 16:44 ` Tudor Ambarus
2024-01-27 3:01 ` gs101 oriole: peripheral block 0 (peric0) fixes Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06356847-edfe-4073-a370-90f57feaf64a@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).