From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7FA327C13 for ; Fri, 17 Apr 2026 15:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776439803; cv=none; b=m1KHa0/jD9Gy7luZDzoFPcAG6WZy82dO9B0SP1bo6JJVqLpfl41Xtdoo8qhpjvNimz2ljvXroBU46LOylmg4I1jZFx1Qw3MHl9qYM7A482iMeadYJWboFYNmDmjvOsj8t25PLHgd5ata37ylP8iF2A453X6Z0zu58MJBaDO9HtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776439803; c=relaxed/simple; bh=GMFw8UwlvWUDdGB4tOpqJjYQSXWL1VCmb5a+aZUVTx0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=TapjrajnjQ6gUlmW/IaG9fxMVMKXIUuARCVS5fr25zaRtFhEohbqMj9OdK+g4oNoVAUJ3rw/WATTefrr/5REYQZYvcMv+eAmLJuV+N3y+4MMx/BSXW+qZ3fGbTO+9hmQ1AuyvKvVCkSqPFxknWxfy7F5GMXqd6e5CuVTCzXqYBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CrS8oMg2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fE9gv91i; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CrS8oMg2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fE9gv91i" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63HESKJ81982086 for ; Fri, 17 Apr 2026 15:30:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C1RZc4rE6GguQQXCpB0wcbOaTb2Bi4UlZ5HuicWVuYU=; b=CrS8oMg2o47dY/Mv p8xTqV7huanvPDeI9l4dOGNQsIGBuB7WohisKEWPAlWn1k+Bpub7XgC2v3oip/u2 Y+kAWYK1v/AlbPm3l9meCMwxNuvqH8JEboV+Y3GA6WJ+EZGJOJPutNfqVcgGZRU2 NoarZax3g17DUT+IRq58De/KuiY+jcqie3Iz9WyK2mxt2nLjc8kEIE3v+gKMXjgM pelWcGLuTXnk53/HAJMrlszoxOIQI2i9QfyliHWaCfWJvTmEKztrJdMLl6RL9PE4 bP4HKeF8LnbPhvATwhJ9s+l85Y2wOCR73ocz3xJaJn8gO5A1FjumJqhD/kAZD37P DcZ32g== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dk52jkxsv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 15:30:01 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b2eba42b8dso7736715ad.0 for ; Fri, 17 Apr 2026 08:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776439801; x=1777044601; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=C1RZc4rE6GguQQXCpB0wcbOaTb2Bi4UlZ5HuicWVuYU=; b=fE9gv91imnHg3KZ9PcV9k60SLkf/rE2SH+bqtF389cLe/Q6qkyrESOZhvblg1qiIQa 31mk1mnVftrfW1pELV+OzCAOnPSeyf1iQzfbjuCQzLjt58nT4KudMRw2K/YxiPih8P5L rnT9yCCgym81/crIvNx7SmV9p989JB68wmR5PM0vh8p7ae74AEoMXNGmOFz0YLvTHj+T xvaoohAZMNgD2UOfU9V2bvGvbsrgVw1udNAR0TAmQ1ZxyGNNExqXuSCWXzyB6wAkb2cY bZ8OESKeWMAF3oxklgDYzmV546NJHQ7hZoEsG8Y+G43GyMtXE4MFDw6J4QsrKaUNhsBd xGfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776439801; x=1777044601; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C1RZc4rE6GguQQXCpB0wcbOaTb2Bi4UlZ5HuicWVuYU=; b=mgKrEhAZF8Ujr4c9CTnhJmNgi0+3GXjlGOu6Vr+v8fHhhB6c7aanxpPo/MugCyRuBf ATxkzRgPU7Wyw0E4UMtvfCQS6G2Q5VXnEGl+6Q6/I3C8IZ2hL6t0gRcvbtkqSLi6gEO+ gCPxRsrTS2/oCTZladVeTuhgt8M7vVcSKlS/WRVWRNi2PcvtXslzK6OidwMoe5/aB9la 4w/v/IDGFM0/IzzMzywgQqx0hfR/DJHm2kNdJKK28gRWN0U3gHL1Rqp1D1gSs1hs31NN i4alVV6EKSITuRE4y2Vit54M4oKOXPjKn5ex6IBaS9pZazSjoFICAp9OBu2HumkG9wyI ClAg== X-Forwarded-Encrypted: i=1; AFNElJ8h2dipwfL/m6eIycZ+LEYRMI1FLxg6UA77v+IjKZtjwKBNvcCNCtJF4y4YX6rBibYNVY/1Wwjb+cwZ@vger.kernel.org X-Gm-Message-State: AOJu0Yz8NUeHWOHzlZm84QrOv/+1xOMbsm67OEPLAXIkFcu9SIJah98p ZJT5mxBZ4SQ+KUuWkLulDF4JBT/jlJhar71d2qwHcEhVpM5IciNxGMRgpPddANfTbtlnpDeQuBA X9Gi10RSxnO09IQLipHmRmdgB87gbtNArBhcEHJrPRUSL2Witcv6CuImX5IGELALS X-Gm-Gg: AeBDieu1F6PZaoRFTjkE8VB3EdX5hUuaEJdpb6Qi4KzWAjhqDaQMuwmtDtofeQzS+N7 DG5NvKsZpG2ZVDPbxPRwVXaZTE62V+Ngehdj6sZYYOTuhlb3yiIqPjNvfjYxaE+j5Uh29liqO1d vkwqtwKkzy360Ah+rYdmaUISFNl8B4hCAWPmdFgGZBd1BwCYLePYEpfZ8YIpsBf0xZI4PkUieBO IcfItjR4kIFhX6GY4SRrLktJPGg63HDmYFT9Dk4UdzFaNizQlgRFFJTBS+ITOBUQBPtIbOIgpZt FvcfMIJ+WsYnxAjLDcrjvhIB4uLJKS9R/CskjyPJZWRZTzHfjKmvsMFaptwxDuVBJNi4v82xC5x GpnQ3nBx0ybmvmcZDc/9WaSagbTwLG4sCNOdO1qJXjScSi/iD1BuLSBy2Ml3ikOjT X-Received: by 2002:a17:902:c211:b0:2b2:d5aa:e373 with SMTP id d9443c01a7336-2b5f9ed0d19mr26411915ad.14.1776439800786; Fri, 17 Apr 2026 08:30:00 -0700 (PDT) X-Received: by 2002:a17:902:c211:b0:2b2:d5aa:e373 with SMTP id d9443c01a7336-2b5f9ed0d19mr26411675ad.14.1776439800235; Fri, 17 Apr 2026 08:30:00 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab54c2dsm21664015ad.83.2026.04.17.08.29.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 08:29:59 -0700 (PDT) Message-ID: <06395bd6-b3c6-fcc4-bc5e-9e4faa50fa99@oss.qualcomm.com> Date: Fri, 17 Apr 2026 20:59:50 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Vishnu Reddy Subject: Re: [PATCH 06/11] media: iris: Fix VM count passed to firmware To: Dmitry Baryshkov Cc: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joerg Roedel , Will Deacon , Robin Murphy , Bjorn Andersson , Konrad Dybcio , Stefan Schmidt , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, stable@vger.kernel.org References: <20260414-glymur-v1-0-7d3d1cf57b16@oss.qualcomm.com> <20260414-glymur-v1-6-7d3d1cf57b16@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=buR8wkai c=1 sm=1 tr=0 ts=69e251f9 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=5Xy_6AgtP5T3jK3p2aAA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: MMuwi98Bucq4N6Tx-W_Tpz-wQ-6tHUrQ X-Proofpoint-ORIG-GUID: MMuwi98Bucq4N6Tx-W_Tpz-wQ-6tHUrQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDE1NSBTYWx0ZWRfX7Z5+qtcSBow7 Wu8wqY9lnHgh6q2+JKwiMq4/f2LLM3Td/2qNWuJi7CxQsWs/dURt56RC+DA9D7X+ptZme0JfdJt 0u8YmRapUdxGeM9qC6tNDc32wKgQ12xH/M7Kqvg0O2eBOa5q/Nz1I0zJIlD1Ufo2epQldDIHsHu 2UxPDFnMKJjojW1HqyRpnrHplZTEGkvZCczijzPy+BWRKwSkIvUZ9pCnys6GN/eTMN5Y5eq4DKS HtgGYB3V6quX/9COQF4diZw3yImRSRYFwC5KpR0Xh+nQooTRBVaO4VRPc3MBNqBF/IyC4FX0v9Z iznf2n9YR97SXcvs79dPe/AjkC5c13FSuUtOOWUyfEAjG7H1OfgoLVSsnbcc17IuFn1bjLnxCVy R7rvnIaV5tjrTuiOSlY89GlKfNL2N1uZfE0ywyYfFawAVt86rSEuQBvpPa7hQyP6eKGKrShy1Q5 HLSa1khLi7ph0tj805A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-17_01,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170155 On 4/14/2026 8:50 PM, Dmitry Baryshkov wrote: > On Tue, Apr 14, 2026 at 10:30:02AM +0530, Vishnu Reddy wrote: >> On Glymur, firmware interprets the value written to CPU_CS_SCIACMDARG3 as >> the number of virtual machines (VMs) and internally adds 1 to it. Writing > Does this apply to Glymur only or to other platforms too? Only Glymur firmware is currently reading this register and other platform firmwares are ignoring this. Thanks, Vishnu Reddy. >> 1 causes firmware to treat it as 2 VMs. Since only one VM is required, >> remove this write to leave the register at its reset value of 0. This does >> not affect other platforms as only Glymur firmware uses this register, >> earlier platform firmwares ignore it. >> >> Fixes: abf5bac63f68a ("media: iris: implement the boot sequence of the firmware") >> Cc:stable@vger.kernel.org >> Signed-off-by: Vishnu Reddy >> --- >> drivers/media/platform/qcom/iris/iris_vpu_common.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c >> index 548e5f1727fd..bfd1e762c38e 100644 >> --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c >> +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c >> @@ -78,7 +78,6 @@ int iris_vpu_boot_firmware(struct iris_core *core) >> iris_vpu_setup_ucregion_memory_map(core); >> >> writel(ctrl_init, core->reg_base + CTRL_INIT); >> - writel(0x1, core->reg_base + CPU_CS_SCIACMDARG3); >> >> while (!ctrl_status && count < max_tries) { >> ctrl_status = readl(core->reg_base + CTRL_STATUS); >> >> -- >> 2.34.1 >>