From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device Date: Tue, 22 Jan 2013 14:04:56 -0800 Message-ID: <063e01cdf8ec$85e637c0$91b2a740$@samsung.com> References: <1355410348-5129-1-git-send-email-gautam.vivek@samsung.com> <20121215072014.2E05E3E0AE3@localhost> <016901cde163$6be034c0$43a09e40$@samsung.com> <50DB811A.8010408@gmail.com> <054601cdf862$534a8ad0$f9dfa070$@samsung.com> <20130122084817.GC16143@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20130122084817.GC16143-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> Content-language: en-us Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org, 'Vivek Gautam' Cc: 'Sylwester Nawrocki' , 'Doug Anderson' , 'Thomas Abraham' , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, 'Alan Stern' , 'Grant Likely' , 'Rob Herring' , jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, 'Vivek Gautam' , cpgs-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: devicetree@vger.kernel.org Felipe Balbi wrote: > Hi, > Hi Felipe, [...] > > Right, DWC has version number, but that being the kind of USB controller > > (USB 2.0 and USB 3.0) > > > > DWC2: USB High Speed controller (as also indicated in the patch from > > Paul: [RFC PATCH 0/6] DWC2 DesignWare HS OTG driver) > > DWC3: USB Super Speed controller > > > > Is it fine if we use something like shown below, as suggested by you earlier ? > > > > - { .compatible = "samsung,exynos-dwc3" }, > > + { .compatible = "samsung,synopsis-dwc3" } > > You're both missing a point here. The synopsys IP driver is called > dwc3.ko and that's compatible with synopsys,dwc3. Your glue layer driver > (dwc3-exynos.ko) is compatible with your platform, so > samsung,exynos-dwc3 sounds correct to me. > Hmm...yeah, you're right and agreed. However, we need to use more clear name there like "samsung,exynos-dwusb3" in compatible, because you know there are lots of other IPs in Synopsis Design Ware brand. So we have to include usb in compatible for that. > The glue layer is just to "abstract" away the integration details of the > IP core into a specific platform. > Right. Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html