From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Ryan Chen <ryan_chen@aspeedtech.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated
Date: Tue, 14 Mar 2023 15:22:19 +0100 [thread overview]
Message-ID: <06468199-b7cf-113f-b8b7-89c196842538@linaro.org> (raw)
In-Reply-To: <49f0b7d9-475d-898d-29d2-7e7cdf07cb0b@linaro.org>
On 14/03/2023 15:21, Krzysztof Kozlowski wrote:
> On 13/03/2023 00:36, Andi Shyti wrote:
>> Now we have the i2c-scl-clk-low-timeout-ms property defined in
>> the i2c schema.
>>
>> Mark "fsl,timeout" as deprecated and update the example.
>>
>> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
>> ---
>> Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
...
and unreviewed. Are you sure these are using same units? Old code used us.
Your example:
i2c-scl-clk-low-timeout-ms = <10000>;
10s timeout?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-14 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 23:36 [PATCH v3 0/3] Add the clock stretching i2c property Andi Shyti
2023-03-12 23:36 ` [PATCH v3 1/3] dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated Andi Shyti
2023-03-14 14:10 ` Rob Herring
2023-03-14 14:19 ` Krzysztof Kozlowski
2023-03-14 14:21 ` Krzysztof Kozlowski
2023-03-14 14:22 ` Krzysztof Kozlowski [this message]
2023-03-14 14:36 ` Andi Shyti
2023-03-12 23:36 ` [PATCH v3 2/3] i2c: mpc: Use of_property_read_u32 instead of of_get_property Andi Shyti
2023-03-13 1:53 ` Chris Packham
2023-03-12 23:36 ` [PATCH v3 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-ms i2c property Andi Shyti
2023-03-13 1:53 ` Chris Packham
2023-03-13 8:58 ` Andi Shyti
2023-03-14 14:22 ` Krzysztof Kozlowski
2023-03-14 15:16 ` Andi Shyti
2023-03-14 19:47 ` Chris Packham
2023-03-14 20:48 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06468199-b7cf-113f-b8b7-89c196842538@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).