From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8BD655930E for ; Tue, 8 Sep 2026 13:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788874092; cv=none; b=klBI3KNNnPZnar/d6DSw+Z3RxG87lzqKPw38PGNko4y10CuETZD9DCVi7hCnTfSzVvc2zo/tKYpLZfyQ8VsDILxjuxKmRyv3Z7yw/ePNCIPdQgJek7LIF2fT7+bI84WnY7y64oN0xgQJrFRHqK+gGLY/lypwJ11HXYSaUxdFmWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788874092; c=relaxed/simple; bh=1vPH25wGKRaHElEwmno4lsAnu5wFn5CpxF/7QBCj6po=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PsUj0TG0FbDT1juPTLuIgE0gzoVUFlBeBBnDhqnv6Krxt4fxIyPfYAuzZ9MxCJybGDh8lQnnq2jg4tH4gcP16QJv7yurqj36aEtf+k1cHsINX5Nr2o4fF2wu/ePEBzDJCsEV2r3GxY//BGxcIyloiUZhx36C7NniU/5McJwScZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=xa5pIYoT; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="xa5pIYoT" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-936dfd009d1so544307785a.1 for ; Tue, 08 Sep 2026 06:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1788874068; x=1789478868; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6qYBhvMfqWnvlGnnbePoY5lEKE9qhqj3w8sosJVbnkU=; b=xa5pIYoTnxqDyiKe53i7kEiwjVKLisKIKZNeAjBdZjIr9UzeVOnozCdbQrS5e8SC48 cPpnoDHtlKmbVGoDxgmgn/wTeIuM8jczqsp46Mm0gY/uo9sZs72tjaJBF+hK4VhiaLHo jccWZdnabCAMyvKragooCCYuoV40i/5BPfbOYqFADQeSAh2qKuEio3HZdhKTd6SO4wJp gmjadpNAD8vmQ584IUeJQIy78a2BKTMCRlLUJdoAGB7eHFU2pVfvtKUStVMZv+K7bYlq /zjEJHQnhFXERaciO3LvOFYSWVXtb+AzV5E5wnkcFhhFG6SyuV9BhC4gLg0qOXUCawD6 sWMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788874068; x=1789478868; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6qYBhvMfqWnvlGnnbePoY5lEKE9qhqj3w8sosJVbnkU=; b=APGvCH10JopoxiHiWm3GpXUtASneAXUyLOxWnBLCKW5XVeswabArwnQOG30X0fCwF0 Fk5HYDULJLrlpyUcgS6rkXPgvDsV1v7e17MneuULc5xI+EN1yGOmVRCziE4r7laviyXM 9vt4hrNtoKtTZIeG6pj7ljr0XD23J6SxMVs7n+7wmkVymjZxRSfJuAv5M5zWvK4/73yc r+ApDeGSL9BUXv4bZKnpJEGjO+p/NgQoeiH0Oo5s+UPlnJEKu+eyoUGsVwSaNi1hBd8f GX0RHSwlPazu+9VM/eGV8dXIUpBw4u3jsR0Vcy4vrOsSaR9gSq8ETtzkys3NA27chVmo +gEg== X-Forwarded-Encrypted: i=1; AKwUvBziaOMtD5OYBMuZ/aPIn7xprs+vh84KHbKrQWpLfZciISwI9yFmiACbIWdHXD1tx/he9/1y72nQNliK@vger.kernel.org X-Gm-Message-State: AFuF++n/JAfCogEpIgaRnZ9LcU/4pxEQbcr0/PAfD1N2/35PikgUhxGD qELLc1/tV9P1MCsQbJ/+FAWHC0OcgGFFrchN5Fb8WKzRdwHejkW1c0DuWC4M1/51JXE= X-Gm-Gg: AYBFou03mqewf5b569RfsD6qSF+TJuc1IgshkzkCPSTZSOAbiyB2U1LbvYYu9ScLl02 6QbzLTQYwctQcq1yW2oGmO8UjPQTIVBXK0Dak8wyc4tmYM1OsRKpWETHbuICTxo5pv8ekRhnrBF K5n/yWODemDitlayGPZh9mSe/X1CdZaLmqXaxgR36b7oNW+ti7Ke5Y8ekAWiOtvCMiD1BZguE3j fqikF2UJH9DxBoTY+RV2XGIB0R0fkEgN15R6DidFqHN7joM6QWnDg9tSmn7ibP1R0J6g89gqNxN /VmGaMQ6FQKt3k5kYCk34ZUI6ffRFYGIyIHQ0ZekOvjMGnTnCvUQ3STvh+cD+L/xmU3+Ht58ghj 70BdcFwl3QLsVoXjbhHyBvSi6Nw4kfZEboxXGN2XaVCPyWXpk3AjkRK/clF8RQMIbVN1ljwWWl+ /OayVE2bocDpX2AINSsKczUdhsr5iU7TMI+soD2KX0m9AExDsarwI5EedkdBcT X-Received: by 2002:a05:620a:2809:b0:939:b053:ce44 with SMTP id af79cd13be357-939b053d8femr850467585a.22.1788874067640; Tue, 08 Sep 2026 06:27:47 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-939b8fbc1dbsm249492285a.11.2026.09.08.06.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2026 06:27:47 -0700 (PDT) Message-ID: <0657a33f-4d92-4445-bd72-bc74669e06e8@riscstar.com> Date: Tue, 8 Sep 2026 08:27:46 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API To: Lorenzo Bianconi , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chaitanya Chundru , Linus Walleij , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Michael Walle Cc: Daniel Thompson , Sushrut Shree Trivedi , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski , Manivannan Sadhasivam References: <20260904-pci-tc9563-aux-v3-0-5b1449d62ba2@oss.qualcomm.com> <20260904-pci-tc9563-aux-v3-4-5b1449d62ba2@oss.qualcomm.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260904-pci-tc9563-aux-v3-4-5b1449d62ba2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/4/26 12:15 PM, Lorenzo Bianconi wrote: > Remove the local TC9563_GPIO_MASK and TC9563_GPIO_DEASSERT_BITS > definitions, which are no longer used after switching to the GPIO > descriptor API. Move TC9563_GPIO_CONFIG and TC9563_RESET_GPIO > definitions in tc9563.h header file. > > Replace the direct regmap-based per-port reset logic in > assert_deassert_reset() with gpiod_direction_output() calls, falling > back to the legacy regmap approach only when no reset-gpios DT > property is present for a given port. > > Add the reset GPIO pointer to struct tc9563_pwrctrl_cfg and introduce > tc9563_pwrctrl_parse_reset_line() to look up reset-gpios from each > PCI downstream port child node. The lookup is done lazily at the > beginning of power_on(), returning -EPROBE_DEFER until the GPIO chip > is registered. > > Reviewed-by: Bartosz Golaszewski > Reviewed-by: Manivannan Sadhasivam > Signed-off-by: Lorenzo Bianconi Looks good. Reviewed-by: Alex Elder > --- > drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 85 ++++++++++++++++++++++++++------ > include/linux/soc/qcom/tc9563.h | 3 ++ > 2 files changed, 73 insertions(+), 15 deletions(-) > > diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > index 2230765950b8..d9b69c3aeb7e 100644 > --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > @@ -25,9 +25,6 @@ > > #include "../pci.h" > > -#define TC9563_GPIO_CONFIG 0x801208 > -#define TC9563_RESET_GPIO 0x801210 > - > #define TC9563_PORT_L0S_DELAY 0x82496c > #define TC9563_PORT_L1_DELAY 0x824970 > > @@ -59,9 +56,6 @@ > #define TC9563_POWER_CONTROL 0x82b09c > #define TC9563_POWER_CONTROL_OVREN 0x82b2c8 > > -#define TC9563_GPIO_MASK 0xfffffff3 > -#define TC9563_GPIO_DEASSERT_BITS 0xc /* Clear to deassert GPIO */ > - I very much like getting rid of both of those masks... > #define TC9563_TX_MARGIN_MIN_UA 400000 > > /* > @@ -87,6 +81,7 @@ struct tc9563_pwrctrl_cfg { > u8 nfts[2]; /* GEN1 & GEN2 */ > bool disable_dfe; > bool disable_port; > + struct gpio_desc *reset; > }; > > #define TC9563_PWRCTL_MAX_SUPPLY 6 > @@ -351,16 +346,40 @@ static int tc9563_pwrctrl_set_nfts(struct tc9563_pwrctrl *tc9563, > static int tc9563_pwrctrl_assert_deassert_reset(struct tc9563_pwrctrl *tc9563, > bool deassert) > { > - int ret, val; > - > - ret = regmap_write(tc9563->regmap, TC9563_GPIO_CONFIG, > - TC9563_GPIO_MASK); > - if (ret) > - return ret; > - > - val = deassert ? TC9563_GPIO_DEASSERT_BITS : 0; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(tc9563->cfg); i++) { > + int err; > + > + if (tc9563->cfg[i].reset) { > + err = gpiod_direction_output(tc9563->cfg[i].reset, > + !deassert); > + if (err) > + return err; > + } else { > + /* Fallback: legacy DTS without reset-gpios */ > + switch (i) { > + case TC9563_DSP1: > + case TC9563_DSP2: > + err = regmap_clear_bits(tc9563->regmap, > + TC9563_GPIO_CONFIG, > + BIT(i + 1)); > + if (err) > + return err; > + > + err = regmap_assign_bits(tc9563->regmap, > + TC9563_RESET_GPIO, > + BIT(i + 1), deassert); > + if (err) > + return err; > + break; > + default: > + break; > + } > + } > + } > > - return regmap_write(tc9563->regmap, TC9563_RESET_GPIO, val); > + return 0; > } > > static int tc9563_pwrctrl_parse_device_dt(struct device_node *node, > @@ -395,6 +414,38 @@ static int tc9563_pwrctrl_parse_device_dt(struct device_node *node, > return 0; > } > > +static int tc9563_pwrctrl_parse_reset_line(struct tc9563_pwrctrl *tc9563) > +{ > + enum tc9563_pwrctrl_ports port = TC9563_USP; > + struct device *dev = tc9563->pwrctrl.dev; > + struct device_node *node = dev->of_node; > + > + for_each_child_of_node_scoped(node, child) { > + struct tc9563_pwrctrl_cfg *cfg; > + > + if (++port >= TC9563_MAX) > + break; > + > + cfg = &tc9563->cfg[port]; > + if (cfg->reset) /* Already discovered */ > + continue; > + > + cfg->reset = devm_fwnode_gpiod_get(dev, of_fwnode_handle(child), > + "reset", GPIOD_ASIS, > + NULL); > + if (IS_ERR(cfg->reset)) { > + int err = PTR_ERR(cfg->reset); > + > + cfg->reset = NULL; > + if (err != -ENOENT) > + return dev_err_probe(dev, err, > + "failed to get reset\n"); > + } > + } > + > + return 0; > +} > + > static void tc9563_pwrctrl_adev_release(struct device *dev) > { > struct auxiliary_device *adev = to_auxiliary_dev(dev); > @@ -478,6 +529,10 @@ static int tc9563_pwrctrl_power_on(struct pci_pwrctrl *pwrctrl) > struct tc9563_pwrctrl_cfg *cfg; > int ret, i; > > + ret = tc9563_pwrctrl_parse_reset_line(tc9563); > + if (ret) > + return ret; > + > ret = regulator_bulk_enable(ARRAY_SIZE(tc9563->supplies), > tc9563->supplies); > if (ret < 0) > diff --git a/include/linux/soc/qcom/tc9563.h b/include/linux/soc/qcom/tc9563.h > index 0dfd25747b9a..086f37a40d80 100644 > --- a/include/linux/soc/qcom/tc9563.h > +++ b/include/linux/soc/qcom/tc9563.h > @@ -13,4 +13,7 @@ > #define TC9563_GPIO_EN0_OFFSET 0x801208 > #define TC9563_GPIO_OUT0_OFFSET 0x801210 > > +#define TC9563_GPIO_CONFIG TC9563_GPIO_EN0_OFFSET > +#define TC9563_RESET_GPIO TC9563_GPIO_OUT0_OFFSET > + > #endif /* __QCOM_TC9563_H */ >