From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0AE6C05027 for ; Fri, 10 Feb 2023 10:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbjBJKo2 (ORCPT ); Fri, 10 Feb 2023 05:44:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232009AbjBJKo1 (ORCPT ); Fri, 10 Feb 2023 05:44:27 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8528434C1F for ; Fri, 10 Feb 2023 02:44:25 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so5966246wmb.2 for ; Fri, 10 Feb 2023 02:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=TuIE3DFWf1ieG26fb802V4Dw782qOhFqrgu8/YDQEqE=; b=dKMCjgKnXwFUENbPIxmzn+ydcATqzU+NxqCs3sCFCNlicsOMtsO3rPBam735GvIPhb rUraR20VRGJ1Fy7OGapqMREFwcp650BQVEh0HrAgDNQH7Du/EB/sA8rqxMCiccp66m1P 8Z0AeT491ld8YajEfDzMIhHdANVpSalmhHAVaK39yR9lMmSnW4Jdy3q+o0Nwcx+xYXsd WzvBeRDPgecbg6wktNAGzeCz/r8gd0By3DFzWYsxJ89uDFuMXFdbJU984AbvZLeUYcuQ h0RsZVe93f4tBoJXeFxr0tTt41NrHA8qLFk+/2KyUL1w4aGhskSsgW12JvN6riHO1cTz nzNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TuIE3DFWf1ieG26fb802V4Dw782qOhFqrgu8/YDQEqE=; b=cihUiVCtPxiciBoroIllkDC6MLRTLmgBqWxWblQOwC5ezA8Iw5+pbwZWQ6ZH2kCCg1 NA7HaUsJ1/Pc3T1fcC+hLNlHsdKOAE21pQAaYinReL7mjQCB5Uwc8JnFTMsJWnZW5+qP cdcoFo2VE/N+A8Svzv1CHrWh8YkPoBFt0q36lfF0RKuvJxtojE7iYF6DdNl37/jZeF7C SJWtjvyaSgduc5hDOw/QReZmf9qVxlwklN9nhkzbJEa4Ffc9Jgd8wnEG4dyjHOibF+of NaLZdvUt6OeIPdD7zuEPZ67RNUcAH5zXuUe61lw3CeV1I7xHlVbRVaz0NBqm8It01//k pZ5A== X-Gm-Message-State: AO0yUKWW1yKTdoouL6ESl7ISuh8w11qCj4HzL9ahiZbDX7dgp5g9U93f CI9QYkRSDE8FlQS/wi4CMg+13Q== X-Google-Smtp-Source: AK7set926XzOGdWOriKW365z+hMWb/Sk5AMamr2w66iAIEhBCEEyboHJKTqbvQfZ31hAC7hgI1I6Iw== X-Received: by 2002:a05:600c:329d:b0:3dd:97d6:8f2e with SMTP id t29-20020a05600c329d00b003dd97d68f2emr12190714wmp.17.1676025864139; Fri, 10 Feb 2023 02:44:24 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:5a65:5553:55cf:3027? ([2a01:e0a:982:cbb0:5a65:5553:55cf:3027]) by smtp.gmail.com with ESMTPSA id k21-20020a05600c1c9500b003dd1c45a7b0sm4878029wms.23.2023.02.10.02.44.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 02:44:23 -0800 (PST) Message-ID: <06670a10-c8e9-6f87-9c16-e88a90a74469@linaro.org> Date: Fri, 10 Feb 2023 11:44:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Content-Language: en-US To: Greg Kroah-Hartman Cc: Heikki Krogerus , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> <720aee1d-87e8-5291-c6a0-ef53e830a21d@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/02/2023 11:38, Greg Kroah-Hartman wrote: > On Fri, Feb 10, 2023 at 11:31:08AM +0100, Neil Armstrong wrote: >> On 31/01/2023 10:16, Greg Kroah-Hartman wrote: >>> On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote: >>>> Introduce the UCSI PMIC Glink aux driver that communicates >>>> with the aDSP firmware with the UCSI protocol which handles >>>> the USB-C Port(s) Power Delivery. >>>> >>>> The UCSI messaging is necessary on newer Qualcomm SoCs to >>>> provide USB role switch and altmode notifications. >>>> >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> drivers/usb/typec/ucsi/Kconfig | 7 + >>>> drivers/usb/typec/ucsi/Makefile | 1 + >>>> drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 329 insertions(+) >>>> >>>> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig >>>> index 8f9c4b9f31f7..dee6069e46a2 100644 >>>> --- a/drivers/usb/typec/ucsi/Kconfig >>>> +++ b/drivers/usb/typec/ucsi/Kconfig >>>> @@ -58,4 +58,11 @@ config UCSI_STM32G0 >>>> To compile the driver as a module, choose M here: the module will be >>>> called ucsi_stm32g0. >>>> +config UCSI_PMIC_GLINK >>>> + tristate "UCSI Qualcomm PMIC GLINK Interface Driver" >>>> + depends on QCOM_PMIC_GLINK >>> >>> No way to test build this code without this option? >> >> Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed > > Then perhaps the QCOM_PMIC_GLINK code needs to be fixed up to allow for > it to be built on all platforms properly? Otherwise you are > guaranteeing you will not get much, if any, build coverage and api > changes will cause this code to stagnate over time :( The QCOM_PMIC_GLINK deps are: depends on RPMSG depends on TYPEC depends on DRM depends on NET depends on OF select AUXILIARY_BUS select QCOM_PDR_HELPERS What would be the changes needed here ? Neil > > thanks, > > greg k-h