From: neil.armstrong@linaro.org
To: sashiko-reviews@lists.linux.dev,
YuChia-Kan <raspberrykan@stu.hqu.edu.cn>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: amlogic: add Xiaomi Mi Box 4 support
Date: Thu, 3 Sep 2026 11:18:03 +0200 [thread overview]
Message-ID: <0668e09d-3596-47db-ba16-0d8c053e74b5@linaro.org> (raw)
In-Reply-To: <20260903085901.9CD541F00A3A@smtp.kernel.org>
On 9/3/26 10:59, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Makefile entries are not alphabetically sorted.
> --
>
> commit 70cc330a6bc43bd5cfd305fe463356587a2e4a7d
> Author: YuChia-Kan <raspberrykan@stu.hqu.edu.cn>
>
> arm64: dts: amlogic: add Xiaomi Mi Box 4 support
>
> This patch adds initial device tree support for the Xiaomi Mi Box 4, which is
> based on the Amlogic S905L SoC. It enables the main on-board peripherals
> including eMMC, Wi-Fi, HDMI, USB, and audio.
>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 57bc440fa55cc..9f357df5fc54e 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -72,6 +72,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-vero4k.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxlx-s905l-p271.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += meson-gxlx-mibox4.dtb
>
> [Severity: Low]
> Does this break the alphabetical sorting of the dtb list? It looks like
> meson-gxlx-mibox4.dtb should be inserted before meson-gxlx-s905l-p271.dtb to
> maintain the correct order in the Makefile.
And the name should probably align with the other dt names and align with the aquaman name (meson-gxl-s805y-xiaomi-aquaman.dts):
meson-gxlx-s905l-xiami-mibox4
Neil
>
> [ ... ]
>
prev parent reply other threads:[~2026-09-03 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 8:50 [PATCH v2 0/2] Add initial device tree support for the Xiaomi Mi Box 4 (MDZ-21-AA), an Amlogic S905L based TV box YuChia-Kan
2026-09-03 8:50 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add Xiaomi Mi Box 4 YuChia-Kan
2026-09-03 8:50 ` [PATCH v2 2/2] arm64: dts: amlogic: add Xiaomi Mi Box 4 support YuChia-Kan
2026-09-03 8:59 ` sashiko-bot
2026-09-03 9:18 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0668e09d-3596-47db-ba16-0d8c053e74b5@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=raspberrykan@stu.hqu.edu.cn \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox