From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4001F3B0ADA; Mon, 6 Jul 2026 12:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783340402; cv=none; b=SQX3K27qs/DQSIopMEdH77LNfcaJ94GThpezBoJRJqDYT0bsD3cLbuelltsRL6HoyDrLeB1N7BoIm7BNs61JR7NSEcFUvLDtIAAe0OisZEK+bF0sQH1glBND/7Ai3Le6ep8X7t7RPPPQobflgSvkOQhg5BTa/Ok+Wywp9+zCoOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783340402; c=relaxed/simple; bh=vuhD2ruNDP9XAX+07swc46WOzxtmn76ztN32OiLFtgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ErgAjrrALlzfpGPllLVheulniYYxfZcAz1fbfd/fD2aR8tl3s7OPf2PZOZiMH/WPo7huSTSFphUFMbzkf8FdN4h7sakcv5+Mj6YeUipQ+oCy47IUplCjn5degR+WjBduEIcZTXsrl5FFYNoiO7dhfKTZJBfMTdBJYtsP61hmIMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jvm9YcVX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jvm9YcVX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 597441F000E9; Mon, 6 Jul 2026 12:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783340399; bh=giQxIjT+Q3O/eFnuDAwV8ILVtxYAzTseRkaIYeV7mZQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Jvm9YcVXrz1O6pYIiIS/0sg7qujNcKm5DWsLfgauIG8oeINe+0bJD3qh8MIVghSC1 82u8aYb7qnCaXrrtCVmZC5PARsYFU6F6KdOKWEpYloIZ0QHPwIwbRVyCM5SSM0xi4a wGm4xK9VzXOQfDqhZSa9EpLWGyo6EkG7Es+lpVMBdN4Ld+VTk8+OvGYnoUJqzfyY61 xQrRcLj4Cbyzn12B7aGI1uNb8oJsx9L7OqIBVNxho6AQgd6t+PQi7ankcrvs7Q56EP l2+VwJZaNzTWp9c3fJIyKxiq1oCTBSHM4koz8EsD+2kpzau4/42CqZ31oQGIDynP/l ddZs/0/R3tjzw== Message-ID: <06834dd6-1221-463f-9543-600814c8fc83@kernel.org> Date: Mon, 6 Jul 2026 14:19:51 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder To: Atanas Filipov , linux-media@vger.kernel.org Cc: bryan.odonoghue@linaro.org, vladimir.zapolskiy@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-6-atanas.filipov@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260706071113.383215-6-atanas.filipov@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/07/2026 09:11, Atanas Filipov wrote: > Add a Qualcomm JPEG encoder driver implemented on top of the > V4L2 mem2mem framework. > > The driver wires vb2 queue handling, format negotiation, JPEG header > handling, interrupt-driven job completion, and runtime PM/clock/ICC > integration for the standalone JPEG encode hardware block. > > This series targets SM8250 (Kona) platforms. > > The jpeg-encoder node is described as a child node of the CAMSS block > and is probed automatically via of_platform_populate() in camss_probe(). > > Usage examples: > > - Check of related video node: v4l2-ctl --list-devices > The expected result: > qcom-jpeg-enc (platform:qcom-jpeg-enc): > /dev/videoX > > V4L2 Examples: > > v4l2-ctl -d /dev/video14 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NM12 \ > --stream-mmap --stream-out-mmap > > v4l2-ctl -d /dev/video14 \ > -c compression_quality=100 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NM12 \ > --stream-mmap --stream-out-mmap \ > --stream-count=100 > > v4l2-ctl -d /dev/video14 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NM12 \ > --stream-mmap --stream-out-mmap \ > --set-ctrl=perf_level_auto=1 \ > --set-ctrl=fps_target=30 \ > --stream-count=100 > > v4l2-ctl -d /dev/video14 \ > --set-fmt-video-out=width=8192,height=8192,pixelformat=NM12 \ > --stream-mmap --stream-out-mmap \ > --stream-count=1 \ > --stream-to=8192x8192_NM12.jpg > > v4l2-ctl -d /dev/video14 \ > --set-fmt-video-out=width=8192,height=8192,pixelformat=GREY \ > --stream-mmap --stream-out-mmap \ > --stream-count=1 \ > --stream-to=OUT_8192x8192.jpg > > v4l2-ctl -d /dev/video14 \ > -c compression_quality=100 \ > --set-fmt-video-out=width=1920,height=1088,pixelformat=NM12 \ > --stream-mmap=4 --stream-out-mmap=4 \ > --stream-count=100 \ > --stream-out-pattern=21 \ > --stream-to=OUT_1920x1088_100F.mjpg > > GStreamer examples: > > gst-launch-1.0 videotestsrc \ > is-live=false pattern=ball num-buffers=50 ! \ > video/x-raw,format=NV12,width=1920,height=1080 ! \ > videoscale ! videoconvert ! \ > video/x-raw,format=NV12,width=1920,height=1088 ! \ > v4l2jpegenc ! \ > fakesink sync=false > > gst-launch-1.0 videotestsrc is-live=true pattern=smpte ! \ > video/x-raw,format=NV12,width=1920,height=1088 ! \ > v4l2jpegenc extra-controls="controls,compression_quality=85" ! \ > fpsdisplaysink -v sync=false > > Performance measurements on SM8250 > (NV12, quality=100, GStreamer v4l2jpegenc vs jpegenc): > > +------------+-----------------------------+-------------------+ > | Resolution | HW v4l2jpegenc (q100) | SW jpegenc (q100) | > | | Execution | avrFPS | maxFPS | Execution | FPS | > +------------+-----------+--------+--------+-----------+-------+ > | 512x512 | 2.2332 | 1139.1 | 1195.4 | 7.1055 | 358.0 | > | 1280x720 | 1.7300 | 418.5 | 457.2 | 5.0585 | 143.1 | > | 1024x1024 | 1.6991 | 374.3 | 397.4 | 4.7304 | 134.4 | > | 1920x1088 | 1.6596 | 192.8 | 193.8 | 3.7913 | 84.4 | > | 2048x2048 | 1.7277 | 92.0 | 91.6 | 3.6343 | 43.7 | > | 4096x4096 | 1.5887 | 25.2 | 25.3 | 4.2163 | 9.5 | > | 8192x8192 | 1.3104 | 7.6 | 8.0 | 2.9987 | 3.3 | > +------------+-----------+--------+--------+-----------+-------+ > > Signed-off-by: Atanas Filipov > --- > .../bindings/media/qcom,jpeg-encoder.yaml | 143 +- NAK ... > diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig > index 4f4d3a68e6e5..f33d53a754a0 100644 > --- a/drivers/media/platform/qcom/Kconfig > +++ b/drivers/media/platform/qcom/Kconfig > @@ -5,3 +5,4 @@ comment "Qualcomm media platform drivers" > source "drivers/media/platform/qcom/camss/Kconfig" > source "drivers/media/platform/qcom/iris/Kconfig" > source "drivers/media/platform/qcom/venus/Kconfig" > +source "drivers/media/platform/qcom/jpeg/Kconfig" Just like for other patch, you ignored reviewers' feedback. I already asked you to go through previous comments around v3. I do not see improvements, so I assume you do it deliberately. NAK Best regards, Krzysztof