From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8418CC3F2CD for ; Wed, 4 Mar 2020 09:16:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6189C20705 for ; Wed, 4 Mar 2020 09:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728779AbgCDJQ1 (ORCPT ); Wed, 4 Mar 2020 04:16:27 -0500 Received: from mga04.intel.com ([192.55.52.120]:20949 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725271AbgCDJQ1 (ORCPT ); Wed, 4 Mar 2020 04:16:27 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 01:16:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,513,1574150400"; d="scan'208";a="229258701" Received: from linux.intel.com ([10.54.29.200]) by orsmga007.jf.intel.com with ESMTP; 04 Mar 2020 01:16:26 -0800 Received: from [10.226.39.43] (unknown [10.226.39.43]) by linux.intel.com (Postfix) with ESMTP id 4364158029F; Wed, 4 Mar 2020 01:16:24 -0800 (PST) Subject: Re: [PATCH v4 2/3] dt-bindings: phy: Add YAML schemas for Intel Combophy To: Rob Herring Cc: "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, Kishon Vijay Abraham I , Andy Shevchenko , cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com, yixin.zhu@intel.com References: <9f049a5fccd080bd5d8e9a697b96d4c40a413a0a.1583127977.git.eswara.kota@linux.intel.com> <20200303015051.GA780@bogus> <5b71670d-91a6-9760-f4da-1b6f014a1ea2@linux.intel.com> From: Dilip Kota Message-ID: <068bcf8c-83b0-57ee-3fb8-c0fe1bf6e5d8@linux.intel.com> Date: Wed, 4 Mar 2020 17:16:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 3/4/2020 12:26 AM, Rob Herring wrote: > On Tue, Mar 3, 2020 at 3:24 AM Dilip Kota wrote: >> >> On 3/3/2020 9:50 AM, Rob Herring wrote: >>> On Mon, Mar 02, 2020 at 04:43:24PM +0800, Dilip Kota wrote: >>>> Combophy subsystem provides PHY support to various >>>> controllers, viz. PCIe, SATA and EMAC. >>>> Adding YAML schemas for the same. >>>> >>>> Signed-off-by: Dilip Kota >>>> --- >>>> Changes on v4: >>>> No changes. >> ... >>>> +additionalProperties: false >>>> + >>>> +examples: >>>> + - | >>>> + #include >>>> + combophy@d0a00000 { >>>> + compatible = "intel,combophy-lgm", "intel,combo-phy"; >>>> + clocks = <&cgu0 1>; >>>> + reg = <0xd0a00000 0x40000>, >>>> + <0xd0a40000 0x1000>; >>>> + reg-names = "core", "app"; >>>> + resets = <&rcu0 0x50 6>, >>>> + <&rcu0 0x50 17>; >>>> + reset-names = "phy", "core"; >>>> + intel,syscfg = <&sysconf 0>; >>>> + intel,hsio = <&hsiol 0>; >>>> + intel,phy-mode = ; >>>> + >>>> + phy@0 { >>> You need a 'reg' property to go with a unit-address. >>> >>> Really, I'd just simplify this to make parent 'resets' be 4 entries and >>> put '#phy-cells = <1>;' in the parent. Then you don't need these child >>> nodes. >> If child nodes are not present, use case like PCIe controller-0 using >> phy@0 and PCIe controller-1 using phy@1 wont be possible. > Yes, it will be. > > For controller-0: > phys = <&phy 0>; > > For controller-1: > phys = <&phy 1>; OH got it, arg cell can be utilized for PHY id. I started working on your suggestion in simplifying it, but below point is haunting while doing the changes. So felt to check with you whether the better one is going with existing DT node or the one without child nodes!.      Existing DT node skeleton, replicates hardware design ComboPhy with 2 PHYs. (ComboPhy as parent node and 2PHYs as child nodes) Regards, Dilip > > Rob