devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valentin CARON - foss <valentin.caron@foss.st.com>
To: "dillon.minfei@gmail.com" <dillon.minfei@gmail.com>,
	"robh@kernel.org" <robh@kernel.org>,
	Alexandre TORGUE - foss <alexandre.torgue@foss.st.com>,
	"rong.a.chen@intel.com" <rong.a.chen@intel.com>,
	"a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>,
	"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"vladimir.murzin@arm.com" <vladimir.murzin@arm.com>,
	"afzal.mohd.ma@gmail.com" <afzal.mohd.ma@gmail.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"Erwan LE-RAY - foss" <erwan.leray@foss.st.com>,
	Erwan LE RAY <erwan.leray@st.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"lkp@intel.com" <lkp@intel.com>
Subject: Re: [PATCH v5 9/9] dt-bindings: serial: stm32: Use 'type: object' instead of false for 'additionalProperties'
Date: Thu, 25 Mar 2021 11:12:21 +0000	[thread overview]
Message-ID: <068cb7ae-9afc-606d-2579-189e46516cd5@foss.st.com> (raw)
In-Reply-To: <1616653162-19954-8-git-send-email-dillon.minfei@gmail.com>

Hi Dillon,

It's okay for me.

Regards,

Valentin

On 3/25/21 7:19 AM, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
>
> To use additional properties 'bluetooth' on serial, need replace false with
> 'type: object' for 'additionalProperties' to make it as a node, else will
> run into dtbs_check warnings.
>
> 'arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800:
> 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: af1c2d81695b ("dt-bindings: serial: Convert STM32 UART to json-schema")
> Reported-by: kernel test robot <lkp@intel.com>
> Tested-by: Valentin Caron <valentin.caron@foss.st.com>
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
>
> v5: accroding to rob's suggestion, replace false with 'type: object'
>      of 'additionalProperties'.
>
>   Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 8631678283f9..865be05083c3 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -80,7 +80,8 @@ required:
>     - interrupts
>     - clocks
>   
> -additionalProperties: false
> +additionalProperties:
> +  type: object
>   
>   examples:
>     - |

  reply	other threads:[~2021-03-25 11:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  6:19 [PATCH v5 0/9] ARM: STM32: add art-pi(stm32h750xbh6) board support dillon.minfei
2021-03-25  6:19 ` [PATCH v5 1/9] Documentation: arm: stm32: Add stm32h750 value line doc dillon.minfei
2021-03-25  6:19 ` [PATCH v5 4/9] ARM: dts: stm32: introduce stm32h7-pinctrl.dtsi to support stm32h750 dillon.minfei
2021-03-25  6:19 ` [PATCH v5 5/9] ARM: dts: stm32: add stm32h750-pinctrl.dtsi dillon.minfei
2021-03-25  6:19 ` [PATCH v5 6/9] ARM: dts: stm32: add support for art-pi board based on stm32h750xbh6 dillon.minfei
2021-03-25  6:19 ` [PATCH v5 7/9] ARM: stm32: Add a new SOC - STM32H750 dillon.minfei
2021-03-25  6:19 ` [PATCH v5 8/9] pinctrl: stm32: Add STM32H750 MCU pinctrl support dillon.minfei
2021-03-25  6:19 ` [PATCH v5 9/9] dt-bindings: serial: stm32: Use 'type: object' instead of false for 'additionalProperties' dillon.minfei
2021-03-25 11:12   ` Valentin CARON - foss [this message]
2021-03-26  1:53     ` dillon min

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=068cb7ae-9afc-606d-2579-189e46516cd5@foss.st.com \
    --to=valentin.caron@foss.st.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=afzal.mohd.ma@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dillon.minfei@gmail.com \
    --cc=erwan.leray@foss.st.com \
    --cc=erwan.leray@st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=lkp@intel.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    --cc=rong.a.chen@intel.com \
    --cc=vladimir.murzin@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).