[PATCH 0/2] arm: dts: renesas: Convert remaining boards to new LVDS DT bindings

[PATCH 0/2] arm: dts: renesas: Convert remaining boards to new LVDS DT bindings

[Geert Uytterhoeven]

	Hi Simon, Magnus, Laurent, Marek,

As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
LVDS support in the DU bindings"), the internal LVDS encoder has DT
bindings separate from the DU.  Most board device trees were ported over
to the new model, but Stout with R-Car H2 and Salvator-XS with R-Car
M3-W were forgotten.

This patch series converts the remaining boards.
Both patches were compiled-tested only.

Thanks!

Geert Uytterhoeven (2):
  ARM: dts: stout: Convert to new LVDS DT bindings
  arm64: dts: renesas: r8a7796: salvator-xs: Convert to new LVDS DT
    bindings

 arch/arm/boot/dts/r8a7790-stout.dts               | 15 ++++++++++++---
 .../boot/dts/renesas/r8a7796-salvator-xs.dts      |  3 +--
 2 files changed, 13 insertions(+), 5 deletions(-)

-- 
2.17.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Geert Uytterhoeven]

As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
LVDS support in the DU bindings"), the internal LVDS encoder has DT
bindings separate from the DU.  The Lager device tree was ported over to
the new model, but the Stout device tree was forgotten.

Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Compile-tested only.
---
 arch/arm/boot/dts/r8a7790-stout.dts | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790-stout.dts b/arch/arm/boot/dts/r8a7790-stout.dts
index 629da4cee1b971d6..7a7d3b84d1a6b21d 100644
--- a/arch/arm/boot/dts/r8a7790-stout.dts
+++ b/arch/arm/boot/dts/r8a7790-stout.dts
@@ -94,9 +94,8 @@
 	status = "okay";
 
 	clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 722>,
-		 <&cpg CPG_MOD 726>, <&cpg CPG_MOD 725>,
 		 <&osc1_clk>;
-	clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1", "dclkin.0";
+	clock-names = "du.0", "du.1", "du.2", "dclkin.0";
 
 	ports {
 		port@0 {
@@ -104,11 +103,21 @@
 				remote-endpoint = <&adv7511_in>;
 			};
 		};
+	};
+};
+
+&lvds0 {
+	ports {
 		port@1 {
 			lvds_connector0: endpoint {
 			};
 		};
-		port@2 {
+	};
+};
+
+&lvds1 {
+	ports {
+		port@1 {
 			lvds_connector1: endpoint {
 			};
 		};
-- 
2.17.1

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
> LVDS support in the DU bindings"), the internal LVDS encoder has DT
> bindings separate from the DU.  The Lager device tree was ported over to
> the new model, but the Stout device tree was forgotten.
> 
> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Compile-tested only.

I can't test the patch either but it looks fine to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I assume you will send this directly to Simon, so I don't plan to take the 
patch in my tree.

> ---
>  arch/arm/boot/dts/r8a7790-stout.dts | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7790-stout.dts
> b/arch/arm/boot/dts/r8a7790-stout.dts index
> 629da4cee1b971d6..7a7d3b84d1a6b21d 100644
> --- a/arch/arm/boot/dts/r8a7790-stout.dts
> +++ b/arch/arm/boot/dts/r8a7790-stout.dts
> @@ -94,9 +94,8 @@
>  	status = "okay";
> 
>  	clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 722>,
> -		 <&cpg CPG_MOD 726>, <&cpg CPG_MOD 725>,
>  		 <&osc1_clk>;
> -	clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1", "dclkin.0";
> +	clock-names = "du.0", "du.1", "du.2", "dclkin.0";
> 
>  	ports {
>  		port@0 {
> @@ -104,11 +103,21 @@
>  				remote-endpoint = <&adv7511_in>;
>  			};
>  		};
> +	};
> +};
> +
> +&lvds0 {
> +	ports {
>  		port@1 {
>  			lvds_connector0: endpoint {
>  			};
>  		};
> -		port@2 {
> +	};
> +};
> +
> +&lvds1 {
> +	ports {
> +		port@1 {
>  			lvds_connector1: endpoint {
>  			};
>  		};

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Marek Vasut]

On 12/03/2018 10:48 PM, Laurent Pinchart wrote:
> Hi Geert,

Hi,

> Thank you for the patch.
> 
> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
>> LVDS support in the DU bindings"), the internal LVDS encoder has DT
>> bindings separate from the DU.  The Lager device tree was ported over to
>> the new model, but the Stout device tree was forgotten.
>>
>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Compile-tested only.
> 
> I can't test the patch either but it looks fine to me.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> I assume you will send this directly to Simon, so I don't plan to take the 
> patch in my tree.
I have a Stout if you need me to test something.

-- 
Best regards,
Marek Vasut

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Laurent Pinchart]

Hi Marek,

On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote:
> On 12/03/2018 10:48 PM, Laurent Pinchart wrote:
> > On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
> >> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
> >> LVDS support in the DU bindings"), the internal LVDS encoder has DT
> >> bindings separate from the DU.  The Lager device tree was ported over to
> >> the new model, but the Stout device tree was forgotten.
> >> 
> >> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
> >> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> ---
> >> Compile-tested only.
> > 
> > I can't test the patch either but it looks fine to me.
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > I assume you will send this directly to Simon, so I don't plan to take the
> > patch in my tree.
> 
> I have a Stout if you need me to test something.

Could you test HDMI output ? We just need to ensure that everything is probed 
correctly, so display anything on the HDMI output will do.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Marek Vasut]

On 12/03/2018 11:48 PM, Laurent Pinchart wrote:
> Hi Marek,
> 
> On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote:
>> On 12/03/2018 10:48 PM, Laurent Pinchart wrote:
>>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
>>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
>>>> LVDS support in the DU bindings"), the internal LVDS encoder has DT
>>>> bindings separate from the DU.  The Lager device tree was ported over to
>>>> the new model, but the Stout device tree was forgotten.
>>>>
>>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
>>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>> ---
>>>> Compile-tested only.
>>>
>>> I can't test the patch either but it looks fine to me.
>>>
>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>
>>> I assume you will send this directly to Simon, so I don't plan to take the
>>> patch in my tree.
>>
>> I have a Stout if you need me to test something.
> 
> Could you test HDMI output ? We just need to ensure that everything is probed 
> correctly, so display anything on the HDMI output will do.

Sure, can you push me a branch somewhere, so I don't have to hunt down
patches ?

-- 
Best regards,
Marek Vasut

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Laurent Pinchart]

Hi Marek,

On Wednesday, 5 December 2018 03:10:18 EET Marek Vasut wrote:
> On 12/03/2018 11:48 PM, Laurent Pinchart wrote:
> > On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote:
> >> On 12/03/2018 10:48 PM, Laurent Pinchart wrote:
> >>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
> >>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas:
> >>>> Deprecate LVDS support in the DU bindings"), the internal LVDS encoder
> >>>> has DT bindings separate from the DU.  The Lager device tree was ported
> >>>> over to the new model, but the Stout device tree was forgotten.
> >>>> 
> >>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
> >>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>> ---
> >>>> Compile-tested only.
> >>> 
> >>> I can't test the patch either but it looks fine to me.
> >>> 
> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>> 
> >>> I assume you will send this directly to Simon, so I don't plan to take
> >>> the patch in my tree.
> >> 
> >> I have a Stout if you need me to test something.
> > 
> > Could you test HDMI output ? We just need to ensure that everything is
> > probed correctly, so display anything on the HDMI output will do.
> 
> Sure, can you push me a branch somewhere, so I don't have to hunt down
> patches ?

Only this patch should be needed. You can get it from https://
patchwork.kernel.org/patch/10709781/ and apply it on top of v4.19. Please 
don't use v4.20-rc is there's one missing regression fix there (it has been 
merged in the media tree and should make it to the final release).

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Marek Vasut]

On 12/05/2018 06:41 AM, Laurent Pinchart wrote:
> Hi Marek,
> 
> On Wednesday, 5 December 2018 03:10:18 EET Marek Vasut wrote:
>> On 12/03/2018 11:48 PM, Laurent Pinchart wrote:
>>> On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote:
>>>> On 12/03/2018 10:48 PM, Laurent Pinchart wrote:
>>>>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
>>>>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas:
>>>>>> Deprecate LVDS support in the DU bindings"), the internal LVDS encoder
>>>>>> has DT bindings separate from the DU.  The Lager device tree was ported
>>>>>> over to the new model, but the Stout device tree was forgotten.
>>>>>>
>>>>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
>>>>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>>> ---
>>>>>> Compile-tested only.
>>>>>
>>>>> I can't test the patch either but it looks fine to me.
>>>>>
>>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>>>
>>>>> I assume you will send this directly to Simon, so I don't plan to take
>>>>> the patch in my tree.
>>>>
>>>> I have a Stout if you need me to test something.
>>>
>>> Could you test HDMI output ? We just need to ensure that everything is
>>> probed correctly, so display anything on the HDMI output will do.
>>
>> Sure, can you push me a branch somewhere, so I don't have to hunt down
>> patches ?
> 
> Only this patch should be needed. You can get it from https://
> patchwork.kernel.org/patch/10709781/ and apply it on top of v4.19. Please 
> don't use v4.20-rc is there's one missing regression fix there (it has been 
> merged in the media tree and should make it to the final release).

On R8A7790 H2 ES3.0 Stout

Tested-by: Marek Vasut <marek.vasut@gmail.com>

-- 
Best regards,
Marek Vasut

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

[Simon Horman]

On Fri, Dec 07, 2018 at 07:36:42PM +0100, Marek Vasut wrote:
> On 12/05/2018 06:41 AM, Laurent Pinchart wrote:
> > Hi Marek,
> > 
> > On Wednesday, 5 December 2018 03:10:18 EET Marek Vasut wrote:
> >> On 12/03/2018 11:48 PM, Laurent Pinchart wrote:
> >>> On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote:
> >>>> On 12/03/2018 10:48 PM, Laurent Pinchart wrote:
> >>>>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
> >>>>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas:
> >>>>>> Deprecate LVDS support in the DU bindings"), the internal LVDS encoder
> >>>>>> has DT bindings separate from the DU.  The Lager device tree was ported
> >>>>>> over to the new model, but the Stout device tree was forgotten.
> >>>>>>
> >>>>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
> >>>>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>>>> ---
> >>>>>> Compile-tested only.
> >>>>>
> >>>>> I can't test the patch either but it looks fine to me.
> >>>>>
> >>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>>>>
> >>>>> I assume you will send this directly to Simon, so I don't plan to take
> >>>>> the patch in my tree.
> >>>>
> >>>> I have a Stout if you need me to test something.
> >>>
> >>> Could you test HDMI output ? We just need to ensure that everything is
> >>> probed correctly, so display anything on the HDMI output will do.
> >>
> >> Sure, can you push me a branch somewhere, so I don't have to hunt down
> >> patches ?
> > 
> > Only this patch should be needed. You can get it from https://
> > patchwork.kernel.org/patch/10709781/ and apply it on top of v4.19. Please 
> > don't use v4.20-rc is there's one missing regression fix there (it has been 
> > merged in the media tree and should make it to the final release).
> 
> On R8A7790 H2 ES3.0 Stout
> 
> Tested-by: Marek Vasut <marek.vasut@gmail.com>

Thanks, applied for v4.22.

[PATCH 2/2] arm64: dts: renesas: r8a7796: salvator-xs: Convert to new LVDS DT bindings

[Geert Uytterhoeven]

As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
LVDS support in the DU bindings"), the internal LVDS encoder has DT
bindings separate from the DU.  The device trees for all R-Car H3 and
M3-W development boards were ported over to the new model, but
Salvator-XS boards equipped with an R-Car M3-W SoC were forgotten.

Fixes: 58e8ed2ee9abe718 ("arm64: dts: renesas: Convert to new LVDS DT bindings")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Compile-tested only.
---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
index 8860be65342e4f38..31f12059355ee02b 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
@@ -29,11 +29,10 @@
 	clocks = <&cpg CPG_MOD 724>,
 		 <&cpg CPG_MOD 723>,
 		 <&cpg CPG_MOD 722>,
-		 <&cpg CPG_MOD 727>,
 		 <&versaclock6 1>,
 		 <&x21_clk>,
 		 <&versaclock6 2>;
-	clock-names = "du.0", "du.1", "du.2", "lvds.0",
+	clock-names = "du.0", "du.1", "du.2",
 		      "dclkin.0", "dclkin.1", "dclkin.2";
 };
 
-- 
2.17.1

Re: [PATCH 2/2] arm64: dts: renesas: r8a7796: salvator-xs: Convert to new LVDS DT bindings

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Monday, 3 December 2018 17:12:42 EET Geert Uytterhoeven wrote:
> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
> LVDS support in the DU bindings"), the internal LVDS encoder has DT
> bindings separate from the DU.  The device trees for all R-Car H3 and
> M3-W development boards were ported over to the new model, but
> Salvator-XS boards equipped with an R-Car M3-W SoC were forgotten.
> 
> Fixes: 58e8ed2ee9abe718 ("arm64: dts: renesas: Convert to new LVDS DT
> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Compile-tested only.

I can't test the patch either but it looks fine to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I assume you will send this directly to Simon, so I don't plan to take the 
patch in my tree.

> ---
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
> b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts index
> 8860be65342e4f38..31f12059355ee02b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
> @@ -29,11 +29,10 @@
>  	clocks = <&cpg CPG_MOD 724>,
>  		 <&cpg CPG_MOD 723>,
>  		 <&cpg CPG_MOD 722>,
> -		 <&cpg CPG_MOD 727>,
>  		 <&versaclock6 1>,
>  		 <&x21_clk>,
>  		 <&versaclock6 2>;
> -	clock-names = "du.0", "du.1", "du.2", "lvds.0",
> +	clock-names = "du.0", "du.1", "du.2",
>  		      "dclkin.0", "dclkin.1", "dclkin.2";
>  };

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] arm64: dts: renesas: r8a7796: salvator-xs: Convert to new LVDS DT bindings

[Simon Horman]

On Mon, Dec 03, 2018 at 11:51:19PM +0200, Laurent Pinchart wrote:
> Hi Geert,
> 
> Thank you for the patch.
> 
> On Monday, 3 December 2018 17:12:42 EET Geert Uytterhoeven wrote:
> > As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
> > LVDS support in the DU bindings"), the internal LVDS encoder has DT
> > bindings separate from the DU.  The device trees for all R-Car H3 and
> > M3-W development boards were ported over to the new model, but
> > Salvator-XS boards equipped with an R-Car M3-W SoC were forgotten.
> > 
> > Fixes: 58e8ed2ee9abe718 ("arm64: dts: renesas: Convert to new LVDS DT
> > bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Compile-tested only.
> 
> I can't test the patch either but it looks fine to me.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> I assume you will send this directly to Simon, so I don't plan to take the 
> patch in my tree.

Thanks, I have this one. I've applied this for v4.22.