Re: [PATCH v2 1/2] dt-bindings: clock: Add identifiers for VIIF on Toshiba Visconti TMPV770x SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/10/2025 07:13, Yuji Ishikawa wrote:
> Add clock and reset identifiers for the Video Input Interface.
> These identifiers support two instances: VIIF0 and VIIF1.
> 
> Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
> ---
> Changelog v2:
> - Do not modify existing identifiers to avoid breaking ABI.
>   Keep existing identfiers for VIIF0.
>   Introduce new idenfifiers for VIIF1, following the same naming conventions.
> ---
>  include/dt-bindings/clock/toshiba,tmpv770x.h | 15 +++++++++++++--
>  include/dt-bindings/reset/toshiba,tmpv770x.h | 10 +++++++++-
>  2 files changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/toshiba,tmpv770x.h b/include/dt-bindings/clock/toshiba,tmpv770x.h
> index 5fce71300..ff4ef1be5 100644
> --- a/include/dt-bindings/clock/toshiba,tmpv770x.h
> +++ b/include/dt-bindings/clock/toshiba,tmpv770x.h
> @@ -141,7 +141,10 @@
>  #define TMPV770X_CLK_PIREFCLK		124
>  #define TMPV770X_CLK_SBUS		125
>  #define TMPV770X_CLK_BUSLCK		126
> -#define TMPV770X_NR_CLK			127

You cannot change it, as explained last time. If this is not an ABI,
then in separate patch drop it (see examples in the history for Samsung,
NXP and probably many more SoCs).

Best regards,
Krzysztof