From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Rob Herring <robh+dt@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
linux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: Re: [PATCH v3 2/2] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml
Date: Wed, 11 Nov 2020 14:23:48 +0100 [thread overview]
Message-ID: <069937f4-9173-db5c-1297-3412cd3eaf8c@pengutronix.de> (raw)
In-Reply-To: <CAL_JsqKSdGAY03HK1SBGec-j4S0cmm-mntJ8e0ujHVX4E3dnMw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2360 bytes --]
On 11/10/20 4:43 PM, Rob Herring wrote:
> On Thu, Oct 22, 2020 at 2:52 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>>
>> In order to automate the verification of DT nodes convert
>> fsl-flexcan.txt to fsl,flexcan.yaml
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> Link: https://lore.kernel.org/r/20201016073315.16232-3-o.rempel@pengutronix.de
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> .../bindings/net/can/fsl,flexcan.yaml | 135 ++++++++++++++++++
>> .../bindings/net/can/fsl-flexcan.txt | 57 --------
>> 2 files changed, 135 insertions(+), 57 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
>> delete mode 100644 Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>
> Why did this go into v5.10-rc3? It's not a fix and now a fix is needed:
Sorry, this was against the rules and not a good idea.
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/clock/imx5-clock.example.dt.yaml:
> can@53fc8000: compatible: 'oneOf' conditional failed, one must be
> fixed:
> ['fsl,imx53-flexcan', 'fsl,p1010-flexcan'] is too long
> Additional items are not allowed ('fsl,p1010-flexcan' was unexpected)
> 'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan',
> 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
> 'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
> 'fsl,imx6q-flexcan' was expected
> 'fsl,lx2160ar1-flexcan' was expected
> From schema: /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/net/can/fsl,flexcan.example.dt.yaml:
> can@2090000: fsl,stop-mode: [[4294967295, 52, 28]] is too short
> From schema: /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
I've both issues and found two more. See the following thread for details:
http://lore.kernel.org/r/20201111130507.1560881-1-mkl@pengutronix.de
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-11-11 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 7:52 [PATCH v3 0/2] convert flexcan to the yaml Oleksij Rempel
2020-10-22 7:52 ` [PATCH v3 1/2] dt-bindings: can: add can-controller.yaml Oleksij Rempel
2020-10-30 15:34 ` Rob Herring
2020-10-22 7:52 ` [PATCH v3 2/2] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml Oleksij Rempel
2020-10-30 15:35 ` Rob Herring
2020-11-10 15:43 ` Rob Herring
2020-11-11 13:23 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069937f4-9173-db5c-1297-3412cd3eaf8c@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).