From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"William Zhang" <william.zhang@broadcom.com>,
"Anand Gore" <anand.gore@broadcom.com>,
"Kursad Oney" <kursad.oney@broadcom.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andre Przywara" <andre.przywara@arm.com>,
"Alexandre TORGUE" <alexandre.torgue@st.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART
Date: Wed, 22 Nov 2023 08:34:47 +0100 [thread overview]
Message-ID: <069a904d-08db-425c-88fc-3b7e8f4f713c@linaro.org> (raw)
In-Reply-To: <3a2880a4-cdf5-4032-9cae-be2916237d29@gmail.com>
On 22/11/2023 07:17, Rafał Miłecki wrote:
> On 21.11.2023 23:38, Krzysztof Kozlowski wrote:
>> On 21/11/2023 13:13, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>> +
>>> +properties:
>>> + compatible:
>>> + const: brcm,bcm63138-hs-uart
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> +required:
>>
>> Missing compatible.
>
> I stopped putting "compatible" in "required" in schemas back in 2020 :O
>
> Back then I received a comment from Rob [0] in discussion on
> [PATCH] dt-bindings: mtd: convert "fixed-partitions" to the json-schema
> telling to drop it:
>
> On 10.12.2020 03:48, Rob Herring wrote:
> > And drop 'compatible' as required. It's redundant anyways because the
> > schema will only be applied if compatible matches.
>
> So I'll need some help here please. Should I start including
> "compatible" in "required" after all? Or is that situation specific
> (could you explain what does it depend on)?
Hm, it is redundant, true, although I always preferred it listed to be
explicit. But in such case no problem:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-22 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:13 [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART Rafał Miłecki
2023-11-21 12:13 ` [PATCH 2/2] ARM: dts: broadcom: Add BCM63138's high speed UART Rafał Miłecki
2023-11-21 18:57 ` [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART William Zhang
2023-11-21 22:38 ` Krzysztof Kozlowski
2023-11-22 6:17 ` Rafał Miłecki
2023-11-22 7:34 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069a904d-08db-425c-88fc-3b7e8f4f713c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=anand.gore@broadcom.com \
--cc=andre.przywara@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=william.zhang@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).