[PATCH v7 0/6] ARM: dts: add support for exynos hdmi subsystem

[PATCH v7 0/6] ARM: dts: add support for exynos hdmi subsystem

[Rahul Sharma]

It adds Device tree nodes and clocks information for HDMI subsystem
for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi
hpd gpio and update binding documents.

This set is based on kukjin's for-next branch at
http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git.

v7:
1) Minor change in of-documentation.
2) Squash gpio pin-ctrl and ddc patch to one patch.

v6:
1) Update clock numbers as per change in mux and divider clocks.
2) Isolate board changes from SoC patch and add a different patch for ddc.

v5:
1) Merged Clock addition patch to DT nmde addition patch.
2) Add dout_pixel clock for hdmi in place of sclk_pixel.
3) Enable mixer node in soc dtsi file.

v4:
1) Remove the movement of common properties to Exynos5.dtsi for
I2C and hdmi subsystem.
2) Change the title of the patches.

v3:
1) Rebase to kgene for-next based on 3.11-rc1.
2) Changes clock numbers as per updated clocks file for
exyno5250 and exynos5420.
3) Dropped Sachin patch as already got merged.

v2:
1) Added patch for moving common i2c properties to exynos5.dtsi
2) Added patch for moving common hdmi, mixer properties to exynos5.dtsi
3) moved hpd pinctrl node to board file.
4) Added Sachin's patch to update binding document for hdmi with hpd
information.

Andrew Bresticker (1):
  ARM: dts: add i2c device nodes for Exynos5420

Rahul Sharma (4):
  of/documentation: update with clock information for exynos hdmi
    subsystem
  ARM: dts: add clocks to hdmi dt node for exynos5250
  ARM: dts: add dt nodes for hdmi subsystem for exynos5420
  ARM: dts: enable hdmi subsystem for exynos5420 smdk board

Sean Paul (1):
  ARM: dts: add mixer clocks to mixer node for Exynos5250

 .../devicetree/bindings/video/exynos_hdmi.txt      |   14 +++-
 .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
 arch/arm/boot/dts/exynos5250.dtsi                  |    8 ++-
 arch/arm/boot/dts/exynos5420-smdk5420.dts          |   26 +++++++
 arch/arm/boot/dts/exynos5420.dtsi                  |   75 ++++++++++++++++++++
 5 files changed, 123 insertions(+), 4 deletions(-)

-- 
1.7.10.4

Re: [PATCH v7 0/6] ARM: dts: add support for exynos hdmi subsystem

[Tomasz Figa]

Hi Rahul,

On Thursday 29 of August 2013 19:22:51 Rahul Sharma wrote:
> It adds Device tree nodes and clocks information for HDMI subsystem
> for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi
> hpd gpio and update binding documents.
> 
> This set is based on kukjin's for-next branch at
> http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git.
> 
> v7:
> 1) Minor change in of-documentation.
> 2) Squash gpio pin-ctrl and ddc patch to one patch.
> 
> v6:
> 1) Update clock numbers as per change in mux and divider clocks.
> 2) Isolate board changes from SoC patch and add a different patch for
> ddc.
> 
> v5:
> 1) Merged Clock addition patch to DT nmde addition patch.
> 2) Add dout_pixel clock for hdmi in place of sclk_pixel.
> 3) Enable mixer node in soc dtsi file.
> 
> v4:
> 1) Remove the movement of common properties to Exynos5.dtsi for
> I2C and hdmi subsystem.
> 2) Change the title of the patches.
> 
> v3:
> 1) Rebase to kgene for-next based on 3.11-rc1.
> 2) Changes clock numbers as per updated clocks file for
> exyno5250 and exynos5420.
> 3) Dropped Sachin patch as already got merged.
> 
> v2:
> 1) Added patch for moving common i2c properties to exynos5.dtsi
> 2) Added patch for moving common hdmi, mixer properties to exynos5.dtsi
> 3) moved hpd pinctrl node to board file.
> 4) Added Sachin's patch to update binding document for hdmi with hpd
> information.
> 
> Andrew Bresticker (1):
>   ARM: dts: add i2c device nodes for Exynos5420
> 
> Rahul Sharma (4):
>   of/documentation: update with clock information for exynos hdmi
>     subsystem
>   ARM: dts: add clocks to hdmi dt node for exynos5250
>   ARM: dts: add dt nodes for hdmi subsystem for exynos5420
>   ARM: dts: enable hdmi subsystem for exynos5420 smdk board
> 
> Sean Paul (1):
>   ARM: dts: add mixer clocks to mixer node for Exynos5250
> 
>  .../devicetree/bindings/video/exynos_hdmi.txt      |   14 +++-
>  .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
>  arch/arm/boot/dts/exynos5250.dtsi                  |    8 ++-
>  arch/arm/boot/dts/exynos5420-smdk5420.dts          |   26 +++++++
>  arch/arm/boot/dts/exynos5420.dtsi                  |   75
> ++++++++++++++++++++ 5 files changed, 123 insertions(+), 4 deletions(-)

The whole series looks good to me now. Thanks for keeping up with all the 
comments.

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

Re: [PATCH v7 0/6] ARM: dts: add support for exynos hdmi subsystem

[Rahul Sharma]

On 29 August 2013 19:05, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Rahul,
>
> On Thursday 29 of August 2013 19:22:51 Rahul Sharma wrote:
>> It adds Device tree nodes and clocks information for HDMI subsystem
>> for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi
>> hpd gpio and update binding documents.
>>
>> This set is based on kukjin's for-next branch at
>> http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git.
>>
>> v7:
>> 1) Minor change in of-documentation.
>> 2) Squash gpio pin-ctrl and ddc patch to one patch.
>>
>> v6:
>> 1) Update clock numbers as per change in mux and divider clocks.
>> 2) Isolate board changes from SoC patch and add a different patch for
>> ddc.
>>
>> v5:
>> 1) Merged Clock addition patch to DT nmde addition patch.
>> 2) Add dout_pixel clock for hdmi in place of sclk_pixel.
>> 3) Enable mixer node in soc dtsi file.
>>
>> v4:
>> 1) Remove the movement of common properties to Exynos5.dtsi for
>> I2C and hdmi subsystem.
>> 2) Change the title of the patches.
>>
>> v3:
>> 1) Rebase to kgene for-next based on 3.11-rc1.
>> 2) Changes clock numbers as per updated clocks file for
>> exyno5250 and exynos5420.
>> 3) Dropped Sachin patch as already got merged.
>>
>> v2:
>> 1) Added patch for moving common i2c properties to exynos5.dtsi
>> 2) Added patch for moving common hdmi, mixer properties to exynos5.dtsi
>> 3) moved hpd pinctrl node to board file.
>> 4) Added Sachin's patch to update binding document for hdmi with hpd
>> information.
>>
>> Andrew Bresticker (1):
>>   ARM: dts: add i2c device nodes for Exynos5420
>>
>> Rahul Sharma (4):
>>   of/documentation: update with clock information for exynos hdmi
>>     subsystem
>>   ARM: dts: add clocks to hdmi dt node for exynos5250
>>   ARM: dts: add dt nodes for hdmi subsystem for exynos5420
>>   ARM: dts: enable hdmi subsystem for exynos5420 smdk board
>>
>> Sean Paul (1):
>>   ARM: dts: add mixer clocks to mixer node for Exynos5250
>>
>>  .../devicetree/bindings/video/exynos_hdmi.txt      |   14 +++-
>>  .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
>>  arch/arm/boot/dts/exynos5250.dtsi                  |    8 ++-
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts          |   26 +++++++
>>  arch/arm/boot/dts/exynos5420.dtsi                  |   75
>> ++++++++++++++++++++ 5 files changed, 123 insertions(+), 4 deletions(-)
>
> The whole series looks good to me now. Thanks for keeping up with all the
> comments.

Thanks Tomasz.

>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>

Hi Mr. Kim,

Please consider this series for your for-next branch.

regards,
Rahul Sharma.

> Best regards,
> Tomasz
>

RE: [PATCH v7 0/6] ARM: dts: add support for exynos hdmi subsystem

[Kukjin Kim]

Rahul Sharma wrote:
> 
> On 29 August 2013 19:05, Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> > Hi Rahul,
> >
> > On Thursday 29 of August 2013 19:22:51 Rahul Sharma wrote:
> >> It adds Device tree nodes and clocks information for HDMI subsystem
> >> for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi
> >> hpd gpio and update binding documents.
> >>
> >> This set is based on kukjin's for-next branch at
> >> http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git.
> >>
> >> v7:
> >> 1) Minor change in of-documentation.
> >> 2) Squash gpio pin-ctrl and ddc patch to one patch.
> >>
> >> v6:
> >> 1) Update clock numbers as per change in mux and divider clocks.
> >> 2) Isolate board changes from SoC patch and add a different patch for
> >> ddc.
> >>
> >> v5:
> >> 1) Merged Clock addition patch to DT nmde addition patch.
> >> 2) Add dout_pixel clock for hdmi in place of sclk_pixel.
> >> 3) Enable mixer node in soc dtsi file.
> >>
> >> v4:
> >> 1) Remove the movement of common properties to Exynos5.dtsi for
> >> I2C and hdmi subsystem.
> >> 2) Change the title of the patches.
> >>
> >> v3:
> >> 1) Rebase to kgene for-next based on 3.11-rc1.
> >> 2) Changes clock numbers as per updated clocks file for
> >> exyno5250 and exynos5420.
> >> 3) Dropped Sachin patch as already got merged.
> >>
> >> v2:
> >> 1) Added patch for moving common i2c properties to exynos5.dtsi
> >> 2) Added patch for moving common hdmi, mixer properties to exynos5.dtsi
> >> 3) moved hpd pinctrl node to board file.
> >> 4) Added Sachin's patch to update binding document for hdmi with hpd
> >> information.
> >>
> >> Andrew Bresticker (1):
> >>   ARM: dts: add i2c device nodes for Exynos5420
> >>
> >> Rahul Sharma (4):
> >>   of/documentation: update with clock information for exynos hdmi
> >>     subsystem
> >>   ARM: dts: add clocks to hdmi dt node for exynos5250
> >>   ARM: dts: add dt nodes for hdmi subsystem for exynos5420
> >>   ARM: dts: enable hdmi subsystem for exynos5420 smdk board
> >>
> >> Sean Paul (1):
> >>   ARM: dts: add mixer clocks to mixer node for Exynos5250
> >>
> >>  .../devicetree/bindings/video/exynos_hdmi.txt      |   14 +++-
> >>  .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
> >>  arch/arm/boot/dts/exynos5250.dtsi                  |    8 ++-
> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts          |   26 +++++++
> >>  arch/arm/boot/dts/exynos5420.dtsi                  |   75
> >> ++++++++++++++++++++ 5 files changed, 123 insertions(+), 4 deletions(-)
> >
> > The whole series looks good to me now. Thanks for keeping up with all
> the
> > comments.
> 
> Thanks Tomasz.
> 
> >
> > Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >
Tomasz, thanks for your review.
> 
> Hi Mr. Kim,
> 
> Please consider this series for your for-next branch.
> 
Yeah, looks good to me as well. Applied this whole series.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v7 1/6] of/documentation: update with clock information for exynos hdmi subsystem

[Rahul Sharma]

Adding information about clocks to the binding documentation
for exynos mixer and hdmi.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 Documentation/devicetree/bindings/video/exynos_hdmi.txt  |   14 +++++++++++++-
 Documentation/devicetree/bindings/video/exynos_mixer.txt |    4 ++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
index 323983b..50decf8 100644
--- a/Documentation/devicetree/bindings/video/exynos_hdmi.txt
+++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
@@ -12,7 +12,19 @@ Required properties:
 	a) phandle of the gpio controller node.
 	b) pin number within the gpio controller.
 	c) optional flags and pull up/down.
-
+- clocks: list of clock IDs from SoC clock driver.
+	a) hdmi: Gate of HDMI IP bus clock.
+	b) sclk_hdmi: Gate of HDMI special clock.
+	c) sclk_pixel: Pixel special clock, one of the two possible inputs of
+		HDMI clock mux.
+	d) sclk_hdmiphy: HDMI PHY clock output, one of two possible inputs of
+		HDMI clock mux.
+	e) mout_hdmi: It is required by the driver to switch between the 2
+		parents i.e. sclk_pixel and sclk_hdmiphy. If hdmiphy is stable
+		after configuration, parent is set to sclk_hdmiphy else
+		sclk_pixel.
+- clock-names: aliases as per driver requirements for above clock IDs:
+	"hdmi", "sclk_hdmi", "sclk_pixel", "sclk_hdmiphy" and "mout_hdmi".
 Example:
 
 	hdmi {
diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt
index 3334b0a..7bfde9c 100644
--- a/Documentation/devicetree/bindings/video/exynos_mixer.txt
+++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt
@@ -10,6 +10,10 @@ Required properties:
 - reg: physical base address of the mixer and length of memory mapped
 	region.
 - interrupts: interrupt number to the cpu.
+- clocks: list of clock IDs from SoC clock driver.
+	a) mixer: Gate of Mixer IP bus clock.
+	b) sclk_hdmi: HDMI Special clock, one of the two possible inputs of
+               mixer mux.
 
 Example:
 
-- 
1.7.10.4

[PATCH v7 2/6] ARM: dts: add mixer clocks to mixer node for Exynos5250

[Rahul Sharma]

From: Sean Paul <seanpaul@chromium.org>

This patch adds the mixer clocks to the mixer node in the
exynos 5250 dts file.

Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 864ae90..2c41b2d 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -623,6 +623,8 @@
 		compatible = "samsung,exynos5250-mixer";
 		reg = <0x14450000 0x10000>;
 		interrupts = <0 94 0>;
+		clocks = <&clock 343>, <&clock 136>;
+		clock-names = "mixer", "sclk_hdmi";
 	};
 
 	dp_phy: video-phy@10040720 {
-- 
1.7.10.4

[PATCH v7 3/6] ARM: dts: add clocks to hdmi dt node for exynos5250

[Rahul Sharma]

Fix wrong clock numbers in hdmi dt node. Removed hdmiphy
clock which was a dummy clock earlier and not required now.
Also added mux clock to change the clock parent.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 2c41b2d..c2b4d95 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -613,10 +613,10 @@
 		compatible = "samsung,exynos4212-hdmi";
 		reg = <0x14530000 0x70000>;
 		interrupts = <0 95 0>;
-		clocks = <&clock 333>, <&clock 136>, <&clock 137>,
-				<&clock 333>, <&clock 333>;
+		clocks = <&clock 344>, <&clock 136>, <&clock 137>,
+				<&clock 159>, <&clock 1024>;
 		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
-				"sclk_hdmiphy", "hdmiphy";
+				"sclk_hdmiphy", "mout_hdmi";
 	};
 
 	mixer {
-- 
1.7.10.4

[PATCH v7 4/6] ARM: dts: add i2c device nodes for Exynos5420

[Rahul Sharma]

From: Andrew Bresticker <abrestic@chromium.org>

This adds device-tree nodes for the i2c busses on Exynos
5420 platforms.

Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |   56 +++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index d537cd7..77805a5 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -27,6 +27,10 @@
 		pinctrl2 = &pinctrl_2;
 		pinctrl3 = &pinctrl_3;
 		pinctrl4 = &pinctrl_4;
+		i2c0 = &i2c_0;
+		i2c1 = &i2c_1;
+		i2c2 = &i2c_2;
+		i2c3 = &i2c_3;
 	};
 
 	cpus {
@@ -235,4 +239,56 @@
 		io-channel-ranges;
 		status = "disabled";
 	};
+
+	i2c_0: i2c@12C60000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C60000 0x100>;
+		interrupts = <0 56 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 261>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c0_bus>;
+		status = "disabled";
+	};
+
+	i2c_1: i2c@12C70000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C70000 0x100>;
+		interrupts = <0 57 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 262>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c1_bus>;
+		status = "disabled";
+	};
+
+	i2c_2: i2c@12C80000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C80000 0x100>;
+		interrupts = <0 58 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 263>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c2_bus>;
+		status = "disabled";
+	};
+
+	i2c_3: i2c@12C90000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C90000 0x100>;
+		interrupts = <0 59 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&clock 264>;
+		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c3_bus>;
+		status = "disabled";
+	};
 };
-- 
1.7.10.4

[PATCH v7 5/6] ARM: dts: add dt nodes for hdmi subsystem for exynos5420

[Rahul Sharma]

Add hdmi and mixer device tree nodes for Exynos 5420 SoC.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 77805a5..09aa06c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -291,4 +291,23 @@
 		pinctrl-0 = <&i2c3_bus>;
 		status = "disabled";
 	};
+
+	hdmi@14530000 {
+		compatible = "samsung,exynos4212-hdmi";
+		reg = <0x14530000 0x70000>;
+		interrupts = <0 95 0>;
+		clocks = <&clock 413>, <&clock 143>, <&clock 768>,
+			<&clock 158>, <&clock 640>;
+		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
+			"sclk_hdmiphy", "mout_hdmi";
+		status = "disabled";
+	};
+
+	mixer@14450000 {
+		compatible = "samsung,exynos5420-mixer";
+		reg = <0x14450000 0x10000>;
+		interrupts = <0 94 0>;
+		clocks = <&clock 431>, <&clock 143>;
+		clock-names = "mixer", "sclk_hdmi";
+	};
 };
-- 
1.7.10.4

[PATCH v7 6/6] ARM: dts: enable hdmi subsystem for exynos5420 smdk board

[Rahul Sharma]

Add pinctrl node for hdmi hpd gpio pin to exynos5420 smdk board
file. hpd Gpio property is added to the hdmi node. This patch also
adds hdmi ddc node.

Both hdmi device and ddc i2c channel are enabled in
exynos5420-smdk5420.dts

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |   26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index bafba25..79524c7 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -61,4 +61,30 @@
 		};
 	};
 
+	pinctrl@13400000 {
+		hdmi_hpd_irq: hdmi-hpd-irq {
+			samsung,pins = "gpx3-7";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <1>;
+			samsung,pin-drv = <0>;
+		};
+	};
+
+	hdmi@14530000 {
+		status = "okay";
+		hpd-gpio = <&gpx3 7 0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hdmi_hpd_irq>;
+	};
+
+	i2c_2: i2c@12C80000 {
+		samsung,i2c-sda-delay = <100>;
+		samsung,i2c-max-bus-freq = <66000>;
+		status = "okay";
+
+		hdmiddc@50 {
+			compatible = "samsung,exynos4210-hdmiddc";
+			reg = <0x50>;
+		};
+	};
 };
-- 
1.7.10.4