From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C177D378D8E for ; Tue, 8 Sep 2026 08:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788854537; cv=none; b=X3eAyR6hItGgIPruM24D6vLr1qR6wmXdO6NURnNWRzHadPZUgXyU0tx7U4i45X3YL3rF0x+Lr479SQFGKjoHTo36AP/Xl7u8GDZbkjRErty6z2dnMGNXXB58jIbUIIz1z339cxFvZMIE/mCKolGoVVCBmYdTteaOFv+UCVkn0qM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788854537; c=relaxed/simple; bh=SBgXFYdNYEUPVWubdVb9unTaNhEgBh6xGV7DWi4TnQQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e+yi5w0VkiqeCafSqO++u0GmHCzV5uDOQKsXQclS1OUJ54nPve+YyksYt7y6+z6ADpPkOHj8c5meFB4q85DFNgN1tUZXAhTqpHb4WA66e5hqPcKFhUSccT38I9TNM9z/5Q8MTvNphYKBwcVmM5vZ1TR+w9tQYihDa+at8rjwOA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=arIuAESW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZXI7+1KO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="arIuAESW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZXI7+1KO" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886M1wW2979294 for ; Tue, 8 Sep 2026 08:02:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WozNudziLKgBxiX08uWyerO5nuWlCikb2YN/NDCsgqM=; b=arIuAESWcUWwrGI2 pjqkoOyJNILtKK2cq6jHIw1appcqCWGaIrfPiN9hHaHs8t++cmtKy3CztvswBNVD t/6GjjGovrE5VKW00dJhb7Di5oG4pOLrSRwr8G6SqWWHV1FuFCfZmy4YkB9ya1+K ocMxPyWERANVyf/04rKh2xg5jPmZiBXA5WaefWlk1WEX21EhXsYBQ3zNmjkhImXz /7lfYFr6uGGQjS4gm+sKQ6MLV5ExzzAtYG7G/n3z9v55eWrDxNxZ/2IDzXUQUCDa O6gJ401SKTb7APWF/bnEwrDYZif3Ao/9o7AHNWUmW0JvheanXxCTexjM44ZEqwbO cpWkFQ== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghuykbt5d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 08:02:14 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-783743bffb9so61249137.3 for ; Tue, 08 Sep 2026 01:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788854534; x=1789459334; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WozNudziLKgBxiX08uWyerO5nuWlCikb2YN/NDCsgqM=; b=ZXI7+1KOnex1vLq3oiTv+pwnS1arKhYcdBlEO9ktZHE6iIo6tSvOMFLZeT8feAMV7Q 0vHutoax6xqfJQ6zYPJNoHe5u0z73dpc5xuqLwqe3gnhA5PLoAcnBZbbCPlstNpuVuNG 2x6nuk2CMwElwJ2LNcvnJKrWg3mBzorMexyOdP8UWYNqmU1zobZyOxDthjR2ZlPlmWFt yC8SUShCqI5IEbg49qKmPa+7/H11ukYUWkrHGd0rDTqtR+fjUnE1DGiN1Cet8MkvRHjV 0r3MGQuX5OftvJfyQtBHg+kCWKc9bDn+t+Z6Cpcc699pP71BqpI1rhepjSSBTyuoub36 lPzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788854534; x=1789459334; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WozNudziLKgBxiX08uWyerO5nuWlCikb2YN/NDCsgqM=; b=CCZaJkS3AaIBiLjIhqHcFPfOLA0RiaHKg5V4X/O+YU0Gi6l8H9wd7jFyEb7GmQLZN+ fNElDY6+C3XKzmlDbSJUO9NjY33mOiQuZM17618OSPzYqGeCVJndRLwxPnglgQlPLlZs lrBV2EeuxhG9TulC9AEtGNIo2DDlGd81D1gGjMn0AV8lyaRU+WXAHyddEoVgGUIUm4V+ Y3Kn5QA+EQ0f4XIDkSZOvph5P1jbENeHh86fgnpxkGoN7MM7M1dy29gqjOnGZSseECxg HRAMTrdWQPqFkCAfHuuUff0HHSQYAHH1f/Ix4/CDMmivLgo8TNzwk4C9se3019PjOe4N 3ePQ== X-Forwarded-Encrypted: i=1; AKwUvBwC8VzJimtEhgUhFKEYcu4tRpNsq6Mj+P/6LLCcoiL9NOy2CSM1cJIXeYJYYY9k+oazybeBT1JJN3c9@vger.kernel.org X-Gm-Message-State: AFuF++lmEjj2slmmQeDj9Jy1SsgpAzS2hDxAqg3l0JvYWq9JahXhXn2/ 3uMPNp5Semov5HhtVPdceWu6mfDn3FtvVfjbHOndAbgCsQYzDx4OFd+QKm15fzS6MFhT9sEXLRZ f9WqOHcDz6pFOQRDlkSUCUrb9N0/v3S1K26j5cWB3yJvOoo+07t0K1exz5jtyC0P5 X-Gm-Gg: AYBFou0pxPoLsdQRmmIFdIoqBr21N9XYijQB7zPHDk2cgsaEVaY7wn3VnhQBwAN0eNM 0vK+XVNxm+5BoHA0Jzb06r7vUrM/iZem56AqNybTt4gOVewTv2eG9mgXKrkzrzmz6+E9x1t6vmE aY9QYjzWm87ZXbNSAv+8abedGj6G/ngaSk4eKS//4Xu/5/mL6pF2t0TojmfvK82X8wMHcvCsas+ vu8XDgidNqizvZsyhmhpXdx0c8tcBYNds4e2P3uUVznNJKo0bwgt6u3vQahXkSc2oJWQVxCxr4Y 1N+v8a148xKl5SGG41zRc2RUYb+I0zjnupA1c5WddYTysXXWiwX3drEalMejcsZwbzRAEb4fiPO j0NmJsfRgTrr8LXHYkJ/Tjg== X-Received: by 2002:a05:6102:b03:b0:781:9922:78f3 with SMTP id ada2fe7eead31-78a60e5b62amr2664028137.2.1788854533909; Tue, 08 Sep 2026 01:02:13 -0700 (PDT) X-Received: by 2002:a05:6102:b03:b0:781:9922:78f3 with SMTP id ada2fe7eead31-78a60e5b62amr2664022137.2.1788854533373; Tue, 08 Sep 2026 01:02:13 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c260d559364sm565451966b.35.2026.09.08.01.02.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2026 01:02:12 -0700 (PDT) Message-ID: <06bb2b19-bdb0-4dcc-a6e2-6805edd9084e@oss.qualcomm.com> Date: Tue, 8 Sep 2026 10:02:09 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] drm/msm/hdmi_phy: Cleanup after msm_hdmi_phy_resource_enable() failure To: Krzysztof Kozlowski , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> <20260908-drm-msm-hdmi-fixes-before-eliza-v3-1-dcf8956878ca@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-1-dcf8956878ca@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA4MiBTYWx0ZWRfX4/uQyeoWncu0 zYdVxvEOEpImkTd5ltl4krZsuAcQ+AhTtsMkC3aDRqdsXBDLJXYbFlmO8DNJNjqIk7LEovqeo9y 93+EOEkPpsEeeKqzlDDumxtEzIuo7qE= X-Proofpoint-GUID: tCMFHoG-2A6OCqXnzovjO4gRcN5Y6Fiq X-Authority-Analysis: v=2.4 cv=ObSoyBTY c=1 sm=1 tr=0 ts=6a9fc106 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=dCp4QOuT8fr3gmi_UlEA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-ORIG-GUID: tCMFHoG-2A6OCqXnzovjO4gRcN5Y6Fiq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA4MiBTYWx0ZWRfXyDq48pYgWKYR fEFhS+kkuoMkVqlss2fNv+dY13PVy1vapbRzZRx8qJxfQnU0kvPx4x4byLjvV1B/dugDo2+BjkA ZBOiKu76uGzfKKz4KwcnzijMV3SGrgzzjKtWbKEui04wgtTWpblmRmrNnuOzJzFGCew0TA8/wGc JyCsmRM8o2+ijnnUGScPEyq6gnqyCFKBXdafnPzuuXyD9CmQhZc7TQ9H2bh2AecH0SCdB8MUqEU vylYXJFy5+lOBDavmxxn1gTp6HtF7OOa9B/U4Y9mq4vcg4PeKkxbaF8KHDHP8JV238YtQNzlKv3 2WvW8BCU+KulreSSIwlvWvXSIDEneadvglKKwKdH/kXXwnVZR/0YSTVCgHQO09RUZLUtT4a2MxJ PIcEs5/HXINoe3ibGVgGU4dgNWUCvHwgEmTf/cv4udvXyoeNU8cpknHTWEFkODSnDwV/B5fq1Id DxH09gySQ9uxCzp6Xmg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080082 On 9/8/26 9:10 AM, Krzysztof Kozlowski wrote: > If msm_hdmi_phy_resource_enable() fails, e.g. when enabling regulators, > it should reverse the state of things already changed. > msm_hdmi_phy_resource_enable() is used also in probe path, thus such > failure, which could be simple deferred probe, would leave these > resources permanently enabled for the rest of the runtime. > > Cc: > Fixes: 15b4a4523859 ("drm/msm/hdmi: Create a separate HDMI PHY driver") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c > index eb1088755cb3..15e37596bdb1 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c > @@ -67,16 +67,28 @@ int msm_hdmi_phy_resource_enable(struct hdmi_phy *phy) > ret = regulator_bulk_enable(cfg->num_regs, phy->regs); > if (ret) { > DRM_DEV_ERROR(dev, "failed to enable regulators: (%d)\n", ret); > - return ret; > + goto err_pm_put; If you're a fan, there's PM_RUNTIME_ACQUIRE_xxx in cleanup.h Konrad