devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: monaco-evk: Enable TPM (ST33)
@ 2025-11-14 10:17 Khalid Faisal Ansari
  2025-11-14 10:26 ` Krzysztof Kozlowski
  2025-11-14 22:00 ` Konrad Dybcio
  0 siblings, 2 replies; 3+ messages in thread
From: Khalid Faisal Ansari @ 2025-11-14 10:17 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Khalid Faisal Ansari

Enable ST33HTPM TPM over SPI10 on the Monaco IoT EVK by adding the
required SPI and TPM nodes.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
---
Hi,

As part of TPM support enablement on Monaco EVK, the following tests were performed to verify functionality: 

- TPM detected via tpm_tis_spi driver
- Verified functionality using tpm2-tools:
    * tpm2_getrandom
    * tpm2_rsadecrypt
    * Other basic TPM oeprations
---
 arch/arm64/boot/dts/qcom/monaco-evk.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index e72cf6725a52..ca1bf3cc69bd 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -432,6 +432,16 @@ &serdes0 {
 	status = "okay";
 };
 
+&spi10 {
+	status = "okay";
+
+	tpm@0 {
+		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+	};
+};
+
 &tlmm {
 	ethernet0_default: ethernet0-default-state {
 		ethernet0_mdc: ethernet0-mdc-pins {

---
base-commit: 6fa9041b7177f6771817b95e83f6df17b147c8c6
change-id: 20251114-enable-tpm-monaco-855816b60bc5

Best regards,
-- 
Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable TPM (ST33)
  2025-11-14 10:17 [PATCH] arm64: dts: qcom: monaco-evk: Enable TPM (ST33) Khalid Faisal Ansari
@ 2025-11-14 10:26 ` Krzysztof Kozlowski
  2025-11-14 22:00 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-14 10:26 UTC (permalink / raw)
  To: Khalid Faisal Ansari, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 14/11/2025 11:17, Khalid Faisal Ansari wrote:
> Enable ST33HTPM TPM over SPI10 on the Monaco IoT EVK by adding the
> required SPI and TPM nodes.
> 
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> ---
> Hi,
> 
> As part of TPM support enablement on Monaco EVK, the following tests were performed to verify functionality: 
> 


Please organize your work in patchsets so handling and reviewing it will
be easy for us. Submitting patches explains more how to do it.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable TPM (ST33)
  2025-11-14 10:17 [PATCH] arm64: dts: qcom: monaco-evk: Enable TPM (ST33) Khalid Faisal Ansari
  2025-11-14 10:26 ` Krzysztof Kozlowski
@ 2025-11-14 22:00 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-11-14 22:00 UTC (permalink / raw)
  To: Khalid Faisal Ansari, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 11/14/25 11:17 AM, Khalid Faisal Ansari wrote:
> Enable ST33HTPM TPM over SPI10 on the Monaco IoT EVK by adding the
> required SPI and TPM nodes.
> 
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-14 22:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-14 10:17 [PATCH] arm64: dts: qcom: monaco-evk: Enable TPM (ST33) Khalid Faisal Ansari
2025-11-14 10:26 ` Krzysztof Kozlowski
2025-11-14 22:00 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).