Re: [PATCH 5/5] ARM: dts: BCM5301X: Disable unused gmac0 and gmac2 on Asus RT-AC88U

["Rafał Miłecki" <rafal@milecki.pl>]

On 2022-04-01 12:20, Arınç ÜNAL wrote:
> Disable gmac0 and gmac2 which are currently not used. This doesn't seem 
> to
> be implemented yet on drivers/net/ethernet/broadcom/bgmac-bcma.c but 
> this
> change is harmless, nonetheless.

It doesn't matter whether Linux respects that.


> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts
> b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts
> index 2f944d1c0330..0f5c5d576814 100644
> --- a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts
> +++ b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts
> @@ -242,11 +242,19 @@ fixed-link {
>  	};
>  };
> 
> +&gmac0 {
> +	status = "disabled";
> +};
> +
>  &gmac1 {
>  	nvmem-cells = <&et1macaddr>;
>  	nvmem-cell-names = "mac-address";
>  };
> 
> +&gmac2 {
> +	status = "disabled";
> +};

I don't think that is correct. Those interfaces are still there and
they are actually connected to switch ports. If you configure your
switch properly you can use them.

Someone may want to use e.g. gmac0 & gmac1 with two sets of ports to
speed up network communication.

I think gmac2 is required if you want to enable FA (flow acceleration /
accelerator) - even though there isn't Linux driver for it yet.

They are not disabled / unpopulated / non functional interfaces.