From: Krzysztof Kozlowski <krzk@kernel.org>
To: "sunyeal.hong" <sunyeal.hong@samsung.com>,
'Krzysztof Kozlowski' <krzk+dt@kernel.org>,
'Rob Herring' <robh@kernel.org>,
'Conor Dooley' <conor+dt@kernel.org>,
'Alim Akhtar' <alim.akhtar@samsung.com>,
'Sylwester Nawrocki' <s.nawrocki@samsung.com>,
'Chanwoo Choi' <cw00.choi@samsung.com>,
'Michael Turquette' <mturquette@baylibre.com>,
'Stephen Boyd' <sboyd@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc and hsi0/1 clock support
Date: Mon, 7 Oct 2024 10:06:50 +0200 [thread overview]
Message-ID: <06fd4e7e-d401-49bb-81f1-47fcea2dbbee@kernel.org> (raw)
In-Reply-To: <00a501db188f$8a7142b0$9f53c810$@samsung.com>
On 07/10/2024 10:04, sunyeal.hong wrote:
> Hello Krzysztof,
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Monday, September 30, 2024 8:36 PM
>> To: Sunyeal Hong <sunyeal.hong@samsung.com>; Krzysztof Kozlowski
>> <krzk+dt@kernel.org>; Rob Herring <robh@kernel.org>; Conor Dooley
>> <conor+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>; Sylwester
>> Nawrocki <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>;
>> Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
>> <sboyd@kernel.org>
>> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
>> linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>> clk@vger.kernel.org
>> Subject: Re: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc
>> and hsi0/1 clock support
>>
>> On 12/09/2024 12:38, Sunyeal Hong wrote:
>>> Like CMU_PERIC1, this provides clocks for USI09 ~ USI17, USI_I2C and
>> USI_I3C.
>>> Like CMU_MISC, this provides clocks for MISC, GIC and OTP.
>>> Like CMU_HSI0, this provides clocks for PCIE.
>>> Like CMU_HSI1, this provides clocks for USB and MMC.
>>>
>>> Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com>
>>> ---
>>
>> ...
>>
>>> +
>>> static int __init exynosautov920_cmu_probe(struct platform_device
>>> *pdev) {
>>> const struct samsung_cmu_info *info; @@ -1154,6 +1431,19 @@ static
>>> const struct of_device_id exynosautov920_cmu_of_match[] = {
>>> {
>>> .compatible = "samsung,exynosautov920-cmu-peric0",
>>> .data = &peric0_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-peric1",
>>> + .data = &peric1_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-misc",
>>> + .data = &misc_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-hsi0",
>>> + .data = &hsi0_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-hsi1",
>>> + .data = &hsi1_cmu_info,
>>> + }, {
>>
>> This is unrelated change. Please rebase.
>>
> Could you please explain in more detail the comment mentioned above?
You were growing this list, didn't you? Then adding sentinel is unrelated.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-07 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240912103903epcas2p3ff3df48eb8b19d27053b2c2fe40ea1c5@epcas2p3.samsung.com>
2024-09-12 10:38 ` [PATCH 0/3] add clocks support for exynosauto v920 SoC Sunyeal Hong
[not found] ` <CGME20240912103903epcas2p41445f34714dbc5c63bad5dd044965b5f@epcas2p4.samsung.com>
2024-09-12 10:38 ` [PATCH 1/3] dt-bindings: clock: exynosautov920: add peric1, misc and hsi0/1 clock definitions Sunyeal Hong
[not found] ` <CGME20240912103903epcas2p4fb9aaeafb223b63c57c2f0cac7f37c3d@epcas2p4.samsung.com>
2024-09-12 10:38 ` [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc and hsi0/1 clock support Sunyeal Hong
2024-09-30 11:36 ` Krzysztof Kozlowski
2024-10-07 8:04 ` sunyeal.hong
2024-10-07 8:06 ` Krzysztof Kozlowski [this message]
2024-10-07 8:39 ` sunyeal.hong
[not found] ` <CGME20240912103903epcas2p1ad72b43cca455c810d15a2c5ff5c5986@epcas2p1.samsung.com>
2024-09-12 10:38 ` [PATCH 3/3] arm64: dts: exynosautov920: add peric1, misc and hsi0/1 clock DT nodes Sunyeal Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06fd4e7e-d401-49bb-81f1-47fcea2dbbee@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=sunyeal.hong@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).