From: Kevin Xie <kevin.xie@starfivetech.com>
To: Rob Herring <robh+dt@kernel.org>,
Minda Chen <minda.chen@starfivetech.com>
Cc: "Daire McNamara" <daire.mcnamara@microchip.com>,
"Conor Dooley" <conor@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Emil Renner Berthing" <emil.renner.berthing@canonical.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Mason Huo" <mason.huo@starfivetech.com>,
"Leyfoon Tan" <leyfoon.tan@starfivetech.com>
Subject: Re: [PATCH v5 11/11] riscv: dts: starfive: add PCIe dts configuration for JH7110
Date: Tue, 12 Sep 2023 10:02:39 +0800 [thread overview]
Message-ID: <071513f5-941c-5152-f9c9-07406b6a0641@starfivetech.com> (raw)
In-Reply-To: <CAL_Jsq+TeDK0Lh7Yf9CwLPDPfvuv9C8A6dKDEBVxMtncyuzQQg@mail.gmail.com>
On 2023/9/8 1:19, Rob Herring wrote:
> On Thu, Sep 7, 2023 at 4:11 AM Minda Chen <minda.chen@starfivetech.com> wrote:
>>
>> Add PCIe dts configuraion for JH7110 SoC platform.
>>
>> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
>> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
>> ---
>> .../jh7110-starfive-visionfive-2.dtsi | 64 ++++++++++++++
>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 86 +++++++++++++++++++
>> 2 files changed, 150 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> index de0f40a8be93..4dd61e2fec7d 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> @@ -15,6 +15,8 @@
>> i2c2 = &i2c2;
>> i2c5 = &i2c5;
>> i2c6 = &i2c6;
>> + pcie0 = &pcie0;
>> + pcie1 = &pcie1;
>
> That's not a defined alias. We already have "linux,pci-domain" if you
> need to number PCI host bridges.
>
Okay, we will number PCI host bridges by "linux,pci-domain".
>> serial0 = &uart0;
>> };
>>
>> @@ -208,6 +210,54 @@
>> };
>> };
>>
>> + pcie0_pins: pcie0-0 {
>> + wake-pins {
>> + pinmux = <GPIOMUX(32, GPOUT_LOW,
>> + GPOEN_DISABLE,
>> + GPI_NONE)>;
>> + bias-pull-up;
>> + drive-strength = <2>;
>> + input-enable;
>> + input-schmitt-disable;
>> + slew-rate = <0>;
>> + };
>> +
>> + clkreq-pins {
>> + pinmux = <GPIOMUX(27, GPOUT_LOW,
>> + GPOEN_DISABLE,
>> + GPI_NONE)>;
>> + bias-pull-down;
>> + drive-strength = <2>;
>> + input-enable;
>> + input-schmitt-disable;
>> + slew-rate = <0>;
>> + };
>> + };
>> +
>> + pcie1_pins: pcie1-0 {
>> + wake-pins {
>> + pinmux = <GPIOMUX(21, GPOUT_LOW,
>> + GPOEN_DISABLE,
>> + GPI_NONE)>;
>> + bias-pull-up;
>> + drive-strength = <2>;
>> + input-enable;
>> + input-schmitt-disable;
>> + slew-rate = <0>;
>> + };
>> +
>> + clkreq-pins {
>> + pinmux = <GPIOMUX(29, GPOUT_LOW,
>> + GPOEN_DISABLE,
>> + GPI_NONE)>;
>> + bias-pull-down;
>> + drive-strength = <2>;
>> + input-enable;
>> + input-schmitt-disable;
>> + slew-rate = <0>;
>> + };
>> + };
>> +
>> uart0_pins: uart0-0 {
>> tx-pins {
>> pinmux = <GPIOMUX(5, GPOUT_SYS_UART0_TX,
>> @@ -233,6 +283,20 @@
>> };
>> };
>>
>> +&pcie0 {
>> + pinctrl-names = "default";
>> + perst-gpios = <&sysgpio 26 GPIO_ACTIVE_LOW>;
>> + pinctrl-0 = <&pcie0_pins>;
>> + status = "okay";
>> +};
>> +
>> +&pcie1 {
>> + pinctrl-names = "default";
>> + perst-gpios = <&sysgpio 28 GPIO_ACTIVE_LOW>;
>> + pinctrl-0 = <&pcie1_pins>;
>> + status = "okay";
>> +};
>> +
>> &uart0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&uart0_pins>;
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> index 02354e642c44..7a5dc43cf63c 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> @@ -629,5 +629,91 @@
>> #reset-cells = <1>;
>> power-domains = <&pwrc JH7110_PD_VOUT>;
>> };
>> +
>> + pcie0: pcie@940000000 {
>> + compatible = "starfive,jh7110-pcie";
>> + reg = <0x9 0x40000000 0x0 0x1000000>,
>> + <0x0 0x2b000000 0x0 0x100000>;
>> + reg-names = "cfg", "apb";
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + #interrupt-cells = <1>;
>> + ranges = <0x82000000 0x0 0x30000000 0x0 0x30000000 0x0 0x08000000>,
>> + <0xc3000000 0x9 0x00000000 0x9 0x00000000 0x0 0x40000000>;
>> + interrupts = <56>;
>> + interrupt-parent = <&plic>;
>> + interrupt-map-mask = <0x0 0x0 0x0 0x7>;
>> + interrupt-map = <0x0 0x0 0x0 0x1 &pcie_intc0 0x1>,
>> + <0x0 0x0 0x0 0x2 &pcie_intc0 0x2>,
>> + <0x0 0x0 0x0 0x3 &pcie_intc0 0x3>,
>> + <0x0 0x0 0x0 0x4 &pcie_intc0 0x4>;
>> + msi-controller;
>> + device_type = "pci";
>> + starfive,stg-syscon = <&stg_syscon>;
>> + bus-range = <0x0 0xff>;
>> + clocks = <&syscrg JH7110_SYSCLK_NOC_BUS_STG_AXI>,
>> + <&stgcrg JH7110_STGCLK_PCIE0_TL>,
>> + <&stgcrg JH7110_STGCLK_PCIE0_AXI_MST0>,
>> + <&stgcrg JH7110_STGCLK_PCIE0_APB>;
>> + clock-names = "noc", "tl", "axi_mst0", "apb";
>> + resets = <&stgcrg JH7110_STGRST_PCIE0_AXI_MST0>,
>> + <&stgcrg JH7110_STGRST_PCIE0_AXI_SLV0>,
>> + <&stgcrg JH7110_STGRST_PCIE0_AXI_SLV>,
>> + <&stgcrg JH7110_STGRST_PCIE0_BRG>,
>> + <&stgcrg JH7110_STGRST_PCIE0_CORE>,
>> + <&stgcrg JH7110_STGRST_PCIE0_APB>;
>> + reset-names = "mst0", "slv0", "slv", "brg",
>> + "core", "apb";
>> + status = "disabled";
>> +
>> + pcie_intc0: interrupt-controller {
>> + #address-cells = <0>;
>> + #interrupt-cells = <1>;
>> + interrupt-controller;
>> + };
>> + };
>> +
>> + pcie1: pcie@9c0000000 {
>> + compatible = "starfive,jh7110-pcie";
>> + reg = <0x9 0xc0000000 0x0 0x1000000>,
>> + <0x0 0x2c000000 0x0 0x100000>;
>> + reg-names = "cfg", "apb";
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + #interrupt-cells = <1>;
>> + ranges = <0x82000000 0x0 0x38000000 0x0 0x38000000 0x0 0x08000000>,
>> + <0xc3000000 0x9 0x80000000 0x9 0x80000000 0x0 0x40000000>;
>> + interrupts = <57>;
>> + interrupt-parent = <&plic>;
>> + interrupt-map-mask = <0x0 0x0 0x0 0x7>;
>> + interrupt-map = <0x0 0x0 0x0 0x1 &pcie_intc1 0x1>,
>> + <0x0 0x0 0x0 0x2 &pcie_intc1 0x2>,
>> + <0x0 0x0 0x0 0x3 &pcie_intc1 0x3>,
>> + <0x0 0x0 0x0 0x4 &pcie_intc1 0x4>;
>> + msi-controller;
>> + device_type = "pci";
>> + starfive,stg-syscon = <&stg_syscon>;
>> + bus-range = <0x0 0xff>;
>> + clocks = <&syscrg JH7110_SYSCLK_NOC_BUS_STG_AXI>,
>> + <&stgcrg JH7110_STGCLK_PCIE1_TL>,
>> + <&stgcrg JH7110_STGCLK_PCIE1_AXI_MST0>,
>> + <&stgcrg JH7110_STGCLK_PCIE1_APB>;
>> + clock-names = "noc", "tl", "axi_mst0", "apb";
>> + resets = <&stgcrg JH7110_STGRST_PCIE1_AXI_MST0>,
>> + <&stgcrg JH7110_STGRST_PCIE1_AXI_SLV0>,
>> + <&stgcrg JH7110_STGRST_PCIE1_AXI_SLV>,
>> + <&stgcrg JH7110_STGRST_PCIE1_BRG>,
>> + <&stgcrg JH7110_STGRST_PCIE1_CORE>,
>> + <&stgcrg JH7110_STGRST_PCIE1_APB>;
>> + reset-names = "mst0", "slv0", "slv", "brg",
>> + "core", "apb";
>> + status = "disabled";
>> +
>> + pcie_intc1: interrupt-controller {
>> + #address-cells = <0>;
>> + #interrupt-cells = <1>;
>> + interrupt-controller;
>> + };
>> + };
>> };
>> };
>> --
>> 2.17.1
>>
prev parent reply other threads:[~2023-09-12 2:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 9:10 [PATCH v5 0/11] Refactoring Microchip PCIe driver and add StarFive PCIe Minda Chen
2023-09-07 9:10 ` [PATCH v5 01/11] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Minda Chen
2023-09-07 9:10 ` [PATCH v5 02/11] PCI: microchip: Move pcie-microchip-host.c to plda directory Minda Chen
2023-09-07 9:10 ` [PATCH v5 03/11] PCI: microchip: Move PLDA IP register macros to pcie-plda.h Minda Chen
2023-09-07 9:10 ` [PATCH v5 04/11] PCI: microchip: Rename data structure and functions Minda Chen
2023-09-07 9:10 ` [PATCH v5 05/11] PCI: plda: Move the common functions to pcie-plda-host.c Minda Chen
2023-09-07 9:10 ` [PATCH v5 06/11] PCI: plda: Add event interrupt codes and IRQ domain ops Minda Chen
2023-09-07 9:10 ` [PATCH v5 07/11] PCI: microchip: Rename IRQ init function Minda Chen
2023-09-07 9:10 ` [PATCH v5 08/11] PCI: microchip: Move IRQ init functions to pcie-plda-host.c Minda Chen
2023-09-07 9:10 ` [PATCH v5 09/11] dt-bindings: PCI: Add StarFive JH7110 PCIe controller Minda Chen
2023-09-07 9:10 ` [PATCH v5 10/11] PCI: starfive: Add " Minda Chen
2023-09-07 9:10 ` [PATCH v5 11/11] riscv: dts: starfive: add PCIe dts configuration for JH7110 Minda Chen
2023-09-07 17:19 ` Rob Herring
2023-09-12 2:02 ` Kevin Xie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=071513f5-941c-5152-f9c9-07406b6a0641@starfivetech.com \
--to=kevin.xie@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mason.huo@starfivetech.com \
--cc=minda.chen@starfivetech.com \
--cc=p.zabel@pengutronix.de \
--cc=pali@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).